🎨 Removed member bulk deletion safeguard from safe queries (#20747 )

fixes https://linear.app/tryghost/issue/ENG-1484

- in Ghost release
[v5.89.0](https://github.com/TryGhost/Ghost/releases/tag/v5.89.0), we
have added a safeguard around bulk member deletion, due to a limitation
in NQL for member filters (commit: 2484a77)
- with this change, we limit the safeguard to only the cases we know are
problematic, and remove it for other useful and safe queries
- more precisely, the safeguard is in place only when:
    - Multiple newsletters exist, and the filter contains 2 or more
newsletter filters
    - If any of the following stripe filters are used even once:
        - Billing period
        - Stripe subscription status
        - Paid start date
        - Next billing date
        - Subscription started on post/page
        - Offers

2024-08-14 15:48:54 +00:00

2.0 KiB

Raw Permalink Blame History

Ghost-Admin

This is the home of the Ember.js-based Admin app that ships with Ghost.

Test

Running tests in the browser

Run all tests in the browser by running yarn dev in the Ghost monorepo and visiting http://localhost:4200/tests. The code is hotloaded on change and you can filter which tests to run.

Testing public documentation

Tip: You can use this.timeout(0); await this.pauseTest(); in your tests to temporarily pause the execution of browser tests. Use the browser console to inspect and debug the DOM, then resume tests by running resumeTest() directly in the browser console (docs)

Running tests in the CLI

To build and run tests in the CLI, you can use:

TZ=UTC yarn test

Note the TZ=UTC environment variable which is currently required to get tests working if your system timezone doesn't match UTC.

However, this is very slow when writing tests, as it requires the app to be rebuilt on every change. Instead, create a separate watching build with:

yarn build --environment=test -w -o="dist-test"

Then run tests with:

TZ=UTC yarn test 1 --reporter dot --path="dist-test"

The --reporter dot shows a dot (.) for every successful test, and F for every failed test. It renders the output of the failed tests only.

To run a specific test file:

TZ=UTC yarn test 1 --reporter dot --path="dist-test" -mp=tests/unit/helpers/gh-count-characters-test.js

To have a full list of the available options, run

ember exam --help

Copyright & License

Copyright (c) 2013-2024 Ghost Foundation - Released under the MIT license. Ghost and the Ghost Logo are trademarks of Ghost Foundation Ltd. Please see our trademark policy for info on acceptable usage.

2.0 KiB Raw Permalink Blame History