Commit Graph

35576 Commits

Author SHA1 Message Date
Daniel Lockyer
5b7a89d8fc Deduplicated execution check in CI workflow
- we only need this on the metadata step because it trickles down to the
  other workflows that depend on it
2023-07-10 09:55:19 +02:00
Naz
cb8e009c14 Allowed for index collection to have empty filter
refs https://github.com/TryGhost/Arch/issues/25

- The built in index (soon -> "latest") collection does not require any filtering so that it could contain an index of all posts in the system. All other automatic collections should have a filter defined.
2023-07-10 12:43:52 +08:00
Daniel Lockyer
6f5f608bcd Fixed resetting database in migrations tests
- due to schema changes between versions, we need to completely nuke the
  DB between these tests
- this is definitely not the best way to do it but I'll fix properly next week
2023-07-07 18:42:18 +02:00
Ghost CI
7dfbaefa3e v5.54.0 2023-07-07 16:05:47 +00:00
Ghost CI
2ecdd01abf 🎨 Updated Casper to v5.5.3 2023-07-07 16:05:47 +00:00
Rishabh
f2b924ca96 Added hidden state for portal preview frame in adminX
refs https://github.com/TryGhost/Product/issues/3545

- hides portal frame till portal is ready and loaded
2023-07-07 21:28:26 +05:30
Kevin Ansfield
d8d0bc8bd9
Moved posts_meta.hide_title_and_feature_image to posts.show_title_and_feature_image (#17239)
no issue

`show_title_and_feature_image` leads to more intuitive logic in themes and we can use `posts` rather than `posts_meta` as there are no longer row-length issues with MySQL 8.

- removed original add-column migration that was never in a release
- added new add-column migration that puts
`show_title_and_feature_image` column with a default of `true` on the `posts` table
- renamed property and default value everywhere
- bumped `@tryghost/admin-api-schema` to allow the new property through at the API level
2023-07-07 16:40:22 +01:00
Daniel Lockyer
b433686944 Released Portal v2.33.5 2023-07-07 16:12:41 +02:00
Daniel Lockyer
c5aea0caee Fixed showing name in Portal notification
fixes https://github.com/TryGhost/Ghost/issues/17242

- we weren't passing the correct parameter to the translation function,
  so the name placeholder wasn't being replaced
2023-07-07 16:12:41 +02:00
Daniel Lockyer
b6131f0631 Fixed canary build triggering
- this previously wouldn't trigger if any of the `needs` are skipped
- this switches to waiting for the actual job which checks if all
  required jobs were completed successfully
2023-07-07 15:30:22 +02:00
Peter Zimon
ca3fe7d9db
Added routing to Portal (#17240)
refs. https://github.com/TryGhost/Product/issues/3545

Routing for Portal settings in AdminX was missing
2023-07-07 13:23:36 +00:00
Peter Zimon
702c88b9ba
AdminX Portal settings refinements (#17238)
refs. https://github.com/TryGhost/Product/issues/3545

- Device selector is not needed in Portal settings' preview
- Links page was too wide
- Scrolling for preview contents was on the whole modal instead of just the preview area
2023-07-07 13:03:06 +00:00
Rishabh
26c2590923 Wired save button state for portal settings modal
refs https://github.com/TryGhost/Product/issues/3545

- adds dynamic loading state for portal modal save button
2023-07-07 16:30:59 +05:30
Rishabh
ad0e52ac39 Wired tier selection for portal links
refs https://github.com/TryGhost/Product/issues/3545

Enables tier selection on Portal links page in adminX, allowing tier specific signup links to be copied
2023-07-07 16:30:59 +05:30
Peter Zimon
2642941be6
AdminX Portal links (#17227)
refs. https://github.com/TryGhost/Product/issues/3545

Static version of links page in AdminX Portal settings.
2023-07-07 11:36:31 +02:00
Rishabh Garg
31ff544e7a
Added account page in Portal preview in adminX (#17236)
refs https://github.com/TryGhost/Product/issues/3545

- adds switch to showing account page in portal preview
2023-07-07 14:47:17 +05:30
Fabien "egg" O'Carroll
2808df7f87 Switched to bookshelf repository 2023-07-07 14:24:42 +08:00
Jono M
4ffdab3c82
Added confirmation modal after setting portal email address (#17231)
refs https://github.com/TryGhost/Product/issues/3545
2023-07-07 02:05:14 +00:00
Jono M
e397368393
Improved Lexical behaviour in AdminX portal settings (#17232)
refs https://github.com/TryGhost/Product/issues/3545

- Fixed TODOs
- Fixed koenig editor not resizing as content expands
- Fixed placeholder in html field
- Updated signup options to validate terms length
2023-07-07 02:03:46 +00:00
Chris Raible
fc7e150cc2
Fixed importer breaking any posts written in the new editor (#17230)
refs @TryGhost/Product#3551

- PostsImporter would convert the HTML from the import file into
Mobiledoc, even if the post was written in Lexical
- As a result, the imported posts would have both mobiledoc & lexical
fields populated, which prevents the post from being updated in the
Lexical editor
- Added a check to see if the post was written in Lexical, and if so,
skip the HTML > Mobiledoc conversion
2023-07-06 18:37:19 -07:00
Rishabh
c6b8097ff9 Added portal preview frame in adminX
refs https://github.com/TryGhost/Product/issues/3545

- adds portal preview iframe in modal
- wires local settings to portal preview url to dynamically generate the Portal preview
2023-07-06 20:41:42 +05:30
Peter Zimon
4fff14fdac
Updated AdminX Portal button icons (#17223)
refs. https://github.com/TryGhost/Product/issues/3545

Portal button icons in AdminX styling was just placeholders.
2023-07-06 11:53:33 +00:00
Kevin Ansfield
22a7d1c374
Added animated icon for "hide title + feature image" toggle (#17220)
closes https://github.com/TryGhost/Product/issues/3577

- adds icon as a handlebars file to avoid SVGO breaking the styles needed for the toggle to work
2023-07-06 11:38:36 +00:00
Peter Zimon
c9f2271665
AdminX installed theme list updates (#17221)
refs. https://github.com/TryGhost/Product/issues/3349

The installed themes were not sorted and the active theme was not the
first one which made it hard to discover in the list.
2023-07-06 11:21:48 +00:00
Peter Zimon
a5b62707ef
AdminX theme navigation experiment (#17210)
refs. https://github.com/TryGhost/Product/issues/3349

It's a bit cumbersome how design and theme navigation is handled in
AdminX at the moment. On a high level, this PR applies the following
changes:

- Change theme is under Design settings
- After activating a theme, Design settings are automatically opened
2023-07-06 12:03:01 +02:00
Kevin Ansfield
a1d4b4cc9d
Wired up toggle for hiding page title and feature image (#17214)
closes https://github.com/TryGhost/Product/issues/3558
closes https://github.com/TryGhost/Product/issues/3559

- added property to post model
- updated post serializer to not send property when saving a post rather than a page
- added property toggle to post settings menu
- updated indicators next to title and feature image to show real property state
2023-07-06 08:51:19 +00:00
Michael Barrett
b49cf14287
🐛 Fixed member import newsletter subscription prefs (#17208)
fixes https://github.com/TryGhost/Product/issues/2947

When an import is performed and a member already exists:
- If `subscribe_to_emails` is set to `true` and the existing member
already has newsletter subscriptions, these are preserved
- If `subscribe_to_emails` is set to `true` and the existing member does
not already have newsletter subscriptions, no new subscriptions are
added in case the member has previously unsubscribed
- If `subscribe_to_emails` is set to `false` the existing member will be
unsubscribed from all newsletters regardless of their preference
2023-07-06 08:45:56 +01:00
Daniel Lockyer
f6aeff6524 Added handling for building arch branch
refs https://github.com/TryGhost/DevOps/issues/40

- this is an experimental branch that needs a separate canary build
- these changes should help support that by allowing canary builds on
  that branch
2023-07-06 09:24:45 +02:00
Daniel Lockyer
92120324eb Updated workflow for code coverage
- added separate Admin codecov step
- removed unit test until we figure out handling for partial runs
2023-07-06 09:24:45 +02:00
Jono M
e1fbfd3e12
Added HTML editor using koenig-lexical (#17217)
refs https://github.com/TryGhost/Product/issues/3545

Used in portal settings for the signup message.
2023-07-06 03:05:33 +00:00
Jono M
b9158215ee
Added portal icon picker in AdminX settings (#17216)
refs https://github.com/TryGhost/Product/issues/3545
2023-07-05 23:16:52 +00:00
Simon Backx
3d6848f5fd
Added Portal development --https option support for Safari (#17213)
no issue

This --https option allows to test Portal in Safari when the site is
hosted on https.
2023-07-05 15:04:39 +00:00
Kevin Ansfield
5d8ea79788
Implemented pages.hide_title_and_feature_image property in API (#17211)
closes https://github.com/TryGhost/Product/issues/3557

- bumped `@tryghost/admin-api-schema` to allow passthrough of the new property in API requests
- updated output mapper to ensure property always returns a boolean rather than `null` in the case where `posts_meta` doesn't exist for a page
- updated `PostsService.copyPost()` to include the new property when copying
- updated `checkResponse` test util and snapshots to expect `hide_title_and_feature_image` property in page API responses
- fixed pages e2e test so it doesn't inadvertently modify the match object breaking later tests
2023-07-05 14:01:24 +00:00
Kevin Ansfield
2a340bcab9
Added migration and schema change for posts_meta.hide_title_and_feature_image (#17187)
closes https://github.com/TryGhost/Team/issues/3550

We want to allow an option to hide the title and feature image on a
per-page basis, to do that we need somewhere to store the setting value.
The existing `posts_meta` table is the simplest candidate, especially as
this is a single setting and we don't have a desire to introduce many
such settings.

- added migration that adds the `hide_title_and_feature_image` column to
the `posts_meta` table with a `boolean` data type and a default value of
`false` (matches behaviour of all existing pages)
- updated schema file for initial database creation
- removed property from API output via serializers to keep migration PR
minimal
2023-07-05 14:48:25 +01:00
Naz
4372a7e1a8 Added feature flag for flatUrls
refs https://github.com/TryGhost/Arch/issues/24

- Enables generating Post and Page URLs in a flat `{slug}-{id}` format
2023-07-05 17:41:28 +08:00
Daniel Lockyer
289e459283 Added tests for migrations
refs https://github.com/TryGhost/DevOps/issues/39

- up until now, we've had a CI job which does a really basic test for
  migrations, but it barely functions and misses bugs all the time
- this commit removes that and switches to an actual test suite for our
  migrations, so we can ensure they function as expected
- also removes the env var hack I came up with for those migrations
  tests
- this should lead to safer migrations and faster tests
2023-07-05 11:00:06 +02:00
Daniel Lockyer
ebad10e242 Updated lockfile 2023-07-05 11:00:06 +02:00
Daniel Lockyer
2aa89f30c5 Moved dev script into subfolder
- we're going to start adding more scripts here so this helps keep the
  .github folder tidy
2023-07-05 11:00:06 +02:00
Daniel Lockyer
40e8bc09ce Optimized unit test workflow to only run for changed packages
- this implements a similar idea to linting by only running for changed
  packages, which saves ~3 minutes for this job
2023-07-05 11:00:06 +02:00
Rishabh
79a7f8c408 Added basic routing for adminX settings
refs https://github.com/TryGhost/Product/issues/3349

- adds basic routing in adminX settings based on hash url path
- adds new routing provider that manages hash routing across adminX
- updates sidebar navigation to update route directly
- updates theme/design settings to update route for opening edit modals
2023-07-04 20:56:55 +05:30
Rishabh
56fcba1d27 Updated global Modals to handle after close method
refs https://github.com/TryGhost/Product/issues/3349

- allows modals to call `afterClose` when removed in case the parent wants any action on modal close, like routing update
2023-07-04 20:56:55 +05:30
Markus Härnvi
9ac6001031
Updated Swedish translations for signup-form (#17164)
refs https://github.com/TryGhost/Team/issues/2795
2023-07-04 15:22:42 +00:00
Kasun Jayarathna
3c5bf215e5
Added missing Sinhalese translations (#17172)
refs https://github.com/TryGhost/Team/issues/2795
2023-07-04 15:16:22 +00:00
Ghost CI
d9480f9569 Merged v5.53.4 into main 2023-07-04 14:25:45 +00:00
Ghost CI
9305dca60e v5.53.4 2023-07-04 14:25:42 +00:00
Daniel Lockyer
7ef42a49fa Implemented Playwright caching into browser-tests workflow
- this allows us to use the Playwright cache that is in place to speed
  up tests
2023-07-04 16:08:06 +02:00
Daniel Lockyer
1aeac9777e Enabled parallel testing for Playwright tests of apps
- we should allow parallel test execution because it's faster than
  serial
2023-07-04 16:08:06 +02:00
Ronald Langeveld
579a9243b5 Bumped packages (#17196)
refs https://github.com/TryGhost/Team/issues/3544

- Bumps required packages to fix an issue on posts that still contains base64 images.

<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 5fb728e</samp>

Updated `@tryghost/helpers` dependency to fix some helper issues. This
improved the accuracy and security of the `{{reading_time}}` and
`{{encode}}` helpers in Ghost themes.
2023-07-04 16:06:29 +02:00
Peter Zimon
47a9eaadcc
AdminX Portal setting forms (#17201)
refs. https://github.com/TryGhost/Product/issues/3545

Styles was not applied to AdminX Portal settings forms. Also a couple of new components had to be added for easer future form design and implementation.
2023-07-04 15:18:19 +02:00
Albert Lacasta
80e65d4978
Updated Spanish translations (#17126)
refs https://github.com/TryGhost/Team/issues/2795
2023-07-04 12:54:54 +00:00