Commit Graph

12121 Commits

Author SHA1 Message Date
Daniel Lockyer
2bdb9c5d0a
Added fallback remote for grunt master
no issue

- our docs do not tell the user to set up an `upstream` remote for Casper, so
  running `grunt master` will fail as it expects `upstream` to exist
- this commit adds detection for if `upstream` exists, and falls back to
  `origin` if not
2021-01-14 12:28:55 +00:00
Naz
6d2dfff5b5 Refactored invites module into a class
refs #12537
2021-01-14 19:42:38 +13:00
Naz
01855389a5 Moved invites controller code into a service module
refs #12537

- Part of the controller code refactor into services to avoid code duplication during introduction of a new API.
2021-01-14 19:25:16 +13:00
Naz
2a6ae77221 Fixed linting error 2021-01-14 18:39:27 +13:00
Naz
1cec604318 Fixed update check tests
refs #12537

- Refactored overuse of rewire mocking blog-version.
- Fixed a bug introduced along the way when duplicate notifications errored instead of returning empty result
2021-01-14 18:30:09 +13:00
Naz
cc9d987e94 Fixed notifications api user for internal context
refs #12537

- Fix after a refactor introduced in 935ffdd0f6
2021-01-14 17:49:55 +13:00
Naz
935ffdd0f6 Refactored notifications module into a class
refs #12537

- Classes with DI friendly constructors are the pattern that are followed across the codebase
2021-01-14 16:19:15 +13:00
Naz
d2f0f0d7bc Moved notifications controller code into a service module
refs #12537

- notifications controllers were overbloated with non controller related code and were identical. It is important to reduce unnecessary code ahead of v4 API introduction
- Follow up commit will transform newly created module into a class following DI pattern
2021-01-14 15:55:55 +13:00
Naz
aff4a7055e Extracted members controller's import method
refs #12537

- Moved code related to the importer into the MembersImporter class to  keep the controller code light
2021-01-14 14:05:22 +13:00
Naz
105bc6cff3 Added jsdoc to MembersStats class
no issue
2021-01-14 12:59:17 +13:00
Renovate Bot
4e497fb9d1 Update dependency @tryghost/errors to v0.2.7 2021-01-13 18:06:31 +00:00
Renovate Bot
680133a888 Update dependency @tryghost/bootstrap-socket to v0.2.5 2021-01-13 18:06:23 +00:00
Renovate Bot
3ecc84c737 Update dependency @tryghost/social-urls to v0.1.18 2021-01-13 18:06:02 +00:00
Renovate Bot
fe888c7050
Update dependency ghost-ignition to v4.3.0 2021-01-13 16:02:06 +00:00
Renovate Bot
79b512df95 Update dependency @tryghost/job-manager to v0.7.1 2021-01-13 15:52:06 +00:00
Renovate Bot
1f2cebcc47 Update dependency @tryghost/html-to-mobiledoc to v0.7.9 2021-01-13 15:51:56 +00:00
Renovate Bot
e4adc5564a Update dependency @tryghost/mw-session-from-token to v0.1.14 2021-01-13 15:51:39 +00:00
Renovate Bot
01bf344b14 Update dependency @tryghost/security to v0.2.4 2021-01-13 15:51:08 +00:00
Renovate Bot
5d55a54090 Update dependency @tryghost/url-utils to v0.6.25 2021-01-13 15:50:52 +00:00
Renovate Bot
78afa4cf1f
Update dependency @sentry/node to v5.30.0 2021-01-13 12:06:39 +00:00
Naz
10304c79a4 Refactored members stats module into class
refs #12537

- Class syntax is preferred over module functions because of constructor parameter injection (DI) which allows for easier module decoupling and testing
2021-01-13 22:43:05 +13:00
Naz
e62c4075f0 Moved members stats code out of members controller
refs #12537

- `stats` method in members controller is quite big and does much more then controller method code should - few calls to relevant modules
- Extracted code "as is" into members serivce
- Next step will be to refactor this module as a class pattern with DI parameters
2021-01-13 22:43:05 +13:00
Daniel Lockyer
91633faf24
Updated Ghost-Admin submodule url
no issue

- the repository has been renamed, so this commit bring the URL in line
  with these changes
2021-01-13 09:38:00 +00:00
Renovate Bot
f92cb0f31c
Update dependency @tryghost/zip to v1.1.8 2021-01-12 23:09:37 +00:00
Renovate Bot
51a452bd27
Update dependency @tryghost/vhost-middleware to v1.0.11 2021-01-12 21:09:34 +00:00
Renovate Bot
5805e9d93a
Update dependency @tryghost/helpers to v1.1.37 2021-01-12 19:07:03 +00:00
Kevin Ansfield
63f7f9a827 🐛 Disabled auto-unsubscribe of members on permanent email failure events
refs https://github.com/TryGhost/Team/issues/446

Mailgun permanent failure events do not always correspond to unsubscribe-level events as originally thought, meaning some members could be unsubscribed unexpectedly due to delivery hiccups.

- disabled auto-unsubscribe on permanent failure events in the analytics event processor
- list maintenance will be added back in the future via alternative means
2021-01-12 18:40:31 +00:00
Renovate Bot
92de3f342a
Update dependency @tryghost/admin-api-schema to v1.4.3 2021-01-12 17:06:18 +00:00
Renovate Bot
c985a4f0c8
Update dependency @tryghost/kg-default-cards to v3.1.0 2021-01-12 13:06:22 +00:00
Renovate Bot
f1c78f6336
Update dependency @tryghost/kg-card-factory to v2.1.5 2021-01-12 11:23:04 +00:00
renovate[bot]
b07c278e92
Update dependency @tryghost/kg-markdown-html-renderer to v3 (#12521)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2021-01-12 11:21:37 +00:00
Renovate Bot
e4e62a6a7c Update dependency analytics-node to v3.5.0 2021-01-12 10:38:48 +00:00
Renovate Bot
8111cb2f49 Update dependency @tryghost/string to v0.1.15 2021-01-12 10:38:26 +00:00
Renovate Bot
5d1281fcfb Update dependency nconf to v0.11.1 2021-01-08 13:07:00 +00:00
Renovate Bot
bed13e22e5 Update dependency jwks-rsa to v1.12.2 2021-01-08 13:05:15 +00:00
Renovate Bot
7f7bdb9f4d Update dependency @tryghost/html-to-mobiledoc to v0.7.8 2021-01-08 13:04:24 +00:00
Renovate Bot
e71a50d2ad Update dependency @tryghost/social-urls to v0.1.17 2021-01-08 13:04:04 +00:00
Renovate Bot
12b31ec41b Update dependency @tryghost/url-utils to v0.6.24 2021-01-08 13:03:52 +00:00
Renovate Bot
d69b60c3b3 Update dependency @tryghost/adapter-manager to v0.2.6 2021-01-08 13:03:36 +00:00
Renovate Bot
924be50157
Update dependency @tryghost/helpers to v1.1.36 2021-01-07 13:07:41 +00:00
Renovate Bot
dc13ea0562
Update dependency @tryghost/admin-api-schema to v1.4.2 2021-01-07 11:05:56 +00:00
Daniel Lockyer
ea9900c957
v3.40.5 2021-01-07 08:46:16 +00:00
Daniel Lockyer
fef382346a
Updated Ghost-Admin to v3.40.5 2021-01-07 08:46:16 +00:00
Renovate Bot
9b46c89d93
Update dependency sinon to v9.2.3 2021-01-06 15:05:39 +00:00
Naz
b2e7d2bf06 Bumped job-manager version to 0.7.0
closes https://github.com/TryGhost/Ghost-Utils/issues/122
2021-01-06 17:48:05 +13:00
Daniel Lockyer
f28bef5c9e
v3.40.4 2021-01-05 16:46:32 +00:00
Daniel Lockyer
f721891148
Updated Ghost-Admin to v3.40.4 2021-01-05 16:46:31 +00:00
Kevin Ansfield
93fa9b4d9e Removed unnecessary bookshelf-relations config in EmailRecipient model
no issue

- we don't use any of the `bookshelf-relations` plugin's added features for the `EmailRecipient` model so there's no need to opt in to it
2021-01-05 15:28:30 +00:00
Kevin Ansfield
ab834b2615 Updated bookshelf-relations dependency to fix broken release
closes https://github.com/TryGhost/Ghost/issues/12493

- the published version of `bookshelf-relations` 1.4.0 was missing the critical commit that added the new relationship config feature
- v1.4.1 is a valid release
2021-01-05 15:24:45 +00:00
Kevin Ansfield
eccd220461 🐛 Fixed error when deleting a member that has received a newsletter email
closes https://github.com/TryGhost/Ghost/issues/12493

- bumps `bookshelf-relations` to new version that allows for `hasMany` children to be kept when a parent record is destroyed
- adds necessary config to the `Member.email_recipients` relationship to keep related records when a member is deleted
2021-01-05 14:06:20 +00:00