From d75aec1b7e2e7408912c3b25f0d50a5560d11221 Mon Sep 17 00:00:00 2001 From: squidfunk Date: Thu, 9 Feb 2017 19:01:23 +0100 Subject: [PATCH] Make tests run on Node.js 5 --- .travis.yml | 4 ++-- lib/tasks/tests/visual/run.js | 6 ++++-- tests/visual/config/gemini.sauce-connect.json | 15 +++++---------- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/.travis.yml b/.travis.yml index 74e028f6c..9a3fea314 100644 --- a/.travis.yml +++ b/.travis.yml @@ -27,10 +27,10 @@ node_js: - 6 - 7 -# Build visual tests on Node.js 7 +# Build visual tests separately matrix: include: - - node_js: 7 + - node_js: 5 addons: apt: sources: diff --git a/lib/tasks/tests/visual/run.js b/lib/tasks/tests/visual/run.js index 639c1d8be..c6a1061ce 100644 --- a/lib/tasks/tests/visual/run.js +++ b/lib/tasks/tests/visual/run.js @@ -85,9 +85,11 @@ export default (gulp, config, args) => { caps.public = "private" caps.name = id - /* Associate build with job when in CI */ - if (process.env.CI && process.env.TRAVIS) + /* Increase retries to omit flaky tests and make results public */ + if (process.env.CI && process.env.TRAVIS) { + gemini.browsers[key].retry = 3 caps.public = "public" + } } /* Start Gemini and return runner upon finish */ diff --git a/tests/visual/config/gemini.sauce-connect.json b/tests/visual/config/gemini.sauce-connect.json index 13b42a3e5..38912d952 100644 --- a/tests/visual/config/gemini.sauce-connect.json +++ b/tests/visual/config/gemini.sauce-connect.json @@ -9,8 +9,7 @@ "platform": "Windows 10", "screenResolution": "1280x1024", "recordVideo": "false" - }, - "retry": 3 + } }, "firefox": { "desiredCapabilities": { @@ -19,8 +18,7 @@ "platform": "Windows 10", "screenResolution": "1280x1024", "recordVideo": "false" - }, - "retry": 3 + } }, "edge": { "desiredCapabilities": { @@ -28,8 +26,7 @@ "platform": "Windows 10", "screenResolution": "1280x1024", "recordVideo": "false" - }, - "retry": 3 + } }, "ie11": { "desiredCapabilities": { @@ -38,8 +35,7 @@ "platform": "Windows 10", "screenResolution": "1280x1024", "recordVideo": "false" - }, - "retry": 3 + } }, "ie10": { "desiredCapabilities": { @@ -48,8 +44,7 @@ "platform": "Windows 8", "screenResolution": "1280x1024", "recordVideo": "false" - }, - "retry": 3 + } } }, "system": {