From 50e6328d1f1b5cd879adb5ee99eba0c387426510 Mon Sep 17 00:00:00 2001 From: squidfunk Date: Thu, 7 Sep 2017 14:19:29 +0200 Subject: [PATCH] Updated CONTRIBUTING.md --- CHANGELOG | 2 +- CONTRIBUTING.md | 13 ++++--- docs/contributing.md | 82 +--------------------------------------- docs/release-notes.md | 88 +++++++++++++++++++++---------------------- 4 files changed, 53 insertions(+), 132 deletions(-) mode change 100644 => 120000 docs/contributing.md diff --git a/CHANGELOG b/CHANGELOG index 9849d86df..7ea0bdcce 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -18,7 +18,7 @@ mkdocs-material-1.9.0 (2017-08-29) mkdocs-material-1.8.1 (2017-08-07) - * Fixed #429: Missing pagination for GitHub API + * Fixed #421: Missing pagination for GitHub API mkdocs-material-1.8.0 (2017-08-02) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8b4fc0dbc..b43ce4b36 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,7 +10,7 @@ you do, please read the following guidelines. For quick questions there's no need to open an issue as you can reach us on [gitter.im][1]. - [1]: https://gitter.im/mkdocs-material/general + [1]: https://gitter.im/squidfunk/mkdocs-material ### Found a bug? @@ -30,12 +30,12 @@ proposal for your work first, to be sure that it is of use for everyone, as the Material theme is highly opinionated. Please consider what kind of change it is: -* For a **Major Feature**, first open an issue and outline your proposal so +* For a **major feature**, first open an issue and outline your proposal so that it can be discussed. This will also allow us to better coordinate our efforts, prevent duplication of work, and help you to craft the change so that it is successfully accepted into the project. -* **Small Features** and bugs can be crafted and directly submitted as a Pull +* **Small features and bugs** can be crafted and directly submitted as a Pull Request. However, there is no guarantee that your feature will make it into the master, as it's always a matter of opinion whether if benefits the overall functionality of the theme. @@ -66,8 +66,8 @@ go ahead. make your changes in a separate git branch and add descriptive messages to your commits. -2. **Build**: Before submitting a pull requests, build the theme. This is a - mandatory requirement for your PR to get accepted, as the theme should at +2. **Build**: Before submitting a pull requests, [build the theme][5]. This is + a mandatory requirement for your PR to get accepted, as the theme should at all times be installable through GitHub. 3. **Pull Request**: After building the theme, commit the compiled output, push @@ -78,4 +78,5 @@ go ahead. After your PR is merged, you can safely delete your branch and pull the changes from the main (upstream) repository. - [4]: http://squidfunk.github.io/mkdocs-material/customization/#theme-development + [4]: http://squidfunk.github.io/mkdocs-material/customization/#environment-setup + [5]: http://squidfunk.github.io/mkdocs-material/customization/#build-process diff --git a/docs/contributing.md b/docs/contributing.md deleted file mode 100644 index 9f73471e2..000000000 --- a/docs/contributing.md +++ /dev/null @@ -1,81 +0,0 @@ -# Contributing - -Interested in contributing to the Material theme? Want to report a bug? Before -you do, please read the following guidelines. - -## Submission context - -### Got a question or problem? - -For quick questions there's no need to open an issue as you can reach us on -[gitter.im][1]. - - [1]: https://gitter.im/squidfunk/mkdocs-material - -### Found a bug? - -If you found a bug in the source code, you can help us by submitting an issue -to the [issue tracker][2] in our GitHub repository. Even better, you can submit -a Pull Request with a fix. However, before doing so, please read the -[submission guidelines][3]. - - [2]: https://github.com/squidfunk/mkdocs-material/issues - [3]: #submission-guidelines - -### Missing a feature? - -You can request a new feature by submitting an issue to our GitHub Repository. -If you would like to implement a new feature, please submit an issue with a -proposal for your work first, to be sure that it is of use for everyone, as -the Material theme is highly opinionated. Please consider what kind of change -it is: - -* For a **major feature**, first open an issue and outline your proposal so - that it can be discussed. This will also allow us to better coordinate our - efforts, prevent duplication of work, and help you to craft the change so - that it is successfully accepted into the project. - -* **Small features and bugs** can be crafted and directly submitted as a Pull - Request. However, there is no guarantee that your feature will make it into - the master, as it's always a matter of opinion whether if benefits the - overall functionality of the theme. - -## Submission guidelines - -### Submitting an issue - -Before you submit an issue, please search the issue tracker, maybe an issue for -your problem already exists and the discussion might inform you of workarounds -readily available. - -We want to fix all the issues as soon as possible, but before fixing a bug we -need to reproduce and confirm it. In order to reproduce bugs we will -systematically ask you to provide a minimal reproduction scenario using the -custom issue template. Please stick to the issue template. - -Unfortunately we are not able to investigate / fix bugs without a minimal -reproduction scenario, so if we don't hear back from you we may close the issue. - -### Submitting a Pull Request (PR) - -Search GitHub for an open or closed PR that relates to your submission. You -don't want to duplicate effort. If you do not find a related issue or PR, -go ahead. - -1. **Development**: Fork the project, set up the [development environment][4], - make your changes in a separate git branch and add descriptive messages to - your commits. - -2. **Build**: Before submitting a pull requests, build the theme. This is a - mandatory requirement for your PR to get accepted, as the theme should at - all times be installable through GitHub. - -3. **Pull Request**: After building the theme, commit the compiled output, push - your branch to GitHub and send a PR to `mkdocs-material:master`. If we - suggest changes, make the required updates, rebase your branch and push the - changes to your GitHub repository, which will automatically update your PR. - -After your PR is merged, you can safely delete your branch and pull the changes -from the main (upstream) repository. - - [4]: http://squidfunk.github.io/mkdocs-material/customization/#theme-development diff --git a/docs/contributing.md b/docs/contributing.md new file mode 120000 index 000000000..44fcc6343 --- /dev/null +++ b/docs/contributing.md @@ -0,0 +1 @@ +../CONTRIBUTING.md \ No newline at end of file diff --git a/docs/release-notes.md b/docs/release-notes.md index c03191d28..2b762e187 100644 --- a/docs/release-notes.md +++ b/docs/release-notes.md @@ -17,7 +17,7 @@ pip show mkdocs-material | grep -E ^Version ## Changelog -### 1.10.0 _ September 1, 2017 +### 1.10.0 _ September 1, 2017 * Added support to make logo default icon configurable * Fixed uninitialized overflow scrolling on main pane for iOS @@ -25,7 +25,7 @@ pip show mkdocs-material | grep -E ^Version * Fixed incorrect color transition for nested panes in mobile navigation * Improved checkbox styles for Tasklist from PyMdown Extension package -### 1.9.0 _ August 29, 2017 +### 1.9.0 _ August 29, 2017 * Added `info` (synonym: `todo`) style for Admonition * Added `question` (synonym: `help`, `faq`) style for Admonition @@ -35,13 +35,13 @@ pip show mkdocs-material | grep -E ^Version * Replaced ligatures with Unicode code points to avoid broken layout * Upgraded PyMdown Extensions package dependency to >= 3.4 -### 1.8.1 _ August 7, 2017 +### 1.8.1 _ August 7, 2017 -* Fixed [#429][429]: Missing pagination for GitHub API +* Fixed [#421][421]: Missing pagination for GitHub API - [429]: https://github.com/squidfunk/mkdocs-material/issues/429 + [421]: https://github.com/squidfunk/mkdocs-material/issues/421 -### 1.8.0 _ August 2, 2017 +### 1.8.0 _ August 2, 2017 * Added support for lazy-loading of search results for better performance * Added support for customization of search tokenizer/separator @@ -51,7 +51,7 @@ pip show mkdocs-material | grep -E ^Version [419]: https://github.com/squidfunk/mkdocs-material/issues/419 [424]: https://github.com/squidfunk/mkdocs-material/issues/424 -### 1.7.5 _ July 25, 2017 +### 1.7.5 _ July 25, 2017 * Fixed [#398][398]: Forms broken due to search shortcuts * Improved search overall user experience @@ -60,46 +60,46 @@ pip show mkdocs-material | grep -E ^Version [398]: https://github.com/squidfunk/mkdocs-material/issues/398 -### 1.7.4 _ June 21, 2017 +### 1.7.4 _ June 21, 2017 * Fixed functional link colors in table of contents for active palette * Fixed [#368][368]: Compatibility issues with IE11 [368]: https://github.com/squidfunk/mkdocs-material/issues/368 -### 1.7.3 _ June 7, 2017 +### 1.7.3 _ June 7, 2017 * Fixed error when setting language to Japanese for site search -### 1.7.2 _ June 6, 2017 +### 1.7.2 _ June 6, 2017 * Fixed offset of search box when `repo_url` is not set * Fixed non-disappearing tooltip -### 1.7.1 _ June 1, 2017 +### 1.7.1 _ June 1, 2017 * Fixed wrong `z-index` order of header, overlay and drawer * Fixed wrong offset of targeted footnote back references -### 1.7.0 _ June 1, 2017 +### 1.7.0 _ June 1, 2017 * Added "copy to clipboard" buttons to code blocks * Added support for multilingual site search * Fixed search term highlighting for non-latin languages -### 1.6.4 _ May 24, 2017 +### 1.6.4 _ May 24, 2017 * Fixed [#337][337]: JavaScript error for GitHub organization URLs [337]: https://github.com/squidfunk/mkdocs-material/issues/337 -### 1.6.3 _ May 16, 2017 +### 1.6.3 _ May 16, 2017 * Fixed [#329][329]: Broken source stats for private or unknown GitHub repos [329]: https://github.com/squidfunk/mkdocs-material/issues/329 -### 1.6.2 _ May 15, 2017 +### 1.6.2 _ May 15, 2017 * Fixed [#316][316]: Fatal error for git clone on Windows * Fixed [#320][320]: Chrome 58 creates double underline for `abbr` tags @@ -111,12 +111,12 @@ pip show mkdocs-material | grep -E ^Version [320]: https://github.com/squidfunk/mkdocs-material/issues/320 [323]: https://github.com/squidfunk/mkdocs-material/issues/323 -### 1.6.1 _ April 23, 2017 +### 1.6.1 _ April 23, 2017 * Fixed following of active/focused element if search input is focused * Fixed layer order of search component elements -### 1.6.0 _ April 22, 2017 +### 1.6.0 _ April 22, 2017 * Added build test for Docker image on Travis * Added search overlay for better user experience (focus) @@ -127,19 +127,19 @@ pip show mkdocs-material | grep -E ^Version [270]: https://github.com/squidfunk/mkdocs-material/issues/270 -### 1.5.5 _ April 20, 2017 +### 1.5.5 _ April 20, 2017 * Fixed [#282][282]: Browser search (Meta+F) is hijacked [282]: https://github.com/squidfunk/mkdocs-material/issues/282 -### 1.5.4 _ April 8, 2017 +### 1.5.4 _ April 8, 2017 * Fixed broken highlighting for two or more search terms * Fixed missing search results when only a `h1` is present * Fixed unresponsive overlay on Android -### 1.5.3 _ April 7, 2017 +### 1.5.3 _ April 7, 2017 * Fixed deprecated calls for template variables * Fixed wrong palette color for focused search result @@ -147,19 +147,19 @@ pip show mkdocs-material | grep -E ^Version * Fixed missing top spacing on 404 page * Fixed missing right spacing on overflow of source container -### 1.5.2 _ April 5, 2017 +### 1.5.2 _ April 5, 2017 * Added requirements as explicit dependencies in `setup.py` * Fixed non-synchronized transitions in search form -### 1.5.1 _ March 30, 2017 +### 1.5.1 _ March 30, 2017 * Fixed rendering and offset of targetted footnotes * Fixed [#238][238]: Link on logo is not set to `site_url` [238]: https://github.com/squidfunk/mkdocs-material/issues/238 -### 1.5.0 _ March 24, 2017 +### 1.5.0 _ March 24, 2017 * Added support for localization of search placeholder * Added keyboard events for quick access of search @@ -175,11 +175,11 @@ pip show mkdocs-material | grep -E ^Version [229]: https://github.com/squidfunk/mkdocs-material/issues/229 [231]: https://github.com/squidfunk/mkdocs-material/issues/231 -### 1.4.1 _ March 16, 2017 +### 1.4.1 _ March 16, 2017 * Fixed invalid destructuring attempt on NodeList (in Safari, Edge, IE) -### 1.4.0 _ March 16, 2017 +### 1.4.0 _ March 16, 2017 * Added support for grouping searched sections by documents * Added support for highlighting of search terms @@ -189,7 +189,7 @@ pip show mkdocs-material | grep -E ^Version [216]: https://github.com/squidfunk/mkdocs-material/issues/216 -### 1.3.0 _ March 11, 2017 +### 1.3.0 _ March 11, 2017 * Added support for page-specific title and description using metadata * Added support for linking source files to documentation @@ -205,7 +205,7 @@ pip show mkdocs-material | grep -E ^Version [205]: https://github.com/squidfunk/mkdocs-material/issues/205 -### 1.2.0 _ March 3, 2017 +### 1.2.0 _ March 3, 2017 * Added `quote` (synonym: `cite`) style for Admonition * Added help message to build pipeline @@ -215,11 +215,11 @@ pip show mkdocs-material | grep -E ^Version [197]: https://github.com/squidfunk/mkdocs-material/issues/197 -### 1.1.1 _ February 26, 2017 +### 1.1.1 _ February 26, 2017 * Fixed incorrectly displayed nested lists when using tabs -### 1.1.0 _ February 26, 2017 +### 1.1.0 _ February 26, 2017 * Added tabs navigation feature (optional) * Added Disqus integration (optional) @@ -237,7 +237,7 @@ pip show mkdocs-material | grep -E ^Version [173]: https://github.com/squidfunk/mkdocs-material/issues/173 [175]: https://github.com/squidfunk/mkdocs-material/issues/175 -### 1.0.5 _ February 18, 2017 +### 1.0.5 _ February 18, 2017 * Fixed [#153][153]: Sidebar flows out of constrained area in Chrome 56 * Fixed [#159][159]: Footer jitter due to JavaScript if content is short @@ -245,7 +245,7 @@ pip show mkdocs-material | grep -E ^Version [153]: https://github.com/squidfunk/mkdocs-material/issues/153 [159]: https://github.com/squidfunk/mkdocs-material/issues/159 -### 1.0.4 _ February 16, 2017 +### 1.0.4 _ February 16, 2017 * Fixed [#142][142]: Documentation build errors if `h1` is defined as raw HTML * Fixed [#164][164]: PyPI release does not build and install @@ -255,7 +255,7 @@ pip show mkdocs-material | grep -E ^Version [142]: https://github.com/squidfunk/mkdocs-material/issues/142 [164]: https://github.com/squidfunk/mkdocs-material/issues/164 -### 1.0.3 _ January 22, 2017 +### 1.0.3 _ January 22, 2017 * Fixed [#117][117]: Table of contents items don't blur on fast scrolling * Refactored sidebar positioning logic @@ -263,20 +263,20 @@ pip show mkdocs-material | grep -E ^Version [117]: https://github.com/squidfunk/mkdocs-material/issues/117 -### 1.0.2 _ January 15, 2017 +### 1.0.2 _ January 15, 2017 * Fixed [#108][108]: Horizontal scrollbar in content area [108]: https://github.com/squidfunk/mkdocs-material/issues/108 -### 1.0.1 _ January 14, 2017 +### 1.0.1 _ January 14, 2017 * Fixed massive repaints happening when scrolling * Fixed footer back reference positions in case of overflow * Fixed header logo from showing when the menu icon is rendered * Changed scrollbar behavior to only show when content overflows -### 1.0.0 _ January 13, 2017 +### 1.0.0 _ January 13, 2017 * Introduced Webpack for more sophisticated JavaScript bundling * Introduced ESLint and Stylelint for code style checks @@ -305,7 +305,7 @@ pip show mkdocs-material | grep -E ^Version * Fixed live reload chain in watch mode when saving a template * Fixed variable references to work with MkDocs 0.16 -### 0.2.4 _ June 26, 2016 +### 0.2.4 _ June 26, 2016 * Fixed improperly set default favicon * Fixed [#33][33]: Protocol relative URL for webfonts doesn't work with @@ -317,7 +317,7 @@ pip show mkdocs-material | grep -E ^Version [34]: https://github.com/squidfunk/mkdocs-material/issues/26 [35]: https://github.com/squidfunk/mkdocs-material/issues/30 -### 0.2.3 _ May 16, 2016 +### 0.2.3 _ May 16, 2016 * Fixed [#25][25]: Highlight inline fenced blocks * Fixed [#26][26]: Better highlighting for keystrokes @@ -327,7 +327,7 @@ pip show mkdocs-material | grep -E ^Version [26]: https://github.com/squidfunk/mkdocs-material/issues/26 [30]: https://github.com/squidfunk/mkdocs-material/issues/30 -### 0.2.2 _ March 20, 2016 +### 0.2.2 _ March 20, 2016 * Fixed [#15][15]: Document Pygments dependency for CodeHilite * Fixed [#16][16]: Favicon could not be set through `mkdocs.yml` @@ -339,7 +339,7 @@ pip show mkdocs-material | grep -E ^Version [17]: https://github.com/squidfunk/mkdocs-material/issues/17 [20]: https://github.com/squidfunk/mkdocs-material/issues/20 -### 0.2.1 _ March 12, 2016 +### 0.2.1 _ March 12, 2016 * Fixed [#10][10]: Invisible header after closing search bar with ESC key @@ -351,7 +351,7 @@ pip show mkdocs-material | grep -E ^Version [10]: https://github.com/squidfunk/mkdocs-material/issues/10 [13]: https://github.com/squidfunk/mkdocs-material/issues/13 -### 0.2.0 _ February 24, 2016 +### 0.2.0 _ February 24, 2016 * Fixed [#6][6]: Include multiple color palettes via `mkdocs.yml` * Fixed [#7][7]: Better colors for links inside admonition notes and warnings @@ -362,7 +362,7 @@ pip show mkdocs-material | grep -E ^Version [7]: https://github.com/squidfunk/mkdocs-material/issues/7 [9]: https://github.com/squidfunk/mkdocs-material/issues/9 -### 0.1.3 _ February 21, 2016 +### 0.1.3 _ February 21, 2016 * Fixed [#3][3]: Ordered lists within an unordered list have `::before` content * Fixed [#4][4]: Click on Logo/Title without Github-Repository: `"None"` @@ -373,7 +373,7 @@ pip show mkdocs-material | grep -E ^Version [4]: https://github.com/squidfunk/mkdocs-material/issues/4 [5]: https://github.com/squidfunk/mkdocs-material/issues/5 -### 0.1.2 _ February 16, 2016 +### 0.1.2 _ February 16, 2016 * Fixed styles for deep navigational hierarchies * Fixed webfont delivery problem when hosted in subdirectories @@ -383,7 +383,7 @@ pip show mkdocs-material | grep -E ^Version * Set download link to latest version if available * Set up tracking of outgoing links and actions for Google Analytics -### 0.1.1 _ February 11, 2016 +### 0.1.1 _ February 11, 2016 * Fixed [#1][1]: GitHub stars don't work if the repo_url ends with a `/` * Updated NPM and Bower dependencies to most recent versions @@ -394,6 +394,6 @@ pip show mkdocs-material | grep -E ^Version [1]: https://github.com/squidfunk/mkdocs-material/issues/1 [2]: https://travis-ci.org -### 0.1.0 _ February 9, 2016 +### 0.1.0 _ February 9, 2016 * Initial release