mkdocs-material/docs/contributing/requesting-a-change.md

250 lines
11 KiB
Markdown
Raw Normal View History

# Requesting a change
2023-04-04 15:58:40 +03:00
Material for MkDocs is a powerful tool for creating beautiful and functional
project documentation. With more than 20,000 users, we understand that our
project serves a wide range of use cases, which is why we have created the
following guide.
---
Put yourself in our shoes with a project of this size, it can be challenging
to maintain existing functionality while constantly adding new features at the
same time. We highly value every idea or contribution from our community, and
we kindly ask you to take the time to read the following guidelines before
submitting your change request in our public [issue tracker]. This will help us
2023-04-04 15:58:40 +03:00
better understand the proposed change and how it will benefit the community.
This guide is our best effort to explain the criteria and reasoning behind our
decisions when evaluating change requests and considering them for
implementation.
[issue tracker]: https://github.com/squidfunk/mkdocs-material/issues
## Before creating an issue
2023-04-04 15:58:40 +03:00
Before you invest your time in filling out and submit a change request, we kindly
ask you to do some preliminary work by answering some questions to determine if
your idea is a good fit for Material for MkDocs and matches the project's
[philosophy] and tone.
__Please find answers to the following questions before creating an issue.__
[philosophy]: ../philosophy.md
### It's not a bug, it's a feature
2023-04-04 15:58:40 +03:00
Change requests are intended to suggest minor adjustments, ideas for new
features, or to influence the project's direction and vision. It is important
to note that change requests are not intended for reporting bugs, as they're
missing essential information for debugging.
If you want to report a bug, please refer to our [bug reporting guide] instead.
[bug reporting guide]: reporting-a-bug.md
### Source of inspiration
If you have seen your idea implemented in another static site generator or
theme, make sure to collect enough information on its implementation before
submitting, as this allows us to evaluate potential fit more quickly. Explain
what you like and dislike about the implementation.
### Benefit for the community
Our [discussion board] is the best place to connect with our community. When
evaluating new ideas, it's essential to seek input from other users and consider
alternative viewpoints. This approach helps to implement new features in a way
that benefits a large number of users.
[:octicons-comment-discussion-16:  Start a discussion][Start a discussion]{ .md-button .md-button--primary }
[Start a discussion]: https://github.com/squidfunk/mkdocs-material/discussions
## Issue template
Now that you have taken the time to do the necessary preliminary work and ensure
that your idea meets our requirements, you are invited to create a change
2023-04-04 15:58:40 +03:00
request. The following guide will walk you through all the necessary steps to
help you submit a comprehensive and useful issue:
- [Title]
- [Context] <small>optional</small>
- [Description]
- [Related links]
- [Use cases]
- [Visuals] <small>optional</small>
- [Checklist]
[Title]: #title
[Context]: #context
[Description]: #description
[Related links]: #related-links
[Use cases]: #use-cases
[Visuals]: #visuals
[Checklist]: #checklist
### Title
A good title is short and descriptive. It should be a one-sentence executive
summary of the idea, so the potential impact and benefit for the community can
be inferred from the title.
| <!-- --> | Example |
| -------- | -------- |
| :material-check:{ style="color: #4DB6AC" } __Clear__ | Index custom front matter in search
| :material-close:{ style="color: #EF5350" } __Wordy__ | Add a feature where authors can define custom front matter to be indexed in search
| :material-close:{ style="color: #EF5350" } __Unclear__ | Improve search
| :material-close:{ style="color: #EF5350" } __Generic__ | Please help
### Context <small>optional</small> { #context }
Before describing your idea, you can provide additional context for us to
understand what you are trying to achieve. Explain the circumstances
in which you're using Material for MkDocs, and what you _think_ might be
relevant. Don't write about the change request here.
> __Why this might be helpful__: some ideas might only benefit specific
2023-04-04 15:58:40 +03:00
> settings, environments, or edge cases, for example, when your documentation
> contains thousands of documents. With a little context, change requests
> can be prioritized more accurately.
### Description
Next, provide a detailed and clear description of your idea. Explain why your
2023-04-04 15:58:40 +03:00
idea is relevant to Material for MkDocs and must be implemented here and not
in one of its dependencies:
- __Explain the <u>what</u>, not the <u>why</u>__ don't explain
[the benefits of your idea][Use cases] here, we're getting there.
Focus on describing the proposed change request as precisely as possible.
- __Keep it short and concise__ be brief and to the point when describing
your idea, there is no need to over-describe it. Maintainers and future
users will be grateful for having to read less.
- __One idea at a time__ if you have multiple ideas that don't belong
2023-04-04 15:58:40 +03:00
together, please open separate change requests for each of those ideas.
---
:material-run-fast: __Stretch goal__ if you have a customization or another
way to add the proposed change, you can help other users by sharing it here
2023-04-04 15:58:40 +03:00
before we maintainers can add it to our code base.
> __Why we need this__: To understand and evaluate your proposed change, we
> need to have a clear understanding of your idea. By providing a detailed and
> precise description, you can help save you and us time spent discussing
> further clarification of your idea in the comments.
### Related links
Please provide any relevant links to issues, discussions, or documentation
sections related to your change request. If you (or someone else) already
discussed this idea with the community on our discussion board, please include
the link to the discussion as well.
> __Why we need this__: Related links help us gain a comprehensive
> understanding of your change request by providing additional context.
> Additionally, linking to previous issues and discussions allows us
> to quickly evaluate the feedback and input already provided by the community.
### Use cases
Explain how your change request would work from an author's and user's
2023-04-04 15:58:40 +03:00
perspective what's the expected impact, and why does it not only benefit you,
but other users? How many of them? Furthermore, would it potentially break
existing functionality?
> __Why we need this__: Understanding the use cases and benefits of an idea is
> crucial in evaluating its potential impact and usefulness for the project and
> its users. This information helps us to understand the expected value of the
> idea and how it aligns with the goals of the project.
### Visuals <small>optional</small> { #visuals }
We now have a clear and detailed description of your idea, including information
on its potential use cases and relevant links for context. If you have any
visuals, such as sketches, screenshots, mockups, or external assets, you may
present them in this section.
__You can drag and drop the files here or include links to external assets.__
Additionally, if you have seen this change, feature, or improvement used in
other static site generators or themes, please provide an example by showcasing
it and describing how it was implemented and incorporated.
> __Why we need this__: Illustrations and visuals can help us maintainers
> better understand and envision your idea. Screenshots, sketches, or mockups
> can create an additional level of detail and clarity that text alone may not
> be able to convey. Also, seeing how your idea has been implemented in other
> projects can help us understand its potential impact and feasibility in
> Material for MkDocs, which helps us maintainers evaluate and triage
> change requests.
### Checklist
Thanks for following the change request guide and creating a high-quality
2023-04-04 15:58:40 +03:00
change request. The checklist ensures that you have read this guide and have
worked to your best knowledge to provide us with every piece of information to
review your idea for Material for MkDocs.
__We'll take it from here.__
2023-04-04 15:58:40 +03:00
---
## Your change request was rejected?
We're sorry that your change request didn't make the cut. We understand it can
be frustrating when your ideas don't get accepted. We want you to know that as
project maintainers, we have to weigh the community's needs as a whole, and
sometimes that means making tough decisions. We always try to consider many
factors when evaluating change requests, and we'll explain the reasoning behind
our decisions whenever we can. If you're unsure why your request was turned
down, please ask for clarification.
### Common reasons
To provide you with some insight as to why your idea may have been rejected,
it's possible that it didn't align with the project's goals and direction or
the available resources. Here are a few common reasons for rejections:
> __Your idea may not...__
> - match the overall tone or vision of this project
> - be compatible with existing features, themes, or plugins
> - be useful to the majority of users
> - be user-friendly for authors
> - be implemented in an accessible way
> - be implemented with reasonable effort
> - be implemented using the [principle of progressive enhancement]
> - be implemented to work on all screen sizes
> - be implemented to work on all modern browsers
We highly value and appreciate every idea and contribution you bring to the
table, and we encourage you to keep sharing them with us. Some of these ideas
might even be implemented by us! However, we want to remind you that you also
have the power to implement your ideas on your own by customizing the theme. If
you're unsure about how to realize your ideas or want to know if someone has
already found a solution, feel free to visit our [discussion board] - it's the
perfect place for you!
[discussion board]: https://github.com/squidfunk/mkdocs-material/discussions
[principle of progressive enhancement]: https://developer.mozilla.org/en-US/docs/Glossary/Progressive_Enhancement?retiredLocale=de
### Dependencies
Occasionally, users propose ideas on our [issue tracker] that concern one of our
upstream [dependencies], such as [MkDocs], [Python Markdown],
[Python Markdown Extensions] or third-party plugins. In such cases, it's
worthwhile to consider whether your idea could benefit other themes as well. If
so, you might want to consider submitting a change request upstream to have a
greater impact.
[dependencies]: https://squidfunk.github.io/mkdocs-material/setup/dependencies/image-processing/
[MkDocs]: https://www.mkdocs.org
[Python Markdown]: https://python-markdown.github.io/extensions/
[Python Markdown Extensions]: https://facelessuser.github.io/pymdown-extensions/
[theme.name]: https://www.mkdocs.org/user-guide/configuration/#theme
[dependencies]: #dependencies