Ghost/apps/admin-x-settings
Simon Backx fee402a340
🐛 Fixed adding recommendation with URL redirect breaking one-click-subscribe (#18863)
fixes https://github.com/TryGhost/Product/issues/4102

E.g. you recommend myghostsite.com, while that site redirects all
traffic to [www.myghostsite.com](#):

The redirect causes CORS issues, which means we cannot detect
one-click-subscribe support.
- This is fixed by moving the whole detection to the backend, which has
the additional benefit that we can update it in the background without
the frontend, and update it on every recommendation change.
- This change also fixes existing recommendations by doing a check on
boot (we can move this to a background job in the future).
2023-11-03 15:02:45 +01:00
..
.storybook
src 🐛 Fixed adding recommendation with URL redirect breaking one-click-subscribe (#18863) 2023-11-03 15:02:45 +01:00
test 🐛 Fixed adding recommendation with URL redirect breaking one-click-subscribe (#18863) 2023-11-03 15:02:45 +01:00
.eslintrc.cjs
.yarnrc
index.html
node-shim.cjs
package.json Update dependency @vitejs/plugin-react to v4.1.1 2023-11-02 09:51:00 +01:00
playwright.config.ts
postcss.config.cjs
README.md Updated Admin-X settings readme (#18721) 2023-10-23 10:22:03 +07:00
tailwind.config.cjs AdminX Settings UX improvements (#18741) 2023-10-25 16:37:58 +02:00
tsconfig.json
tsconfig.node.json
vite.config.ts

Admin X Settings

Ghost Admin Settings in React

Development

Pre-requisites

  • Run yarn in Ghost monorepo root

Running the development version

Run yarn dev to start the development server to test/develop the settings standalone. This will generate a demo site from the index.html file which renders the app and makes it available on http://localhost:5173

Running inside Admin

Run yarn dev (like you would run Ghost dev normally) from the top-level repo. AdminX will automatically rebuild when you make changes.

Develop

This is a monorepo package.

Follow the instructions for the top-level repo.

  1. git clone this repo & cd into it as usual
  2. Run yarn to install top-level dependencies.

Test

  • yarn lint run just eslint
  • yarn test:acceptance runs acceptance tests
  • yarn test:unit runs unit tests
  • yarn test:acceptance path/to/test runs a specific test
  • yarn test:acceptance:slowmo runs acceptance tests in slow motion and headed mode, useful for debugging and developing tests