eb203de714
refs #4453 * On by default * Added config to disable resizing * Added basic image optimization processing * Added dep: sharp (optional dep) * Added resize middleware * Take care of rotation based on EXIF information * Removed all meta data from optimised image * Added handling if sharp could not get installed * Do not read ext twice - optimisation * Do not call sharp if config is disabled * Do not remove the original image which was uploaded (store 2 images) * Support of `req.files` for internal logic * Disabled cache to enable file removal on Windows
98 lines
3.7 KiB
JavaScript
98 lines
3.7 KiB
JavaScript
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const common = require('../../../../server/lib/common');
|
|
const manipulator = require('../../../../server/lib/image/manipulator');
|
|
const testUtils = require('../../../utils');
|
|
const sandbox = sinon.sandbox.create();
|
|
|
|
describe('lib/image: manipulator', function () {
|
|
afterEach(function () {
|
|
sandbox.restore();
|
|
testUtils.unmockNotExistingModule();
|
|
});
|
|
|
|
describe('cases', function () {
|
|
let sharp, sharpInstance;
|
|
|
|
beforeEach(function () {
|
|
sharpInstance = {
|
|
metadata: sandbox.stub(),
|
|
resize: sandbox.stub(),
|
|
rotate: sandbox.stub(),
|
|
toFile: sandbox.stub()
|
|
};
|
|
|
|
sharp = sandbox.stub().callsFake(() => {
|
|
return sharpInstance;
|
|
});
|
|
|
|
sharp.cache = sandbox.stub();
|
|
testUtils.mockNotExistingModule('sharp', sharp);
|
|
});
|
|
|
|
it('resize image', function () {
|
|
sharpInstance.metadata.resolves({width: 2000, height: 2000});
|
|
sharpInstance.toFile.resolves();
|
|
|
|
return manipulator.process({width: 1000})
|
|
.then(() => {
|
|
sharp.cache.calledOnce.should.be.true();
|
|
sharpInstance.metadata.calledOnce.should.be.true();
|
|
sharpInstance.toFile.calledOnce.should.be.true();
|
|
sharpInstance.resize.calledOnce.should.be.true();
|
|
sharpInstance.rotate.calledOnce.should.be.true();
|
|
});
|
|
});
|
|
|
|
it('skip resizing if image is too small', function () {
|
|
sharpInstance.metadata.resolves({width: 50, height: 50});
|
|
sharpInstance.toFile.resolves();
|
|
|
|
return manipulator.process({width: 1000})
|
|
.then(() => {
|
|
sharp.cache.calledOnce.should.be.true();
|
|
sharpInstance.metadata.calledOnce.should.be.true();
|
|
sharpInstance.toFile.calledOnce.should.be.true();
|
|
sharpInstance.resize.calledOnce.should.be.false();
|
|
sharpInstance.rotate.calledOnce.should.be.true();
|
|
});
|
|
});
|
|
|
|
it('sharp throws error during processing', function () {
|
|
sharpInstance.metadata.resolves({width: 500, height: 500});
|
|
sharpInstance.toFile.rejects(new Error('whoops'));
|
|
|
|
return manipulator.process({width: 2000})
|
|
.then(() => {
|
|
'1'.should.eql(1, 'Expected to fail');
|
|
})
|
|
.catch((err) => {
|
|
(err instanceof common.errors.InternalServerError).should.be.true;
|
|
err.code.should.eql('IMAGE_PROCESSING');
|
|
sharp.cache.calledOnce.should.be.true;
|
|
sharpInstance.metadata.calledOnce.should.be.true();
|
|
sharpInstance.toFile.calledOnce.should.be.true();
|
|
sharpInstance.resize.calledOnce.should.be.false();
|
|
sharpInstance.rotate.calledOnce.should.be.true();
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('installation', function () {
|
|
beforeEach(function () {
|
|
testUtils.mockNotExistingModule('sharp', new Error(), true);
|
|
});
|
|
|
|
it('sharp was not installed', function () {
|
|
return manipulator.process()
|
|
.then(() => {
|
|
'1'.should.eql(1, 'Expected to fail');
|
|
})
|
|
.catch((err) => {
|
|
(err instanceof common.errors.InternalServerError).should.be.true();
|
|
err.code.should.eql('SHARP_INSTALLATION');
|
|
});
|
|
});
|
|
});
|
|
});
|