b29852b012
closes: https://github.com/TryGhost/Toolbox/issues/324 refs: https://github.com/TryGhost/Ghost/issues/14446 - Currently, if url is configured to http but a request is marked secure, Ghost will handle upgrading all internal URLs to https so that there are no mixed content warnings - From 5.0 that feature is going away, in favour of strictly honouring the configured URL - Ghost will serve URLs exactly as configured and won't upgrade http to https anymore - This use case was common when Ghost was first built, but in 2022 the web is mostly https. - The code needed to support the feature creates a lot of additional complexity & maintenance overhead, so removing this gives us space to do more cool and useful stuff in 2022
140 lines
5.1 KiB
JavaScript
140 lines
5.1 KiB
JavaScript
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const urlUtils = require('../../../../core/shared/url-utils');
|
|
const urlService = require('../../../../core/server/services/url');
|
|
const getUrl = require('../../../../core/frontend/meta/url');
|
|
const testUtils = require('../../../utils');
|
|
|
|
describe('getUrl', function () {
|
|
beforeEach(function () {
|
|
sinon.stub(urlService, 'getUrlByResourceId');
|
|
sinon.stub(urlUtils, 'urlFor');
|
|
});
|
|
|
|
afterEach(function () {
|
|
sinon.restore();
|
|
});
|
|
|
|
it('should return url for a post', function () {
|
|
const post = testUtils.DataGenerator.forKnex.createPost();
|
|
|
|
urlService.getUrlByResourceId.withArgs(post.id, {absolute: undefined, withSubdirectory: true})
|
|
.returns('post url');
|
|
|
|
getUrl(post).should.eql('post url');
|
|
});
|
|
|
|
describe('preview url: drafts/scheduled posts', function () {
|
|
it('relative', function () {
|
|
const post = testUtils.DataGenerator.forKnex.createPost({status: 'draft'});
|
|
urlService.getUrlByResourceId.withArgs(post.id).returns('/404/');
|
|
urlUtils.urlFor.withArgs({relativeUrl: '/p/' + post.uuid + '/'}, null, undefined).returns('relative');
|
|
let url = getUrl(post);
|
|
|
|
urlService.getUrlByResourceId.calledOnce.should.be.true();
|
|
urlUtils.urlFor.withArgs({relativeUrl: '/p/' + post.uuid + '/'}, null, undefined)
|
|
.calledOnce.should.be.true();
|
|
|
|
url.should.eql('relative');
|
|
});
|
|
|
|
it('absolute', function () {
|
|
const post = testUtils.DataGenerator.forKnex.createPost({status: 'draft'});
|
|
urlService.getUrlByResourceId.withArgs(post.id).returns('/404/');
|
|
urlUtils.urlFor.withArgs({relativeUrl: '/p/' + post.uuid + '/'}, null, true).returns('absolute');
|
|
let url = getUrl(post, true);
|
|
|
|
urlService.getUrlByResourceId.calledOnce.should.be.true();
|
|
urlUtils.urlFor.withArgs({relativeUrl: '/p/' + post.uuid + '/'}, null, true)
|
|
.calledOnce.should.be.true();
|
|
|
|
url.should.eql('absolute');
|
|
});
|
|
});
|
|
|
|
it('should return absolute url for a post', function () {
|
|
const post = testUtils.DataGenerator.forKnex.createPost();
|
|
|
|
urlService.getUrlByResourceId.withArgs(post.id, {absolute: true, withSubdirectory: true})
|
|
.returns('absolute post url');
|
|
|
|
getUrl(post, true).should.eql('absolute post url');
|
|
});
|
|
|
|
it('should return absolute url for a post and remove /amp/ in url', function () {
|
|
const data = {relativeUrl: '/*/amp/'};
|
|
|
|
urlUtils.urlFor.withArgs(data, {}, true).returns('absolute/*/amp/');
|
|
getUrl(data, true).should.eql('absolute/*/');
|
|
urlService.getUrlByResourceId.called.should.be.false();
|
|
});
|
|
|
|
it('should return url for a tag', function () {
|
|
const tag = testUtils.DataGenerator.forKnex.createTag();
|
|
|
|
// @NOTE: we currently have no way to generate a test model which is correctly jsonified
|
|
// e.g. testUtils.DataGenerator.forModel.createTag().toJSON()
|
|
// the tag object contains a `parent` attribute. the tag model contains a `parent_id` attr.
|
|
tag.parent = null;
|
|
|
|
urlService.getUrlByResourceId.withArgs(tag.id, {absolute: undefined, withSubdirectory: true})
|
|
.returns('tag url');
|
|
|
|
getUrl(tag).should.eql('tag url');
|
|
});
|
|
|
|
it('should return url for a author', function () {
|
|
const author = testUtils.DataGenerator.forKnex.createUser();
|
|
|
|
urlService.getUrlByResourceId.withArgs(author.id, {absolute: undefined, withSubdirectory: true})
|
|
.returns('author url');
|
|
|
|
getUrl(author).should.eql('author url');
|
|
});
|
|
|
|
it('should return absolute url for a author', function () {
|
|
const author = testUtils.DataGenerator.forKnex.createUser();
|
|
|
|
urlService.getUrlByResourceId.withArgs(author.id, {absolute: true, withSubdirectory: true})
|
|
.returns('absolute author url');
|
|
|
|
getUrl(author, true).should.eql('absolute author url');
|
|
});
|
|
|
|
it('should return url for a nav', function () {
|
|
const data = {
|
|
label: 'About Me',
|
|
url: '/about-me/',
|
|
slug: 'about-me',
|
|
current: true
|
|
};
|
|
|
|
urlUtils.urlFor.withArgs('nav', {nav: data}, undefined)
|
|
.returns('nav url');
|
|
|
|
getUrl(data).should.equal('nav url');
|
|
});
|
|
|
|
it('should return absolute url for a nav', function () {
|
|
const data = {
|
|
label: 'About Me',
|
|
url: '/about-me/',
|
|
slug: 'about-me',
|
|
current: true
|
|
};
|
|
|
|
urlUtils.urlFor.withArgs('nav', {nav: data}, true)
|
|
.returns('absolute nav url');
|
|
|
|
getUrl(data, true).should.equal('absolute nav url');
|
|
});
|
|
|
|
it('should return `relativeUrl` and remove /amp/ in url', function () {
|
|
const data = {relativeUrl: '/*/amp/'};
|
|
|
|
urlUtils.urlFor.withArgs(data, {}, undefined).returns(data.relativeUrl);
|
|
getUrl(data).should.eql('/*/');
|
|
urlService.getUrlByResourceId.called.should.be.false();
|
|
});
|
|
});
|