dcd65bfa4f
ref https://linear.app/tryghost/issue/ENG-851/implement-a-minimal-but-complete-version-of-redirect-caching-to ref https://app.incident.io/ghost/incidents/55 Often immediately after sending an email, sites receive a large volume of requests to LinkRedirect endpoints from members clicking on the links in the email. We currently don't cache any of these requests in our CDN, because we also record click events, update the member's `last_seen_at` timestamp, and send webhooks in response to these clicks, so Ghost needs to handle each of these requests itself. This means that each of these LinkRedirect requests hits Ghost, and currently all these requests hit the database to lookup where to redirect the member to. Each one of these requests can make up to 11 database queries, which can quickly exhaust Ghost's database connection pool. Even though the LinkRedirect lookup query is fairly cheap and quick, these queries aren't prioritized over the "record" queries Ghost needs to handle, so they can get stuck behind other queries in the queue and eventually timeout. The result is that members are unable to actually reach the destination of the link they clicked on, instead receiving a 500 error in Ghost, or it can take a long time (60s+) for the redirect to happen. This PR uses our existing `adapterManager` to cache the redirect lookups either in-memory or in Redis (if configured — by default there is no caching). This only removes 1 out of 11 queries per redirect request, so it won't reduce the load on the DB drastically, but it at least decouples the serving of the LinkRedirect from the DB so the member can be redirected even if the DB is under heavy load. Local load testing results have shown a decrease in response times from 60 seconds to ~50ms for the redirect requests when handling 500 requests per second, and reduced the 500 error rate to 0. |
||
|---|---|---|
| .github | ||
| .vscode | ||
| apps | ||
| ghost | ||
| .editorconfig | ||
| .envrc | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| flake.lock | ||
| flake.nix | ||
| LICENSE | ||
| nx.json | ||
| package.json | ||
| PRIVACY.md | ||
| README.md | ||
| SECURITY.md | ||
| yarn.lock | ||
Ghost.org •
Forum •
Docs •
Contributing •
Twitter
The easiest way to get a production instance deployed is with our official Ghost(Pro) managed service. It takes about 2 minutes to launch a new site with worldwide CDN, backups, security and maintenance all done for you.
For most people this ends up being the best value option because of how much time it saves — and 100% of revenue goes to the Ghost Foundation; funding the maintenance and further development of the project itself. So you’ll be supporting open source software and getting a great service!
Quickstart install
If you want to run your own instance of Ghost, in most cases the best way is to use our CLI tool
npm install ghost-cli -g
Then, if installing locally add the local flag to get up and running in under a minute - Local install docs
ghost install local
or on a server run the full install, including automatic SSL setup using LetsEncrypt - Production install docs
ghost install
Check out our official documentation for more information about our recommended hosting stack & properly upgrading Ghost, plus everything you need to develop your own Ghost themes or work with our API.
Contributors & advanced developers
For anyone wishing to contribute to Ghost or to hack/customize core files we recommend following our full development setup guides: Contributor guide • Developer setup
Ghost sponsors
We'd like to extend big thanks to our sponsors and partners who make Ghost possible. If you're interested in sponsoring Ghost and supporting the project, please check out our profile on GitHub sponsors ❤️
Getting help
You can find answers to a huge variety of questions, along with a large community of helpful developers over on the Ghost forum - replies are generally very quick. Ghost(Pro) customers also have access to 24/7 email support.
To stay up to date with all the latest news and product updates, make sure you subscribe to our blog — or you can always follow us on Twitter, if you prefer your updates bite-sized and facetious. 🎷🐢
Copyright & license
Copyright (c) 2013-2023 Ghost Foundation - Released under the MIT license. Ghost and the Ghost Logo are trademarks of Ghost Foundation Ltd. Please see our trademark policy for info on acceptable usage.