Ghost/ghost/offers/lib/application/OffersAPI.js
Fabien O'Carroll e744c0f82e Fixed issue with updating offer to empty description
no-issue

Because we were checking for truthyness rather than existence when
updating properties on an Offer - it was impossible to set the
description to a blank string, as this is falsy.
2021-10-19 11:00:18 +02:00

118 lines
3.7 KiB
JavaScript

const Offer = require('../domain/models/Offer');
const OfferName = require('../domain/models/OfferName');
const OfferCode = require('../domain/models/OfferCode');
const OfferTitle = require('../domain/models/OfferTitle');
const OfferDescription = require('../domain/models/OfferDescription');
const OfferStatus = require('../domain/models/OfferStatus');
const OfferMapper = require('./OfferMapper');
const UniqueChecker = require('./UniqueChecker');
class OffersAPI {
/**
* @param {import('./OfferRepository')} repository
*/
constructor(repository) {
this.repository = repository;
}
/**
* @param {object} data
* @param {string} data.id
*
* @returns {Promise<OfferMapper.OfferDTO>}
*/
async getOffer(data) {
return this.repository.createTransaction(async (transaction) => {
const options = {transacting: transaction};
const offer = await this.repository.getById(data.id, options);
return OfferMapper.toDTO(offer);
});
}
/**
* @param {any} data
*
* @returns {Promise<OfferMapper.OfferDTO>}
*/
async createOffer(data) {
return this.repository.createTransaction(async (transaction) => {
const options = {transacting: transaction};
const uniqueChecker = new UniqueChecker(this.repository, transaction);
const offer = await Offer.create(data, uniqueChecker);
await this.repository.save(offer, options);
return OfferMapper.toDTO(offer);
});
}
/**
* @param {object} data
* @param {string} data.id
* @param {string} [data.name]
* @param {string} [data.display_title]
* @param {string} [data.display_description]
* @param {string} [data.code]
* @param {string} [data.status]
*
* @returns {Promise<OfferMapper.OfferDTO>}
*/
async updateOffer(data) {
return await this.repository.createTransaction(async (transaction) => {
const options = {transacting: transaction};
const uniqueChecker = new UniqueChecker(this.repository, transaction);
const offer = await this.repository.getById(data.id, options);
if (Reflect.has(data, 'name')) {
const name = OfferName.create(data.name);
await offer.updateName(name, uniqueChecker);
}
if (Reflect.has(data, 'code')) {
const code = OfferCode.create(data.code);
await offer.updateCode(code, uniqueChecker);
}
if (Reflect.has(data, 'display_title')) {
const title = OfferTitle.create(data.display_title);
offer.displayTitle = title;
}
if (Reflect.has(data, 'display_description')) {
const description = OfferDescription.create(data.display_description);
offer.displayDescription = description;
}
if (Reflect.has(data, 'status')) {
const status = OfferStatus.create(data.status);
offer.status = status;
}
await this.repository.save(offer, options);
return OfferMapper.toDTO(offer);
});
}
/**
* @param {object} options
* @param {string} options.filter
* @returns {Promise<OfferMapper.OfferDTO[]>}
*/
async listOffers(options) {
return await this.repository.createTransaction(async (transaction) => {
const opts = {transacting: transaction, filter: options.filter};
const offers = await this.repository.getAll(opts);
return offers.map(OfferMapper.toDTO);
});
}
}
module.exports = OffersAPI;