b4654b19d5
no-issue * Added InternalServerError to resizeImage * Added a redirect to original image if sharp is missing * Improved naming - safeMethod -> method * Updated process method to follow same sharp check pattern * Refactor safety wrapper into makeSafe function * Moved generic manipulation error to makeSafe function * Refactored unsafeProcess to use unsafeResizeImage * Removed CRAZY catch
110 lines
3.9 KiB
JavaScript
110 lines
3.9 KiB
JavaScript
const should = require('should');
|
|
const sinon = require('sinon');
|
|
const fs = require('fs-extra');
|
|
const common = require('../../../../server/lib/common');
|
|
const manipulator = require('../../../../server/lib/image/manipulator');
|
|
const testUtils = require('../../../utils');
|
|
const sandbox = sinon.sandbox.create();
|
|
|
|
describe('lib/image: manipulator', function () {
|
|
afterEach(function () {
|
|
sandbox.restore();
|
|
testUtils.unmockNotExistingModule();
|
|
});
|
|
|
|
describe('cases', function () {
|
|
let sharp, sharpInstance;
|
|
|
|
beforeEach(function () {
|
|
sandbox.stub(fs, 'readFile').resolves('original');
|
|
sandbox.stub(fs, 'writeFile').resolves();
|
|
|
|
sharpInstance = {
|
|
resize: sandbox.stub().returnsThis(),
|
|
rotate: sandbox.stub().returnsThis(),
|
|
toBuffer: sandbox.stub(),
|
|
};
|
|
|
|
sharp = sandbox.stub().callsFake(() => {
|
|
return sharpInstance;
|
|
});
|
|
|
|
testUtils.mockNotExistingModule('sharp', sharp);
|
|
});
|
|
|
|
it('resize image', function () {
|
|
sharpInstance.toBuffer.resolves('manipulated');
|
|
|
|
return manipulator.process({width: 1000})
|
|
.then(() => {
|
|
sharpInstance.resize.calledOnce.should.be.true();
|
|
sharpInstance.rotate.calledOnce.should.be.true();
|
|
|
|
fs.writeFile.calledOnce.should.be.true();
|
|
fs.writeFile.calledWith('manipulated');
|
|
});
|
|
});
|
|
|
|
it('skip resizing if image is too small', function () {
|
|
sharpInstance.toBuffer.resolves('manipulated');
|
|
|
|
return manipulator.process({width: 1000})
|
|
.then(() => {
|
|
sharpInstance.resize.calledOnce.should.be.true();
|
|
should.deepEqual(sharpInstance.resize.args[0][2], {
|
|
withoutEnlargement: true
|
|
});
|
|
|
|
fs.writeFile.calledOnce.should.be.true();
|
|
fs.writeFile.calledWith('manipulated');
|
|
});
|
|
});
|
|
|
|
it('uses original image as an output when the size (bytes) is bigger after manipulation', function () {
|
|
sharpInstance.toBuffer.resolves('manipulated to a very very very very very very very large size');
|
|
|
|
return manipulator.process({width: 1000})
|
|
.then(() => {
|
|
sharpInstance.resize.calledOnce.should.be.true();
|
|
sharpInstance.rotate.calledOnce.should.be.true();
|
|
sharpInstance.toBuffer.calledOnce.should.be.true();
|
|
|
|
fs.writeFile.calledOnce.should.be.true();
|
|
fs.writeFile.calledWith('original');
|
|
});
|
|
});
|
|
|
|
it('sharp throws error during processing', function () {
|
|
sharpInstance.toBuffer.resolves('manipulated');
|
|
|
|
fs.writeFile.rejects(new Error('whoops'));
|
|
|
|
return manipulator.process({width: 2000})
|
|
.then(() => {
|
|
'1'.should.eql(1, 'Expected to fail');
|
|
})
|
|
.catch((err) => {
|
|
(err instanceof common.errors.InternalServerError).should.be.true;
|
|
err.code.should.eql('IMAGE_PROCESSING');
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('installation', function () {
|
|
beforeEach(function () {
|
|
testUtils.mockNotExistingModule('sharp', new Error(), true);
|
|
});
|
|
|
|
it('sharp was not installed', function () {
|
|
return manipulator.process()
|
|
.then(() => {
|
|
'1'.should.eql(1, 'Expected to fail');
|
|
})
|
|
.catch((err) => {
|
|
(err instanceof common.errors.InternalServerError).should.be.true();
|
|
err.code.should.eql('SHARP_INSTALLATION');
|
|
});
|
|
});
|
|
});
|
|
});
|