Ghost/apps/admin-x-settings/test/acceptance/general/socialAccounts.test.ts
Peter Zimon 8bc035ccb7
Update twitter.com to x.com (#20234)
DES-351

There's a frontend validation in Settings that rewrites the Twitter (X)
URL in social accounts to match the format: twitter.com. As of May 17, X
officially changed their domain to x.com so this validation is outdated.

---------

Co-authored-by: Ronald Langeveld <hi@ronaldlangeveld.com>
2024-05-22 10:00:13 +02:00

145 lines
4.7 KiB
TypeScript

import {expect, test} from '@playwright/test';
import {globalDataRequests} from '../../utils/acceptance';
import {mockApi, testUrlValidation, updatedSettingsResponse} from '@tryghost/admin-x-framework/test/acceptance';
test.describe('Social account settings', async () => {
test('Supports editing social URLs', async ({page}) => {
const {lastApiRequests} = await mockApi({page, requests: {
...globalDataRequests,
editSettings: {method: 'PUT', path: '/settings/', response: updatedSettingsResponse([
{key: 'facebook', value: 'fb'},
{key: 'twitter', value: '@tw'}
])}
}});
await page.goto('/');
const section = page.getByTestId('social-accounts');
await expect(section.getByText('https://www.facebook.com/ghost')).toHaveCount(1);
await expect(section.getByText('https://x.com/ghost')).toHaveCount(1);
await section.getByRole('button', {name: 'Edit'}).click();
await section.getByLabel(`URL of your publication's Facebook Page`).fill('https://www.facebook.com/fb');
await section.getByLabel('URL of your X (formerly Twitter) profile').fill('https://x.com/tw');
await section.getByRole('button', {name: 'Save'}).click();
await expect(section.getByLabel('URL of your X (formerly Twitter) profile')).toHaveCount(0);
await expect(section.getByText('https://www.facebook.com/fb')).toHaveCount(1);
await expect(section.getByText('https://x.com/tw')).toHaveCount(1);
expect(lastApiRequests.editSettings?.body).toEqual({
settings: [
{key: 'facebook', value: 'fb'},
{key: 'twitter', value: '@tw'}
]
});
});
test('Formats and validates the URLs', async ({page}) => {
await mockApi({page, requests: {
...globalDataRequests
}});
await page.goto('/');
const section = page.getByTestId('social-accounts');
await section.getByRole('button', {name: 'Edit'}).click();
const facebookInput = section.getByLabel(`URL of your publication's Facebook Page`);
await testUrlValidation(
facebookInput,
'facebook.com/username',
'https://www.facebook.com/username'
);
await testUrlValidation(
facebookInput,
'testuser',
'https://www.facebook.com/testuser'
);
await testUrlValidation(
facebookInput,
'ab99',
'https://www.facebook.com/ab99'
);
await testUrlValidation(
facebookInput,
'page/ab99',
'https://www.facebook.com/page/ab99'
);
await testUrlValidation(
facebookInput,
'page/*(&*(%%))',
'https://www.facebook.com/page/*(&*(%%))'
);
await testUrlValidation(
facebookInput,
'facebook.com/pages/some-facebook-page/857469375913?ref=ts',
'https://www.facebook.com/pages/some-facebook-page/857469375913?ref=ts'
);
await testUrlValidation(
facebookInput,
'https://www.facebook.com/groups/savethecrowninn',
'https://www.facebook.com/groups/savethecrowninn'
);
await testUrlValidation(
facebookInput,
'http://github.com/username',
'http://github.com/username',
'The URL must be in a format like https://www.facebook.com/yourPage'
);
await testUrlValidation(
facebookInput,
'http://github.com/pages/username',
'http://github.com/pages/username',
'The URL must be in a format like https://www.facebook.com/yourPage'
);
const twitterInput = section.getByLabel('URL of your X (formerly Twitter) profile');
await testUrlValidation(
twitterInput,
'twitter.com/username',
'https://x.com/username'
);
await testUrlValidation(
twitterInput,
'testuser',
'https://x.com/testuser'
);
await testUrlValidation(
twitterInput,
'http://github.com/username',
'https://x.com/username'
);
await testUrlValidation(
twitterInput,
'*(&*(%%))',
'*(&*(%%))',
'The URL must be in a format like https://x.com/yourUsername'
);
await testUrlValidation(
twitterInput,
'thisusernamehasmorethan15characters',
'thisusernamehasmorethan15characters',
'Your Username is not a valid Twitter Username'
);
});
});