7b443d4b63
no issue
The `config` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.
- removed use of `ProxyMixin` in the `config` service by grabbing the API response after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to a tracked object holding the API response data. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `config.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed unnecessary async around `config.availableTimezones` which wasn't making any async calls
|
||
|---|---|---|
| .. | ||
| accent-color-background.js | ||
| author-names.js | ||
| background-image-style.js | ||
| capitalize-first-letter.js | ||
| currency-symbol.js | ||
| enable-developer-experiments.js | ||
| event-name.js | ||
| feature.js | ||
| first-name.js | ||
| format-number.js | ||
| full-email-address.js | ||
| get-setting.js | ||
| gh-count-characters.js | ||
| gh-count-down-characters.js | ||
| gh-format-post-time.js | ||
| gh-pluralize.js | ||
| gh-price-amount.js | ||
| gh-user-can-admin.js | ||
| hex-adjust.js | ||
| hex-contrast.js | ||
| highlighted-text.js | ||
| history-event-fetcher.js | ||
| history-event-filter.js | ||
| humanize-recipient-filter.js | ||
| humanize-setting-key.js | ||
| integration-icon-style.js | ||
| is-moment-today.js | ||
| members-count-fetcher.js | ||
| members-event-fetcher.js | ||
| members-event-filter.js | ||
| moment-site-tz.js | ||
| most-recently-updated.js | ||
| noop.js | ||
| parse-history-event.js | ||
| parse-member-event.js | ||
| post-author-names.js | ||
| publish-options.js | ||
| query-selector.js | ||
| reset-query-params.js | ||
| set-has.js | ||
| set-query-params.js | ||
| site-icon-style.js | ||
| toggle-feature.js | ||
| ui-btn-span.js | ||
| ui-btn.js | ||
| ui-text.js | ||