fb7bf6d01e
refs https://github.com/TryGhost/Product/issues/3832 --- <!-- Leave the line below if you'd like GitHub Copilot to generate a summary from your commit --> <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 7eda74c</samp> This pull request improves the validation, customization, and feedback of various form components and modals in the admin-x-settings app. It also adds new components for user detail modal sections and modifies the user type to allow null values for social accounts. Additionally, it adds `dirty` props to some integration modals and a `data-testid` attribute to the exit settings button. It also deletes an unused file.
144 lines
4.6 KiB
TypeScript
144 lines
4.6 KiB
TypeScript
import {expect, test} from '@playwright/test';
|
|
import {globalDataRequests, mockApi, testUrlValidation, updatedSettingsResponse} from '../../utils/acceptance';
|
|
|
|
test.describe('Social account settings', async () => {
|
|
test('Supports editing social URLs', async ({page}) => {
|
|
const {lastApiRequests} = await mockApi({page, requests: {
|
|
...globalDataRequests,
|
|
editSettings: {method: 'PUT', path: '/settings/', response: updatedSettingsResponse([
|
|
{key: 'facebook', value: 'fb'},
|
|
{key: 'twitter', value: '@tw'}
|
|
])}
|
|
}});
|
|
|
|
await page.goto('/');
|
|
|
|
const section = page.getByTestId('social-accounts');
|
|
|
|
await expect(section.getByText('https://www.facebook.com/ghost')).toHaveCount(1);
|
|
await expect(section.getByText('https://twitter.com/ghost')).toHaveCount(1);
|
|
|
|
await section.getByRole('button', {name: 'Edit'}).click();
|
|
|
|
await section.getByLabel(`URL of your publication's Facebook Page`).fill('https://www.facebook.com/fb');
|
|
await section.getByLabel('URL of your X (formerly Twitter) profile').fill('https://twitter.com/tw');
|
|
|
|
await section.getByRole('button', {name: 'Save'}).click();
|
|
|
|
await expect(section.getByLabel('URL of your X (formerly Twitter) profile')).toHaveCount(0);
|
|
|
|
await expect(section.getByText('https://www.facebook.com/fb')).toHaveCount(1);
|
|
await expect(section.getByText('https://twitter.com/tw')).toHaveCount(1);
|
|
|
|
expect(lastApiRequests.editSettings?.body).toEqual({
|
|
settings: [
|
|
{key: 'facebook', value: 'fb'},
|
|
{key: 'twitter', value: '@tw'}
|
|
]
|
|
});
|
|
});
|
|
|
|
test('Formats and validates the URLs', async ({page}) => {
|
|
await mockApi({page, requests: {
|
|
...globalDataRequests
|
|
}});
|
|
|
|
await page.goto('/');
|
|
|
|
const section = page.getByTestId('social-accounts');
|
|
await section.getByRole('button', {name: 'Edit'}).click();
|
|
|
|
const facebookInput = section.getByLabel(`URL of your publication's Facebook Page`);
|
|
|
|
await testUrlValidation(
|
|
facebookInput,
|
|
'facebook.com/username',
|
|
'https://www.facebook.com/username'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
facebookInput,
|
|
'testuser',
|
|
'https://www.facebook.com/testuser'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
facebookInput,
|
|
'ab99',
|
|
'https://www.facebook.com/ab99'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
facebookInput,
|
|
'page/ab99',
|
|
'https://www.facebook.com/page/ab99'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
facebookInput,
|
|
'page/*(&*(%%))',
|
|
'https://www.facebook.com/page/*(&*(%%))'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
facebookInput,
|
|
'facebook.com/pages/some-facebook-page/857469375913?ref=ts',
|
|
'https://www.facebook.com/pages/some-facebook-page/857469375913?ref=ts'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
facebookInput,
|
|
'https://www.facebook.com/groups/savethecrowninn',
|
|
'https://www.facebook.com/groups/savethecrowninn'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
facebookInput,
|
|
'http://github.com/username',
|
|
'http://github.com/username',
|
|
'The URL must be in a format like https://www.facebook.com/yourPage'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
facebookInput,
|
|
'http://github.com/pages/username',
|
|
'http://github.com/pages/username',
|
|
'The URL must be in a format like https://www.facebook.com/yourPage'
|
|
);
|
|
|
|
const twitterInput = section.getByLabel('URL of your X (formerly Twitter) profile');
|
|
|
|
await testUrlValidation(
|
|
twitterInput,
|
|
'twitter.com/username',
|
|
'https://twitter.com/username'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
twitterInput,
|
|
'testuser',
|
|
'https://twitter.com/testuser'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
twitterInput,
|
|
'http://github.com/username',
|
|
'https://twitter.com/username'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
twitterInput,
|
|
'*(&*(%%))',
|
|
'*(&*(%%))',
|
|
'The URL must be in a format like https://twitter.com/yourUsername'
|
|
);
|
|
|
|
await testUrlValidation(
|
|
twitterInput,
|
|
'thisusernamehasmorethan15characters',
|
|
'thisusernamehasmorethan15characters',
|
|
'Your Username is not a valid Twitter Username'
|
|
);
|
|
});
|
|
});
|