OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4c5144cb61
Ghost/ghost/admin/app/routes
History
Kevin Ansfield 4c5144cb61 🐛 Fixed close button on "unsaved changes" modal not always behaving like "Stay" button 
no issue

The close button in the unsaved changes modal used the `@close` action directly compared to the "Stay" button which used `(fn @close false)`. The close button version without explicit arguments resulted in the first argument being a `PointerEvent` instance which if checked as a modal return value as `if (shouldClose)` would evaluate as truthy therefore matching the "Leave" behaviour instead of the "Stay" behaviour.

- changed modal to explicitly call `(fn @close false)` when the close button is clicked
- updated design settings route to have an explicit `shouldLeave === true` check so default behaviour is always "Stay"
2022-04-14 12:39:10 +01:00
..
editor [chore] migrate to eslint@8 and run --fix (#2256) 2022-02-10 10:41:36 +00:00
member Updated members routes/controllers with Octane idioms 2020-05-20 16:39:31 +01:00
members Refactored away CurrentUserSettings mixin (#2200) 2022-01-17 10:05:27 +00:00
offer Added initial wiring for offer screens 2021-10-06 20:01:25 +05:30
settings 🐛 Fixed close button on "unsaved changes" modal not always behaving like "Stay" button 2022-04-14 12:39:10 +01:00
setup 🎨 Redesigned user authentication pages (#2286) 2022-03-08 17:30:46 +00:00
tag Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
admin.js Refactored away CurrentUserSettings mixin (#2200) 2022-01-17 10:05:27 +00:00
application.js Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
authenticated.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
dashboard.js Updated default redirect for contributors 2022-02-02 10:12:16 +01:00
designsandbox.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
editor.js Dropped ember-useragent dependency 2022-03-07 10:06:35 +00:00
error404.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
home.js Renamed Finishing Touches onboarding step to Done with other changes and styling tweaks 2022-03-02 12:46:15 +00:00
launch.js Renamed isAdmin/isOwner/isAdminOrOwner to reduce confusion 2021-07-12 14:55:56 +02:00
member.js Cleaned up membersActivityFeed labs flag (#2309) 2022-03-30 12:43:52 +01:00
members-activity.js Cleaned up membersActivityFeed labs flag (#2309) 2022-03-30 12:43:52 +01:00
members.js Refactored away CurrentUserSettings mixin (#2200) 2022-01-17 10:05:27 +00:00
offer.js Refactored away CurrentUserSettings mixin (#2200) 2022-01-17 10:05:27 +00:00
offers.js Refactored away CurrentUserSettings mixin (#2200) 2022-01-17 10:05:27 +00:00
pages.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
posts.js Contributors updates (#2235) 2022-02-01 18:59:20 +01:00
pro.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
reset.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
settings.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
setup.js 🎨 Redesigned user authentication pages (#2286) 2022-03-08 17:30:46 +00:00
signin.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
signout.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
signup.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
site.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
tag.js Refactored away CurrentUserSettings mixin (#2200) 2022-01-17 10:05:27 +00:00
tags.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00
unauthenticated.js Removed usage of deprecated EmberSimpleAuth mixins (#1910) 2021-04-12 13:21:57 +01:00
whatsnew.js Migrated route objects to native class syntax 2022-01-17 10:06:57 +00:00