8f3985bc66
ref https://linear.app/tryghost/issue/ENG-1518 After releasing the analytics job improvements, it appears for large sites we're awfully close to missing some Mailgun events because of an unexpected behavior of the aggregateStats call for just the opened events job. This is taking 2-5x(+) the amount of time that the aggregate queries take for the other jobs, despite not being dependent on the events. To err on the side of caution, we're going to roll this back and look to optimize the aggregation queries before re-implementing. And we may be a bit more cautious in giving _some_ but not _all_ priority to the `opened` events. |
||
|---|---|---|
| .. | ||
| __snapshots__ | ||
| batch-sending.test.js | ||
| cards.test.js | ||
| email-event-storage.test.js | ||
| README.md | ||
What is a golden post?
The golden post is a single lexical post that has at least one example of every card that is available in the Koenig editor (with a few exceptions for cards that should never make it into an email). We have run into problems in the past where a small change to a particular card or to the EmailRenderer itself results in seriously mangled email rendering in one or more clients (usually Outlook).
How do I update the golden post to include a new card?
If you're seeing a failing test like The golden post does not contain the ${card} card, that means that you (or someone else) has added a new node to @tryghost/kg-default-nodes that is not currently represented in the golden post. This test is here to trigger a review of the rendered email of the new card, to make sure it doesn't break the formatting in email clients. To update this test properly, please do the following:
- Create a card in the lexical editor, either at
koenig.ghost.orgor in your local Koenig repo - Use the JSON Output in the bottom right of the demo to copy the lexical payload for the new card
- Paste the lexical payload for the card as a top level child of the
rootnode in the golden post fixture atghost/core/test/utils/fixtures/email-service/golden-post.json - Re-run your tests with
UPDATE_SNAPSHOT=1set to update the snapshot to include the new card - Update (or recreate) the Golden Post on
main.ghost.orgusing thegolden-post.jsonstring. - Send a test email to Litmus and examine the rendered output to ensure everything looks right on different clients.