342b5512fc
refs https://ghost.slack.com/archives/CTH5NDJMS/p1699359241142969 It's possible for `ObjectIDs` to have only numeric characters. We were previously letting the type be inferred, which created a very rare but possible edge case where the last recipient of an email batch had a numeric ObjectID, resulting in a numeric comparison against alphanumeric `ObjectIDs` in the database. - updated the filter to add `'`'s around the `lastId` parameter - updated tests to check for the type of the id filter parameter value - can't fully test for numeric object IDs using what we have because javascript cannot handle numerics of that size; may be able to look at using fixture data loaded directly into the db |
||
---|---|---|
.. | ||
utils | ||
.eslintrc.js | ||
batch-sending-service.test.js | ||
email-controller.test.js | ||
email-event-processor.test.js | ||
email-event-storage.test.js | ||
email-renderer.test.js | ||
email-segmenter.test.js | ||
email-service.test.js | ||
mailgun-email-provider.test.js | ||
sending-service.test.js |