8a4e81fadd
- quite funny because it's such a sneaky thing to discover
- this code actually results in looping over
`'xxxxx<,t,e,s,t,f,o,o,t,>'` and not an array of characters
- adding brackets fixes that
---
<!-- Leave the line below if you'd like GitHub Copilot to generate a
summary from your commit -->
<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 584ab6c</samp>
Fix a bug in the code injection test case for the admin settings app.
Ensure that the test code is properly padded and split by using
parentheses in the string concatenations.
---------
Co-authored-by: Jono Mingard <reason.koan@gmail.com>
43 lines
1.7 KiB
TypeScript
43 lines
1.7 KiB
TypeScript
import {expect, test} from '@playwright/test';
|
|
import {globalDataRequests, mockApi, responseFixtures} from '../../utils/acceptance';
|
|
|
|
test.describe('Twitter settings', async () => {
|
|
test('Supports editing the twitter card', async ({page}) => {
|
|
const {lastApiRequests} = await mockApi({page, requests: {
|
|
...globalDataRequests,
|
|
uploadImage: {method: 'POST', path: '/images/upload/', response: {images: [{url: 'http://example.com/image.png', ref: null}]}},
|
|
editSettings: {method: 'PUT', path: '/settings/', response: responseFixtures.settings}
|
|
}});
|
|
|
|
await page.goto('/');
|
|
|
|
const section = page.getByTestId('twitter');
|
|
|
|
await section.getByRole('button', {name: 'Edit'}).click();
|
|
|
|
const fileChooserPromise = page.waitForEvent('filechooser');
|
|
|
|
await page.locator('label[for="twitter-image"]').click();
|
|
|
|
const fileChooser = await fileChooserPromise;
|
|
await fileChooser.setFiles(`${__dirname}/../../utils/images/image.png`);
|
|
|
|
await expect(section.locator('img[src="http://example.com/image.png"]')).toBeVisible();
|
|
|
|
await section.getByLabel('X title').fill('Twititle');
|
|
await section.getByLabel('X description').fill('Twitscription');
|
|
|
|
await section.getByRole('button', {name: 'Save'}).click();
|
|
|
|
await expect(section.getByLabel('Twitter title')).toHaveCount(0);
|
|
|
|
expect(lastApiRequests.editSettings?.body).toEqual({
|
|
settings: [
|
|
{key: 'twitter_image', value: 'http://example.com/image.png'},
|
|
{key: 'twitter_title', value: 'Twititle'},
|
|
{key: 'twitter_description', value: 'Twitscription'}
|
|
]
|
|
});
|
|
});
|
|
});
|