2e53d9985a
refs https://www.notion.so/ghost/When-hitting-ESC-within-the-Pintura-editor-editing-cover-image-from-Design-Branding-it-would-e-b1c70064f2fd4f5cb830b095c2abd08e - When escape was hit in within the Pintura editor in Settings, it cleared the modal underneath it, causing the close button to become unresponsive. - A previous commit was made to disable the escape key altogether so that users don't accidentally quit Pintura and having all their changes discarded. - This fixes a regression to make sure the background modal don't hide and Pintura can only be closed by mouse clicking the actual close button on the top left, if not saving it on the top right. --- <!-- Leave the line below if you'd like GitHub Copilot to generate a summary from your commit --> <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at 5ed7f7e</samp> This pull request enhances the Pintura editor integration by adding error reporting and escape key handling. It modifies the `usePinturaEditor` hook in `apps/admin-x-settings/src/hooks/usePinturaEditor.ts`. |
||
|---|---|---|
| .. | ||
| .storybook | ||
| src | ||
| test | ||
| .eslintrc.cjs | ||
| .yarnrc | ||
| index.html | ||
| node-shim.cjs | ||
| package.json | ||
| playwright.config.ts | ||
| postcss.config.cjs | ||
| README.md | ||
| tailwind.config.cjs | ||
| tsconfig.json | ||
| tsconfig.node.json | ||
| vite.config.ts | ||
Admin X Settings
Ghost Admin Settings in React
Development
Pre-requisites
- Run
yarnin Ghost monorepo root
Running the development version
Run yarn dev to start the development server to test/develop the settings standalone. This will generate a demo site from the index.html file which renders the app and makes it available on http://localhost:5173
Running inside Admin
Run yarn dev (like you would run Ghost dev normally) from the top-level repo. AdminX will automatically rebuild when you make changes.
Develop
This is a monorepo package.
Follow the instructions for the top-level repo.
git clonethis repo &cdinto it as usual- Run
yarnto install top-level dependencies.
Test
yarn lintrun just eslintyarn test:acceptanceruns acceptance testsyarn test:unitruns unit testsyarn test:acceptance path/to/testruns a specific testyarn test:acceptance:slowmoruns acceptance tests in slow motion and headed mode, useful for debugging and developing tests