Ghost/ghost/admin/app
Simon Backx 848b2d82a1
Cleaned up suppressionList feature flag (#16736)
no issue

This pull request removes the `suppressionList` feature flag and all its
dependencies from the codebase. It makes the suppression list feature
the default and consistent behavior for all email events and
newsletters. It simplifies the UI, logic, and data related to email
events and newsletters. It affects several files in the
`ghost/admin/app`, `ghost/core/core`, and `ghost/members-api`
directories.
2023-05-04 14:47:04 +02:00
..
adapters
authenticators
components Cleaned up suppressionList feature flag (#16736) 2023-05-04 14:47:04 +02:00
controllers Cleaned up suppressionList feature flag (#16736) 2023-05-04 14:47:04 +02:00
decorators
errors
helpers Cleaned up suppressionList feature flag (#16736) 2023-05-04 14:47:04 +02:00
initializers Resolved ember-simple-auth deprecations 2022-01-22 00:30:56 +00:00
instance-initializers
mixins
models
modifiers
routes 🐛 Fixed members breadcrumbs when not coming from analytics 2023-05-04 11:20:33 +02:00
serializers
services Cleaned up suppressionList feature flag (#16736) 2023-05-04 14:47:04 +02:00
session-stores
styles 🐛 Fixed CMD/shift clicking to open the editor in a new tab/window 2023-05-03 17:02:26 +02:00
templates 🐛 Fixed members breadcrumbs when not coming from analytics 2023-05-04 11:20:33 +02:00
transforms
transitions
utils
validators
app.js
index.html
README.md
router.js
transitions.js

Ghost Admin App

Ember.js application used as a client-side admin for the Ghost blogging platform. This readme is a work in progress guide aimed at explaining the specific nuances of the Ghost Ember app to contributors whose main focus is on this side of things.

CSS

We use pure CSS, which is pre-processed for backwards compatibility by Myth. We do not follow any strict CSS framework, however our general style is pretty similar to BEM.

Styles are primarily broken up into 4 main categories:

  • Patterns - are base level visual styles for HTML elements (eg. Buttons)
  • Components - are groups of patterns used to create a UI component (eg. Modals)
  • Layouts - are groups of components used to create application screens (eg. Settings)

All of these separate files are subsequently imported and compiled in app.css.

Front End Standards

  • 4 spaces for HTML & CSS indentation. Never tabs.
  • Double quotes only, never single quotes.
  • Use tags and elements appropriate for an HTML5 doctype (including self-closing tags)
  • Adhere to the Recess CSS property order.
  • Always a space after a property's colon (.e.g, display: block; and not display:block;).
  • End all lines with a semi-colon.
  • For multiple, comma-separated selectors, place each selector on its own line.
  • Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per Slightly Obtrusive JavaSript
  • Avoid over-nesting CSS. Never nest more than 3 levels deep.
  • Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)