6ff17c78a2
no issue - added appRoot to config-loader.js - modified uploader to use correct path - modified tests
203 lines
8.2 KiB
JavaScript
203 lines
8.2 KiB
JavaScript
/*globals describe, beforeEach, it*/
|
|
var testUtils = require('./testUtils'),
|
|
should = require('should'),
|
|
sinon = require('sinon'),
|
|
when = require('when'),
|
|
fs = require('fs-extra'),
|
|
path = require('path'),
|
|
appRoot = path.resolve(__dirname, '../../../'),
|
|
|
|
// Stuff we are testing
|
|
admin = require('../../server/controllers/admin');
|
|
|
|
describe('Admin Controller', function() {
|
|
describe('uploader', function() {
|
|
|
|
var req;
|
|
var res;
|
|
|
|
beforeEach(function() {
|
|
req = {
|
|
files: {
|
|
uploadimage: {
|
|
path: "/tmp/TMPFILEID"
|
|
}
|
|
}
|
|
};
|
|
|
|
res = {
|
|
send: function(){}
|
|
};
|
|
});
|
|
|
|
describe('can not upload invalid file', function() {
|
|
it('should return 404 for invalid file type', function() {
|
|
res.send = sinon.stub();
|
|
req.files.uploadimage.name = 'INVALID.FILE';
|
|
req.files.uploadimage.type = 'application/octet-stream'
|
|
admin.uploader(req, res);
|
|
res.send.calledOnce.should.be.true;
|
|
res.send.args[0][0].should.equal(404);
|
|
res.send.args[0][1].should.equal('Invalid filetype');
|
|
});
|
|
});
|
|
|
|
describe('can not upload file with valid extension but invalid type', function() {
|
|
it('should return 404 for invalid file type', function() {
|
|
res.send = sinon.stub();
|
|
req.files.uploadimage.name = 'INVALID.jpg';
|
|
req.files.uploadimage.type = 'application/octet-stream'
|
|
admin.uploader(req, res);
|
|
res.send.calledOnce.should.be.true;
|
|
res.send.args[0][0].should.equal(404);
|
|
res.send.args[0][1].should.equal('Invalid filetype');
|
|
});
|
|
});
|
|
|
|
describe('valid file', function() {
|
|
|
|
var clock;
|
|
|
|
beforeEach(function() {
|
|
req.files.uploadimage.name = 'IMAGE.jpg';
|
|
req.files.uploadimage.type = 'image/jpeg';
|
|
sinon.stub(fs, 'mkdirs').yields();
|
|
sinon.stub(fs, 'copy').yields();
|
|
sinon.stub(fs, 'unlink').yields();
|
|
sinon.stub(fs, 'exists').yields(false);
|
|
});
|
|
|
|
afterEach(function() {
|
|
fs.mkdirs.restore();
|
|
fs.copy.restore();
|
|
fs.unlink.restore();
|
|
fs.exists.restore();
|
|
clock.restore();
|
|
});
|
|
|
|
it('can upload jpg', function(done) {
|
|
clock = sinon.useFakeTimers(42);
|
|
sinon.stub(res, 'send', function(data) {
|
|
data.should.not.equal(404);
|
|
return done();
|
|
});
|
|
|
|
admin.uploader(req, res);
|
|
});
|
|
|
|
it('can upload jpg with incorrect extension', function(done) {
|
|
req.files.uploadimage.name = 'IMAGE.xjpg';
|
|
clock = sinon.useFakeTimers(42);
|
|
sinon.stub(res, 'send', function(data) {
|
|
data.should.not.equal(404);
|
|
return done();
|
|
});
|
|
|
|
admin.uploader(req, res);
|
|
});
|
|
|
|
it('can upload png', function(done) {
|
|
req.files.uploadimage.name = 'IMAGE.png';
|
|
req.files.uploadimage.type = 'image/png';
|
|
clock = sinon.useFakeTimers(42);
|
|
sinon.stub(res, 'send', function(data) {
|
|
data.should.not.equal(404);
|
|
return done();
|
|
});
|
|
|
|
admin.uploader(req, res);
|
|
});
|
|
|
|
it('can upload gif', function(done) {
|
|
req.files.uploadimage.name = 'IMAGE.gif';
|
|
req.files.uploadimage.type = 'image/gif';
|
|
clock = sinon.useFakeTimers(42);
|
|
sinon.stub(res, 'send', function(data) {
|
|
data.should.not.equal(404);
|
|
return done();
|
|
});
|
|
|
|
admin.uploader(req, res);
|
|
});
|
|
|
|
it('should send correct path to image when today is in Sep 2013', function(done) {
|
|
// Sat Sep 07 2013 21:24
|
|
clock = sinon.useFakeTimers(new Date(2013, 8, 7, 21, 24).getTime());
|
|
sinon.stub(res, 'send', function(data) {
|
|
data.should.equal('/content/images/2013/Sep/IMAGE.jpg');
|
|
return done();
|
|
});
|
|
|
|
return admin.uploader(req, res);
|
|
});
|
|
|
|
it('should send correct path to image when today is in Jan 2014', function(done) {
|
|
// Jan 1 2014 12:00
|
|
clock = sinon.useFakeTimers(new Date(2014, 0, 1, 12).getTime());
|
|
sinon.stub(res, 'send', function(data) {
|
|
data.should.equal('/content/images/2014/Jan/IMAGE.jpg');
|
|
return done();
|
|
});
|
|
|
|
admin.uploader(req, res);
|
|
});
|
|
|
|
it('can upload two different images with the same name without overwriting the first', function(done) {
|
|
// Sun Sep 08 2013 10:57
|
|
clock = sinon.useFakeTimers(new Date(2013, 8, 8, 10, 57).getTime());
|
|
fs.exists.withArgs(path.join(appRoot, 'content/images/2013/Sep/IMAGE.jpg')).yields(true);
|
|
fs.exists.withArgs(path.join(appRoot, 'content/images/2013/Sep/IMAGE-1.jpg')).yields(false);
|
|
|
|
// if on windows need to setup with back slashes
|
|
// doesn't hurt for the test to cope with both
|
|
fs.exists.withArgs(path.join(appRoot, 'content\\images\\2013\\Sep\\IMAGE.jpg')).yields(true);
|
|
fs.exists.withArgs(path.join(appRoot, 'content\\images\\2013\\Sep\\IMAGE-1.jpg')).yields(false);
|
|
|
|
sinon.stub(res, 'send', function(data) {
|
|
data.should.equal('/content/images/2013/Sep/IMAGE-1.jpg');
|
|
return done();
|
|
});
|
|
|
|
return admin.uploader(req, res);
|
|
});
|
|
|
|
it('can upload five different images with the same name without overwriting the first', function(done) {
|
|
// Sun Sep 08 2013 10:57
|
|
clock = sinon.useFakeTimers(new Date(2013, 8, 8, 10, 57).getTime());
|
|
fs.exists.withArgs(path.join(appRoot, 'content/images/2013/Sep/IMAGE.jpg')).yields(true);
|
|
fs.exists.withArgs(path.join(appRoot, 'content/images/2013/Sep/IMAGE-1.jpg')).yields(true);
|
|
fs.exists.withArgs(path.join(appRoot, 'content/images/2013/Sep/IMAGE-2.jpg')).yields(true);
|
|
fs.exists.withArgs(path.join(appRoot, 'content/images/2013/Sep/IMAGE-3.jpg')).yields(true);
|
|
fs.exists.withArgs(path.join(appRoot, 'content/images/2013/Sep/IMAGE-4.jpg')).yields(false);
|
|
|
|
// windows setup
|
|
fs.exists.withArgs(path.join(appRoot, 'content\\images\\2013\\Sep\\IMAGE.jpg')).yields(true);
|
|
fs.exists.withArgs(path.join(appRoot, 'content\\images\\2013\\Sep\\IMAGE-1.jpg')).yields(true);
|
|
fs.exists.withArgs(path.join(appRoot, 'content\\images\\2013\\Sep\\IMAGE-2.jpg')).yields(true);
|
|
fs.exists.withArgs(path.join(appRoot, 'content\\images\\2013\\Sep\\IMAGE-3.jpg')).yields(true);
|
|
fs.exists.withArgs(path.join(appRoot, 'content\\images\\2013\\Sep\\IMAGE-4.jpg')).yields(false);
|
|
|
|
sinon.stub(res, 'send', function(data) {
|
|
data.should.equal('/content/images/2013/Sep/IMAGE-4.jpg');
|
|
return done();
|
|
});
|
|
|
|
return admin.uploader(req, res);
|
|
});
|
|
|
|
it('should not leave temporary file when uploading', function(done) {
|
|
// Sun Sep 08 2013 10:57
|
|
clock = sinon.useFakeTimers(new Date(2013, 8, 8, 10, 57).getTime());
|
|
sinon.stub(res, 'send', function(data) {
|
|
fs.unlink.calledOnce.should.be.true;
|
|
fs.unlink.args[0][0].should.equal('/tmp/TMPFILEID');
|
|
return done();
|
|
});
|
|
|
|
admin.uploader(req, res);
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|