060d791a63
no issue
The `settings` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.
- removed use of `ProxyMixin` in the `settings` service by grabbing the attributes off the setting model after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to the model's getters/setters. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `settings.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed use of observer in the `customViews` service because it was being set up before the native properties had been added on the settings service meaning autotracking wasn't able to set up properly
66 lines
1.9 KiB
JavaScript
66 lines
1.9 KiB
JavaScript
import Component from '@glimmer/component';
|
|
import validator from 'validator';
|
|
import {action} from '@ember/object';
|
|
|
|
export default class GhFacebookUrlInput extends Component {
|
|
get value() {
|
|
const {model, modelProperty, scratchValue} = this.args;
|
|
return scratchValue || model[modelProperty];
|
|
}
|
|
|
|
@action
|
|
setScratchValue(event) {
|
|
this.args.setScratchValue?.(event.target.value);
|
|
}
|
|
|
|
@action
|
|
setFacebookUrl(event) {
|
|
const {model, modelProperty} = this.args;
|
|
|
|
let newUrl = event.target.value;
|
|
|
|
// reset errors and validation
|
|
model.errors.remove('facebook');
|
|
model.hasValidated.removeObject('facebook');
|
|
|
|
if (!newUrl) {
|
|
// Clear out the Facebook url
|
|
model[modelProperty] = null;
|
|
this.args.setScratchValue?.(null);
|
|
return;
|
|
}
|
|
|
|
try {
|
|
// strip any facebook URLs out
|
|
newUrl = newUrl.replace(/(https?:\/\/)?(www\.)?facebook\.com/i, '');
|
|
|
|
// don't allow any non-facebook urls
|
|
if (newUrl.match(/^(http|\/\/)/i)) {
|
|
throw 'invalid url';
|
|
}
|
|
|
|
// strip leading / if we have one then concat to full facebook URL
|
|
newUrl = newUrl.replace(/^\//, '');
|
|
newUrl = `https://www.facebook.com/${newUrl}`;
|
|
|
|
// don't allow URL if it's not valid
|
|
if (!validator.isURL(newUrl)) {
|
|
throw 'invalid url';
|
|
}
|
|
|
|
model[modelProperty] = newUrl;
|
|
this.args.setScratchValue?.(null);
|
|
} catch (e) {
|
|
if (e === 'invalid url') {
|
|
const message = 'The URL must be in a format like https://www.facebook.com/yourPage';
|
|
model.errors.add('facebook', message);
|
|
return;
|
|
}
|
|
|
|
throw e;
|
|
} finally {
|
|
model.hasValidated.pushObject('facebook');
|
|
}
|
|
}
|
|
}
|