060d791a63
no issue
The `settings` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.
- removed use of `ProxyMixin` in the `settings` service by grabbing the attributes off the setting model after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to the model's getters/setters. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `settings.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed use of observer in the `customViews` service because it was being set up before the native properties had been added on the settings service meaning autotracking wasn't able to set up properly
|
||
|---|---|---|
| .. | ||
| action.js | ||
| api-key.js | ||
| base.js | ||
| custom-theme-setting-list.js | ||
| custom-theme-setting.js | ||
| email.js | ||
| integration.js | ||
| invite.js | ||
| label.js | ||
| member-subscription.js | ||
| member-tier.js | ||
| member.js | ||
| navigation-item.js | ||
| newsletter.js | ||
| notification.js | ||
| offer.js | ||
| page.js | ||
| post.js | ||
| role.js | ||
| setting.js | ||
| snippet.js | ||
| tag.js | ||
| theme.js | ||
| tier-benefit-item.js | ||
| tier.js | ||
| user.js | ||
| webhook.js | ||