060d791a63
no issue
The `settings` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.
- removed use of `ProxyMixin` in the `settings` service by grabbing the attributes off the setting model after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to the model's getters/setters. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `settings.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed use of observer in the `customViews` service because it was being set up before the native properties had been added on the settings service meaning autotracking wasn't able to set up properly
|
||
|---|---|---|
| .. | ||
| adapter-manager | ||
| admin | ||
| api-framework | ||
| api-version-compatibility-service | ||
| bootstrap-socket | ||
| constants | ||
| core | ||
| custom-theme-settings-service | ||
| domain-events | ||
| email-analytics-provider-mailgun | ||
| email-analytics-service | ||
| email-content-generator | ||
| express-dynamic-redirects | ||
| extract-api-key | ||
| html-to-plaintext | ||
| job-manager | ||
| link-redirects | ||
| link-replacer | ||
| link-tracking | ||
| magic-link | ||
| mailgun-client | ||
| member-analytics-service | ||
| member-attribution | ||
| member-events | ||
| members-analytics-ingress | ||
| members-api | ||
| members-csv | ||
| members-events-service | ||
| members-importer | ||
| members-ssr | ||
| minifier | ||
| mw-api-version-mismatch | ||
| mw-cache-control | ||
| mw-error-handler | ||
| mw-session-from-token | ||
| mw-update-user-last-seen | ||
| mw-vhost | ||
| oembed-service | ||
| offers | ||
| package-json | ||
| payments | ||
| portal | ||
| referrers | ||
| security | ||
| session-service | ||
| settings-path-manager | ||
| staff-service | ||
| stats-service | ||
| stripe | ||
| update-check-service | ||
| verification-trigger | ||
| version-notifications-data-service | ||