Ghost/ghost/admin/app/components/gh-editor-post-status.js
Kevin Ansfield 060d791a63 Removed need for .get() with settings service
no issue

The `settings` service has been a source of confusion when writing with modern Ember patterns because it's use of the deprecated `ProxyMixin` forced all property access/setting to go via `.get()` and `.set()` whereas the rest of the system has mostly (there are a few other uses of ProxyObjects remaining) eliminated the use of the non-native get/set methods.

- removed use of `ProxyMixin` in the `settings` service by grabbing the attributes off the setting model after fetching and using `Object.defineProperty()` to add native getters/setters that pass through to the model's getters/setters. Ember's autotracking automatically works across the native getters/setters so we can then use the service as if it was any other native object
- updated all code to use `settings.{attrName}` directly for getting/setting instead of `.get()` and `.set()`
- removed use of observer in the `customViews` service because it was being set up before the native properties had been added on the settings service meaning autotracking wasn't able to set up properly
2022-10-07 16:14:57 +01:00

59 lines
1.6 KiB
JavaScript

import Component from '@glimmer/component';
import config from 'ghost-admin/config/environment';
import {action, get} from '@ember/object';
import {formatPostTime} from 'ghost-admin/helpers/gh-format-post-time';
import {inject as service} from '@ember/service';
import {task, timeout} from 'ember-concurrency';
import {tracked} from '@glimmer/tracking';
export default class GhEditorPostStatusComponent extends Component {
@service clock;
@service settings;
@tracked isHovered = false;
@tracked _isSaving = false;
// this.args.isSaving will only be true briefly whilst the post is saving,
// we want to ensure that the "Saving..." message is shown for at least
// a few seconds so that it's noticeable so we use autotracking to trigger
// a task that sets _isSaving to true for 3 seconds
get isSaving() {
if (this.args.isSaving) {
this.showSavingMessage.perform();
}
return this._isSaving;
}
get scheduledTime() {
// force a recompute every second
get(this.clock, 'second');
return formatPostTime(
this.args.post.publishedAtUTC,
{timezone: this.settings.timezone, scheduled: true}
);
}
@action
onMouseover() {
this.isHovered = true;
}
@action
onMouseleave() {
this.isHovered = false;
}
@task({drop: true})
*showSavingMessage() {
this._isSaving = true;
yield timeout(config.environment === 'test' ? 0 : 3000);
if (!this.isDestroyed && !this.isDestroying) {
this._isSaving = false;
}
}
}