OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,644 Commits 179 Branches 1,654 Tags 486 MiB
8cc4c6c4a1
Commit Graph

797 Commits

Author SHA1 Message Date
Kevin Ansfield
8cc4c6c4a1 Dropped ember-concurrency-decorators dependency 
no issue

- since `ember-concurrency@2.0` it's possible to use the standard imports as decorators removing the need for the extra `ember-concurrency-decorators` dependency and imports
 2022-02-09 10:49:38 +00:00
Gabriel Csapo
f75d88cb2c [chore] migrates koenig-editor files to native classes (#2251) 
refs https://github.com/TryGhost/Ghost/issues/14101

- continuing migration to native classes with use of `@classic` decorator
 2022-02-09 09:19:45 +00:00
Kevin Ansfield
c55084eeb4 🐛 Fixed Ctrl+Enter-to-edit keyboard shortcut not working on Windows for some editor cards 
no issue

- Callout, Email, Email CTA, Header, Product, and Toggle cards all had the same typo in the Ctrl/Cmd+Enter keyboard handling
 2022-02-07 16:55:01 +00:00
Kevin Ansfield
c44766e8d3 Collapsed @service injection definitions to single-line style 
no issue

- find+replace to make service injection style consistent and take up much less space at the top of files that used multi-line syntax
 2022-02-03 19:04:43 +00:00
Kevin Ansfield
1be7dd1770 Ran native classes codemod for lib/koenig-editor/addon/components 
refs https://github.com/TryGhost/Ghost/issues/14101

- ran native classes codemod for koenig-editor in-repo-addon components
- added `ember-classic-decorator` to addon's package.json to fix errors when importing

Some files failed to convert automatically:
```
❯ grep -rL "@classic\|default class" lib/koenig-editor/addon/components/**/*.js
lib/koenig-editor/addon/components/koenig-alt-input.js
lib/koenig-editor/addon/components/koenig-card-image.js
lib/koenig-editor/addon/components/koenig-editor.js
lib/koenig-editor/addon/components/koenig-toolbar.js
```
 2022-02-03 18:57:21 +00:00
Gabriel Csapo
f22a758a3b [chore] run the no-implicit-this codemod (#2244) 
refs https://github.com/TryGhost/Admin/pull/2238

Follow up to #2238, this should remove the existing no-implicit-this lint errors and any new violations should be flagged right away.

* run the no-implicit-this codemod
* updated todos
 2022-02-02 17:09:02 +00:00
Kevin Ansfield
5e7c98fb46 Fixed template linting error in koenig-card-email.hbs 
refs cc257f8576

- template change triggered a linting rule
- fixed and ran `yarn lint:hbs --update-todo`
 2022-02-02 16:48:09 +00:00
Kevin Ansfield
cc257f8576 Fixed noreferer typos 
no issue

- should be `noreferrer`, caused duplication by ember-template-lint auto fixing
 2022-02-02 16:20:01 +00:00
Gabriel Csapo
beb5ae1737 [chore] adds ember-template-lint and fixes all fixable issues (#2238) 
no issue

- This will help with the octane migration and you can still run the lint rules even when they are todos. (Checkout the docs at 158b119667/docs/todos.md) The good news is any new code will be checked against the recommended config.
- I fixed all the auto fixable things we could get in this PR as well
 2022-02-02 16:09:43 +00:00
Kevin Ansfield
c9aa43e5a5 Added infobox to matches list for callout card 
no issue

- extra term for matching the callout card so you can start typing `/infobox` and get the card you were looking for
 2022-01-31 13:46:07 +00:00
Kevin Ansfield
fa4f8221d5 🎨 Made /-menu card searching case-insensitive 
no issue

- allows typing "Button" to match the "button" card
- useful on mobile where words can be auto-capitalized
 2022-01-31 13:37:25 +00:00
Kevin Ansfield
e0fa64a56b 🐛 Fixed editor cards not being usable by contributors 
no issue

- a recent Ember upgrade has slightly changed behaviour for template conditionals meaning helpers used in the right-hand side of a conditional can be called when the conditional evaluates to falsy
- this caused an error to be thrown by the editor when creating cards as a contributor because the `{{fn}}` helper is called with a null/undefined `saveCardAsSnippetIfPossible` function which will throw an error
- wrapped the function in the `{{optional}}` helper (https://github.com/DockYard/ember-composable-helpers#optional) which will return a "noop" function allowing the template to evaluate without errors
 2022-01-31 13:28:26 +00:00
Peter Zimon
3a3b2f7fb4 Remove alpha flag for Editor settings panel (#2230) 2022-01-31 13:33:59 +01:00
Kevin Ansfield
f56b52b8a1 Cleaned up headerCard labs flag 
refs https://github.com/TryGhost/Team/issues/1258

- removed labs flag and conditionals as feature is GA
 2022-01-04 14:58:19 +00:00
Kevin Ansfield
8e9748131c Cleaned up fileCard labs flag 
refs https://github.com/TryGhost/Team/issues/1258

- removed labs flag and conditionals as feature is GA
 2022-01-04 14:57:01 +00:00
Kevin Ansfield
6c18628b8b Cleaned up audioCard labs flag 
refs https://github.com/TryGhost/Team/issues/1258

- removed labs flag and conditionals
 2022-01-04 13:08:50 +00:00
Kevin Ansfield
b8b40fafef Cleaned up productCard labs flag 
refs https://github.com/TryGhost/Team/issues/1258

- removed labs flag and conditionals
 2022-01-04 13:04:26 +00:00
Kevin Ansfield
aeb0cb60e8 Cleaned up accordionCard labs flag 
refs https://github.com/TryGhost/Team/issues/1258

- removed labs flag and conditionals
 2022-01-04 13:03:08 +00:00
Kevin Ansfield
a9a82107ed Cleaned up videoCard labs flag 
refs https://github.com/TryGhost/Team/issues/1258

- removed labs flag and conditionals
 2022-01-04 12:57:42 +00:00
Kevin Ansfield
7a270de050 Cleaned up calloutCard labs flag 
refs https://github.com/TryGhost/Team/issues/1258

- removed labs flag and conditionals
 2022-01-04 12:56:25 +00:00
Kevin Ansfield
0fcf89b1fa Cleaned up nftCard labs flag 
refs https://github.com/TryGhost/Team/issues/1258

- removed labs flag and conditionals
 2022-01-04 12:55:04 +00:00
Kevin Ansfield
99e2db76dc 🐛 Fixed Spotify and Soundcloud embeds having overly long containers in editor 
closes https://github.com/TryGhost/Team/issues/871

- when determining the size of the iframe containing a nested iframe in the embed card we were incorrectly treating a `100%` width attribute as a `100px` attribute and ending up with a completely incorrect ratio calculation
- added a conditional to ignore %-width attributes when calculating a ratio for a nested iframe
- if we have a nested iframe with a %-width but a fixed height, use that fixed height for the outer container iframe
 2022-01-04 10:00:21 +00:00
Kevin Ansfield
85ac9f0826 Removed unnecessary koenig-media-selector-tenor export file 
no issue

- the associated addon component was deleted a while back but the app export file was missed
 2022-01-04 09:29:24 +00:00
Thibaut Patel
5056401c13 Renamed the header styles 
refs https://github.com/TryGhost/Team/issues/1253

- The naming is easier to understand for theme developers
 2021-12-16 18:22:08 +01:00
Peter Zimon
b6da19df65 Updated header card placeholders 2021-12-16 16:11:50 +01:00
James Morris
dcb5d2ad0a Fixed a merge with the header card settings 
refs https://github.com/TryGhost/Team/issues/1253
 2021-12-16 14:39:50 +00:00
Thibaut Patel
05af5cdcd4 Removed width and alignment configuration from the header card 
refs https://github.com/TryGhost/Team/issues/1253

- We're simplifying the header card from a design point of view to ease integration with themes
 2021-12-16 15:10:57 +01:00
Peter Zimon
c4c728d7a1 Refined header image styles 2021-12-16 12:59:03 +01:00
Peter Zimon
c4b4a6b2a4 Put back header style options 2021-12-16 12:26:15 +01:00
Peter Zimon
9afb0c7a94 Updated style picker for header 2021-12-16 12:25:01 +01:00
Thibaut Patel
1e16b92f52 Updated the header card file selector 
refs https://github.com/TryGhost/Team/issues/1253

- Selecting the `image` style opens the file selector right away
- Avoids an extra click to the user
- Moved `GhFileInput` so that it's always rendered, which enables triggering it right when selecting the `image` style
 2021-12-16 11:09:14 +01:00
Peter Zimon
d33ef9944e Added 'upload' term to file card menu access 2021-12-16 10:08:44 +01:00
Sanne de Vries
21a1b3a1aa 🐛 Fixed audio file duration missing digit in editor 
Closes https://github.com/TryGhost/Ghost/issues/13894
 2021-12-16 09:17:45 +01:00
Naz
575623f5be Added support for additional wav MIME types 
refs f882ebc58e
refs https://github.com/TryGhost/Toolbox/issues/95

- The `audio/x-wav`, `audio/wav`, and `audio/wave` are also commonly used MIME types for the .wav files.
 2021-12-16 11:11:43 +04:00
James Morris
47e77ddcdc Little tweaks for header settings panel and added add icon 
refs https://github.com/TryGhost/Team/issues/1253
 2021-12-15 19:09:17 +00:00
djordje vlaisavljevic
ffc22f520a Updated before/after card editor template 
refs https://github.com/TryGhost/Team/issues/1249
 2021-12-15 20:06:00 +01:00
djordje vlaisavljevic
2a19d3bb74 Updated before/after card editor template 
refs https://github.com/TryGhost/Team/issues/1249
 2021-12-15 20:03:03 +01:00
Fabien egg O'Carroll
ee410a08c1 Updated slider for before/after to match frontend 
refs https://github.com/TryGhost/Team/issues/1249

Adds a new element to use as the slider handle to match how we're doing
it in the frontend
 2021-12-15 20:27:39 +02:00
Thibaut Patel
6d8fc32d77 Updated the header card 
refs https://github.com/TryGhost/Team/issues/1253

- added a default `cardWidth`
 2021-12-15 18:28:41 +01:00
Thibaut Patel
1db6e175fd Updated the header card 
refs https://github.com/TryGhost/Team/issues/1253

- removed the accent class in the edit mode
 2021-12-15 18:26:47 +01:00
Thibaut Patel
1194a553e8 Updated the header card 
refs https://github.com/TryGhost/Team/issues/1253

- added the card width back (only regular or full options)
- removed the accent class from the button
- fixed a bug happening when the subheader was empty
 2021-12-15 18:25:05 +01:00
Peter Zimon
4f005f0ef5 Updated file card Koenig styles 2021-12-15 17:45:04 +01:00
djordje vlaisavljevic
49df6dde1b Added icon for before/after card 
refs https://github.com/TryGhost/Team/issues/1249
 2021-12-15 16:23:35 +01:00
djordje vlaisavljevic
ac33996c08 Updated editor styles for before/after card 
refs https://github.com/TryGhost/Team/issues/1249
 2021-12-15 11:10:05 +01:00
Fabien egg O'Carroll
cb24aa1914 Added replace image functionality 
refs https://github.com/TryGhost/Team/issues/1249

This can resuse the image selection as after a successful upload the
image is replaced.
 2021-12-15 12:06:46 +02:00
Thibaut Patel
e1bbc63bb3 Updated header card class names 
refs https://github.com/TryGhost/Team/issues/1253
 2021-12-15 10:02:17 +01:00
Fabien egg O'Carroll
804da37926 Removed requirement for matchign aspect ratio 
refs https://github.com/TryGhost/Team/issues/1249

Based on design feedback so that users are able to use the card with
less friciton.
 2021-12-15 10:35:38 +02:00
djordje vlaisavljevic
1d19f74ba8 Updated editor styles for before/after card 
refs https://github.com/TryGhost/Team/issues/1249
 2021-12-15 09:32:09 +01:00
Sanne de Vries
b640a023f7 Refined video card in editor 
Refs https://github.com/TryGhost/Team/issues/1229

- Fixed glitch on load
- Fixed error state
- Hid custom thumbnail when video is looped
 2021-12-14 19:49:29 +01:00
Peter Zimon
526c92bad7 Refined file Koenig styles 2021-12-14 17:55:27 +01:00