Ghost

Author SHA1 Message Date

Author	SHA1	Message	Date
Tim Birkett	2e21618290	Set Ghost user-agent header for got requests (#10424 ) no-issue Currently the `user-agent` header is the for outgoing webhook calls is the `got` default: `User-Agent: got/8.3.2 (https://github.com/sindresorhus/got)`. This is pretty unfriendly to the receiver of the webhook who may wish to perform analytics on calling systems, implement security features based on calling system or take action based on different versions of a client. This PR sets the header to: `User-Agent: Ghost/2.12.0 (https://github.com/TryGhost/Ghost)` which is much more descriptive.	2019-01-28 17:01:34 +01:00
Aileen Nowak	ae741b1a18	Removed bluebird promise wrap in request lib (#9343 ) refs #9178, refs #8988 With `7353c87d7f` we use Bluebird globally for Promises. Therefore, the request lib doesn't need to be wrapped in a bluebird Promise anymore. This was originally done, so we can work with catch predicated in our image-size lib. Updated the tests to proof, that the catch predicates work. The tests fail, as soon as the Promise overwrite is commented out.	2018-01-02 12:18:56 +01:00
kirrg001	7460076206	Moved request to lib/request refs #9178 - next steps are to A: test if global.Promise works with `got` (see https://github.com/TryGhost/Ghost/pull/8988#issuecomment-351532881) B: re-use request utility everywhere C: request lib requires data/validator, which is dirty	2017-12-13 22:37:42 +01:00

Tim Birkett

2e21618290

Set Ghost user-agent header for got requests (#10424 )

no-issue

Currently the `user-agent` header is the for outgoing webhook calls is the `got` default: `User-Agent: got/8.3.2 (https://github.com/sindresorhus/got)`.

This is pretty unfriendly to the receiver of the webhook who may wish to perform analytics on calling systems, implement security features based on calling system or take action based on different versions of a client.

This PR sets the header to: `User-Agent: Ghost/2.12.0 (https://github.com/TryGhost/Ghost)` which is much more descriptive.

2019-01-28 17:01:34 +01:00

Aileen Nowak

ae741b1a18

Removed bluebird promise wrap in request lib (#9343 )

refs #9178, refs #8988

With 7353c87d7f we use Bluebird globally for Promises. Therefore, the request lib doesn't need to be wrapped in a bluebird Promise anymore.

This was originally done, so we can work with catch predicated in our image-size lib.

Updated the tests to proof, that the catch predicates work.

The tests fail, as soon as the Promise overwrite is commented out.

2018-01-02 12:18:56 +01:00

kirrg001

7460076206

Moved request to lib/request

refs #9178

- next steps are to
  A: test if global.Promise works with `got` (see https://github.com/TryGhost/Ghost/pull/8988#issuecomment-351532881)
  B: re-use request utility everywhere
  C: request lib requires data/validator, which is dirty

2017-12-13 22:37:42 +01:00

3 Commits