Commit Graph

12 Commits

Author SHA1 Message Date
Fabien "egg" O'Carroll
104f84f252 Added eslint rule for file naming convention
As discussed with the product team we want to enforce kebab-case file names for
all files, with the exception of files which export a single class, in which
case they should be PascalCase and reflect the class which they export.

This will help find classes faster, and should push better naming for them too.

Some files and packages have been excluded from this linting, specifically when
a library or framework depends on the naming of a file for the functionality
e.g. Ember, knex-migrator, adapter-manager
2023-05-09 12:34:34 -04:00
Simon Backx
db717f446f 🐛 Fixed free trials not visible in paid subscriptions graph
fixes https://github.com/TryGhost/Team/issues/2607

When a free trial converts to a paid subscription, and increases the MRR, it just creates a 'updated' paid subscription event.

To fix this, we need to count updated events that didn't change plan but do have a positive MRR. As an extension we could also check if the MRR change matches the expected MRR for the corresponsing Stripe plan, but that requires a more complex condition check (because for yearly subscriptions we need to convert to monthly), I don't think that is required here.
2023-03-10 16:16:17 +01:00
Simon Backx
400e1b4ab6 🐛 Fixed 3D secure payment not counted as paid subscription in graph
fixes https://github.com/TryGhost/Team/issues/2644

A 3D secure payment first has a status of incomplete, then active.

With the current logic, this creates 2 MemberPaidSubscriptionEvents:

- `created` with mrr_delta of 0
- `active` with mrr_delta of 5

We need to also count 'active' events. And to complement that, also 'inactive' events to make sure we balance out in rare cases.
2023-03-10 16:16:17 +01:00
Rishabh Garg
45a301277d
Updated empty referrer source to null (#15456)
refs https://github.com/TryGhost/Team/issues/1939

- changes empty referrer source to null instead of explicit `Unavailable` in API
- makes it easier for clients/frontend to ignore empty referrers
2022-09-22 20:58:45 +05:30
Rishabh Garg
b048b02f67
Added new referrer source stats API (#15449)
closes https://github.com/TryGhost/Team/issues/1939

- adds new endpoint that returns count of referrer sources by date for admin dashboard
2022-09-22 16:34:26 +05:30
Simon Backx
7437d92d50
Added post referrers stats API (#15448)
closes https://github.com/TryGhost/Team/issues/1942

- Added data fixtures for referrers
- Added new endpoint to fetch referrer stats for a given post: `/stats/referrers/posts/:id`
- Added new ReferrersStatsService, responsible for calculating referrer stats
2022-09-21 18:16:56 +02:00
Simon Backx
51e3b0ac11 Added separate signups and cancellations to subscriptions stats
refs https://github.com/TryGhost/Team/issues/1673

- We don't want to show updated subscriptions in the dashboard
- We need to send add fields to accomplish this
- Includes updated tests
2022-07-13 12:20:50 +02:00
Fabien 'egg' O'Carroll
c56f281b26 Added missing positive_delta for subscription reactivations (#4)
* Added breaking test for canceled and reactivated events
* Added missing positive_delta for subscription reactivations
2022-05-19 16:59:48 +01:00
Fabien "egg" O'Carroll
b3349a0ee0 Formatted date property as ISO8601
As these are dates we have no need for the timestamp at the end of them,
formatting as ISO8601 works with the rest of our system correctly, for
example in the client where we populate missing dates
2022-04-25 09:50:41 +01:00
Fabien "egg" O'Carroll
8a82bee978 Added metadata to subscriptions count history data
refs https://github.com/TryGhost/Team/issues/1466

We need to include an exhaustive list of tiers and cadences in the
metadata so that clients knows which data to expect, as we have multiple
rows for a single date, broken down by tier/cadence.

We also include the totals broken down by tier/cadence for use with the
paid mix chart.
2022-04-25 09:47:49 +01:00
Fabien 'egg' O'Carroll
2575e10ec4 Added subscription stats service (#2)
refs https://github.com/TryGhost/Team/issues/1505
refs https://github.com/TryGhost/Team/issues/1466

This gives us historic data for subscriptions broken down by tier and cadence

* Cleaned up tests
Fixed up usage of knex, making sure to destroy the connection after tests

* Removed Node 12 from testing matrix
Get outta my pub!
2022-04-21 15:42:02 +01:00
Fabien "egg" O'Carroll
77819d261a Moved Stats Service from Ghost
The functionality hasn't changed this has just moved the code
and updated the tests to provide better coverage
2022-04-21 13:10:33 +01:00