Commit Graph

2503 Commits

Author SHA1 Message Date
Jason Williams
23d630bdc7 Merge pull request #6663 from kevinansfield/fix-xregexp-issues
Drop XRegExp dependency
2016-03-31 10:06:47 -05:00
Kevin Ansfield
adaf15d830 deps: ember-cli@2.4.3
no issue
- https://github.com/ember-cli/ember-cli/releases/tag/v2.4.3
2016-03-31 10:13:15 +01:00
Kevin Ansfield
ed1d6c98b3 Drop XRegExp dependency
closes #6102
- removes the `xregexp` dependency
- pulls in the non-alphnumeric unicode list directly from the XRegExp library to ensure the word count helper still takes into account unicode strings

The XRegExp dependency was breaking as new browsers add more es6 support as evidenced in #6102. Upgrading to version 3.1.0 fixed the Chrome "experimental JS" issue but was still broken in Safari Technology Preview.

We only use one feature of `XRegExp` in a single place for a relatively non-critical feature: calculating the word count. As such I figured it may be better to drop the 63KB minified dependency and simply copy the result of the compiled regex directly until such time as XRegExp has native support in our supported browsers.
2016-03-30 19:45:20 +01:00
Kevin Ansfield
0ca160bfde deps: ember-sinon@0.5.0
no issue
- pulls sinon.js from NPM instead of bower - https://github.com/csantero/ember-sinon/releases/tag/v0.5.0
- only dependency updates and ember-cli changes - https://github.com/csantero/ember-sinon/compare/v0.3.0...v0.5.0
2016-03-29 13:03:59 +01:00
Kevin Ansfield
4d54778405 deps: liquid-tether@1.0.0
no issue
- contains cleanup and test fixes - https://github.com/pzuraq/liquid-tether/compare/v0.1.11...v1.0.0
2016-03-25 09:00:38 +00:00
Kevin Ansfield
c7ea692393 Remove jquery-hammerjs bower dependency
no issue
- removes `jquery-hammerjs` as it doesn't appear to be used anywhere and isn't included in the build by ember-cli
2016-03-24 10:04:52 +00:00
Jason Williams
cf349b3be9 Return http status 204 on deletes
Closes #2871
- Refactor api http handlers.
- Update tests.
- Remove special handling of responses in ember adapter.
2016-03-22 11:42:48 -05:00
Kevin Ansfield
aa4c72901c Merge pull request #6611 from dbalders/ember-navitems
Remove Nav Item Placeholder and Set as Base Url Value
2016-03-22 16:18:28 +01:00
David Balderston
f208892d87 Remove Nav Item Placeholder and Set as Base Url Value
Closes #6440

* Removed the `.fake-placeholder`class from the input, test, and css
* On adding a nav item, if the url value has not been set by the user,
then set it to the base url as shown in the input
* If url has been set by the user, just do what it has always done
2016-03-22 07:11:20 -07:00
king6cong
4296110cde fix invalid preview url 2016-03-22 20:42:46 +08:00
Jason Williams
8848eae531 Merge pull request #6619 from kevinansfield/ember-data-2-4-2
deps: ember-data@2.4.2
2016-03-21 13:31:03 -05:00
Kevin Ansfield
9755c87048 deps: ember-data@2.4.2
no issue
- https://github.com/emberjs/data/releases/tag/v2.4.1
- https://github.com/emberjs/data/releases/tag/v2.4.2
- uses the new public import path for `EmbeddedRecordsMixin` (http://emberjs.com/blog/2016/03/13/ember-data-2-4-released.html#toc_importing-modules - note that the module naming there isn't quite right)
2016-03-21 16:37:42 +00:00
Kevin Ansfield
fb4900086c deps: ember@2.4.3
no issue
- https://github.com/emberjs/ember.js/releases/tag/v2.4.2
- https://github.com/emberjs/ember.js/releases/tag/v2.4.3
2016-03-21 14:10:18 +00:00
Kevin Ansfield
89d5d7c83a deps: ember-cli@2.4.2
no issue
- bugfix release: https://github.com/ember-cli/ember-cli/releases/tag/v2.4.2
2016-03-07 09:17:51 +00:00
Kevin Ansfield
d73847b9f9 deps: ember-cli@2.4.1
no issue
- bugfix release - https://github.com/ember-cli/ember-cli/releases/tag/v2.4.1
2016-03-03 09:17:37 +00:00
Kevin Ansfield
92e71f3555 deps: ember-data@2.4.0 2016-03-01 12:49:43 +00:00
Kevin Ansfield
a8c9bff9d0 deps: ember@2.4.1 2016-03-01 12:49:43 +00:00
Kevin Ansfield
4555ac7c00 deps: ember-cli@2.4.0 2016-03-01 12:49:28 +00:00
Peter Szel
af43bb9267 Fixed bugs regarding the published date input field validation.
refs #5777

- removing error message from the previous validation
- only checking if date is in the past if the input date is valid to begin with
- always updating the view, even if the date hasn't changed to make sure the date format stays consistent
2016-02-28 01:33:24 +00:00
Peter Szel
22e0451af8 Fixed skiplink positioning
refs #5986

- removed static position of the skiplink to prevent pushing the page content down
- only applying :focus CSS selector to focusable sr-only content
2016-02-27 15:37:15 +00:00
Kevin Ansfield
c82df0c881 Merge pull request #6561 from acburdine/test-fixes
Ember client test fixes
2016-02-24 09:36:24 +00:00
Kevin Ansfield
ea3bed5911 Merge pull request #6548 from ErisDS/config-api
Restructure Configuration API endpoint
2016-02-24 09:34:51 +00:00
Austin Burdine
15c8c7af9f various test 🐛 fixes
refs #6550
- cleanup deprecation messages
- fix get `undefined` error in tests
2016-02-23 23:27:57 -06:00
Kevin Ansfield
8813f0dac4 Refactor the feature service
no issue
- removes the unneeded manual caching of the settings object
- fixes multiple API requests to fetch settings when using the feature service
2016-02-23 15:22:32 +00:00
Hannah Wolfe
c331e06975 Restructure Configuration API endpoint
refs #6421, #6525

- The configuration API endpoint was a bit of an animal:
   - It's used currently in two ways, once for general config, another for the about page.
   - These two things are different, and would require different permissions in future.
   - There was also both a browse and a read version, even though only browse was used.
   - The response from the browse was being artificially turned into many objects, when its really just one with multiple keys
- The new version treats each type of config as a different single object with several keys
- The new version therefore only has a 'read' request
- A basic read request with no key will return basic config that any client would need
- A read request with the about key returns the about config
- A read request with a different key could therefore return some other config
2016-02-19 18:49:23 +00:00
Austin Burdine
c2ca564f46 Merge pull request #6546 from quangtt/preview-icon
Fix preview icon position in editor
2016-02-19 11:35:05 -06:00
Austin Burdine
cfdf3dd590 deps: ember-cli-deprecation-workflow@0.1.6
- fixes deprecation error on build
2016-02-19 09:20:17 -06:00
quangtt
1ef8ce9225 Fix preview icon position in editor (updated) 2016-02-19 21:55:04 +07:00
Kevin Ansfield
c53fc00a53 Merge pull request #6518 from acburdine/ember-cli-take-2
Update ember-cli to 2.3.0
2016-02-19 11:56:47 +00:00
Kevin Ansfield
c7a135dda2 Fix new post->tags transition
refs #6483, closes #6541
- removes unloading of all tags when entering the tags screen. Tags list will now function similarly to the content list where already-loaded tags are visible immediately.

Fixes #6483 because it prevents selectize's data being changed out from underneath it before it's destroyed.
2016-02-18 18:01:08 +00:00
Kevin Ansfield
64db2e633e Revert "pass post tags as array to ember-cli-selectize"
This reverts commit 4a17669b04135e24679a72c521ce9bf75ae86ea0.
2016-02-18 17:57:18 +00:00
Kevin Ansfield
0eb8f4be59 Merge pull request #6520 from acburdine/issue-6515
Fix logging out from editor page
2016-02-18 12:36:59 +00:00
Kevin Ansfield
b7e21cb10e Merge pull request #6513 from acburdine/issue-6512
Fix underscore usage in post serializer
2016-02-18 09:30:44 +00:00
Kevin Ansfield
89196e68d3 Merge pull request #6533 from acburdine/issue-6483
Pass post tags as array to ember-cli-selectize
2016-02-18 09:08:09 +00:00
Kevin Ansfield
75cd7221b2 Merge pull request #6531 from acburdine/issue-6530
Inject ajax service in settings/labs
2016-02-18 08:58:12 +00:00
Austin Burdine
7a143a4970 pass post tags as array to ember-cli-selectize
closes #6483
- fix new post => settings/tags transition error
2016-02-17 22:24:16 -06:00
Austin Burdine
1d7f3f4548 inject ajax service in settings/labs
closes #6530
- turns out one must inject a service in order to use it
2016-02-17 14:50:40 -06:00
Austin Burdine
a55cc105c6 add signin acceptance test
refs #6039
2016-02-16 23:08:24 -06:00
Austin Burdine
ccfbf65f7b fix logging out from editor page
closes #6514
- removes transition.abort from the signout method because it can override the ember-simple-auth's page refresh
2016-02-16 20:07:03 -06:00
Austin Burdine
71706160f9 deps: ember-cli-deprecation-workflow@0.1.5 2016-02-16 15:06:32 -06:00
Austin Burdine
cec22372a9 deps: ember-cli@2.3.0 2016-02-16 12:32:48 -06:00
Austin Burdine
8fbaddeda0 fix underscore usage in post serializer
closes #6512
- because of the keyForAttribute method in the application serializer, the hash property must be snake_case
- change the normalize method to the more concise normalizeHash method available on the rest serializer
2016-02-16 09:37:15 -06:00
Kevin Ansfield
ac293db0a2 Merge pull request #6486 from acburdine/code-injection-test
Add settings/code-injection acceptance test
2016-02-15 11:07:01 +00:00
Kevin Ansfield
e0127ac003 Merge pull request #6488 from acburdine/labs-test
Add settings/labs acceptance test
2016-02-15 11:05:29 +00:00
Kevin Ansfield
31b87cb8c4 Merge pull request #6387 from novaugust/post-deletion
Fix post deletion scroll on content and tag screens
2016-02-15 11:02:42 +00:00
Kevin Ansfield
507adb7fc1 Merge pull request #6506 from acburdine/posts-error-fix
Improve 404 error handling in post route
2016-02-15 09:56:34 +00:00
Austin Burdine
215b2f16c7 remove unused modal outlet 2016-02-14 18:55:59 -06:00
Austin Burdine
3fde131f7d improve 404 error handling in post route
closes #6503
- change post route 404 handling to match that of the editor and tag routes
- fix 404 tests
2016-02-14 16:49:57 -06:00
Hannah Wolfe
237a10cd1f Merge pull request #6468 from kevinansfield/ember-sortable-nav-items
Replace jquery-ui.sortable with ember-sortable for nav items
2016-02-14 13:44:07 +00:00
Austin Burdine
c24f700aa1 add settings/labs acceptance test
refs #6039
2016-02-11 09:19:04 -06:00
Austin Burdine
d7d24716e4 add settings/code-injection acceptance test
refs #6039
2016-02-11 09:05:48 -06:00
Austin Burdine
dff72bf430 Add settings/general acceptance test
refs #6039
- adds acceptance tests for settings/general flows
- fixes up mirage settings fixtures
2016-02-11 06:06:38 -06:00
Kevin Ansfield
91f4b84b9b Merge pull request #6207 from acburdine/feature-service
Convert feature controller to service
2016-02-10 09:36:42 +00:00
Kevin Ansfield
e0230adae6 Replace jquery-ui.sortable with ember-sortable for nav items
refs #6458, closes #6457
- replaces jquery-ui.sortable with ember-sortable for drag-n-drop handling
- moves the "new/blank" nav item out of the nav items list
  - allows it to be excluded from the draggable list
  - cleans up handling of the `navigationItems` array as there's no longer a need to ignore/exclude this extra item
- clears validation errors when typing in the respective field
- adds acceptance test for adding/removing nav items
- improves acceptance test for saving nav items to cover more edge cases
2016-02-09 22:08:21 +00:00
Austin Burdine
ca707aa45f cleanup feature service error handling 2016-02-09 13:39:15 -06:00
Matt Enlow
20cbc6c606 Load more posts after post deletion
Closes #6390
- check if more posts should be loaded whenever one is deleted
- delete dead code from posts controller
- delete duplicate component gh-infinite-scroll-box
- simplify posts-list-item `posts.post` or `editor.edit` link logic by modifying `gh-content-view-container` to yield necessary vars directly and use inline ifs in template
- add `gh-tag` component for rendering tags and updating infinite scroll box on `settings/tags` page
2016-02-09 09:08:31 -07:00
Kevin Ansfield
648d0043e2 Continuation of #6207 (convert feature controller to service)
refs #6207, #6207
- updates tests for new async behaviour
- fixes tests failing on validation errors
- fixes `feature.labs` not updating after successful save
2016-02-09 08:37:44 -06:00
Austin Burdine
1e3adef145 convert feature controller to service
closes #6170
- add gh-feature-flag component to create a checkbox (reduce duplicate code)
2016-02-09 08:37:44 -06:00
Hannah Wolfe
af3bc288dc Change URL for download count service
no issue

- we're moving the internal endpoint for fetching counts to count.ghost.org
2016-02-09 10:20:24 +00:00
Kevin Ansfield
4823756e72 deps: ember-sortable@1.7.0 2016-02-09 10:17:37 +00:00
Hannah Wolfe
7a36fd597f Merge pull request #6439 from kevinansfield/fix-nav-validation
Fix navigation item validation behaviour
2016-02-08 20:15:18 +00:00
Kevin Ansfield
781bcaf276 Test client using real browsers on Travis
no issue
- drop phantomjs tests both locally and on Travis
- instruct Travis to install latest Chrome and Firefox
- start an X server when running the client tests on Travis
- update testem config to start Chrome and Firefox in both local and CI tests
- fix testing preview sizing in Firefox as it doesn't support `zoom: 50%` style
- improve infinite scroll testing to be more reliable
- fix post acceptance test to handle both mobile and desktop views
2016-02-08 16:10:40 +00:00
Kevin Ansfield
385036dc48 validate nav items when clicking the + button, ignoring last item if blank 2016-02-08 14:20:57 +00:00
Hannah Wolfe
308bf1731f Merge pull request #6445 from kevinansfield/fix-input-cursor
Return cursor pointer to text inputs
2016-02-08 10:07:29 +00:00
Sebastian Gierlinger
250149bb13 Merge pull request #6444 from kevinansfield/fix-mixed-content-warnings
Fix mixed content security warnings due to gravatar images
2016-02-08 10:03:39 +01:00
Hannah Wolfe
51339f0deb Merge pull request #6447 from kevinansfield/deps-ember-route-action
deps: ember-route-action-helper@0.3.0
2016-02-06 13:34:06 +00:00
Kevin Ansfield
240e29a195 deps: ember-route-action-helper@0.3.0
no issue
- cleans up passing route closure actions down through components and ensures callbacks are wrapped in the runloop - https://github.com/dockyard/ember-route-action-helper/pull/8
2016-02-06 13:09:47 +00:00
Kevin Ansfield
dbd3177e39 Return cursor pointer to text inputs
refs #6412
- moves `cursor: pointer` style introduced in #6412 into more specific classes that only target select boxes rather than all inputs
2016-02-05 17:01:53 +00:00
Kevin Ansfield
cbd9ec358c Fix mixed content security warnings due to gravatar images
no issue
- switches gravatar URL generation to use protocol-relative URLs in `gh-profile-image` component
2016-02-05 16:48:15 +00:00
Hannah Wolfe
6627f38abe Merge pull request #6442 from kevinansfield/ember-2-3-1
deps: ember@2.3.1
2016-02-05 15:45:43 +00:00
Austin Burdine
6199736940 fix 404 acceptance tests 2016-02-05 06:16:29 -06:00
Kevin Ansfield
3e57af2118 deps: ember@2.3.1
no issue

Bugfix release: https://github.com/emberjs/ember.js/releases/tag/v2.3.1
2016-02-05 11:16:49 +00:00
Hannah Wolfe
009b058753 Merge pull request #6438 from kevinansfield/include-babel-polyfill
Include babel polyfill when compiling client
2016-02-04 20:44:02 +00:00
Hannah Wolfe
e766117c75 Merge pull request #6437 from kevinansfield/deps-client
Update client dependencies
2016-02-04 20:40:33 +00:00
Kevin Ansfield
053839df4c Include babel polyfill when compiling client
no issue
- fixes issues when using `phantomjs` or other browsers that are not fully es6 compatible
2016-02-04 12:49:53 +00:00
Kevin Ansfield
6b8ffdc817 deps: liquid-tether@0.1.11 2016-02-04 11:22:08 +00:00
Kevin Ansfield
9b1395d00f deps: liquid-fire@0.23.0 2016-02-04 11:20:11 +00:00
Kevin Ansfield
600b375d4f deps: ember-cli@1.13.15 2016-02-04 10:59:49 +00:00
Kevin Ansfield
7fcb10674f deps: ember-cli-mocha@0.10.0 2016-02-04 10:53:01 +00:00
Kevin Ansfield
a0da484b34 deps: ember-data@2.3.3 2016-02-04 10:32:05 +00:00
Kevin Ansfield
e2f249e534 Merge pull request #6430 from halfdan/6428-add-trailing
Add trailing slashes on relative URL unless [.?#]
2016-02-03 17:36:34 +00:00
Kevin Ansfield
323c9b82e0 Merge pull request #6392 from kevinkucharczyk/post-invalid-id-404
Fix posts.post route not redirecting to 404
2016-02-03 17:04:48 +00:00
Kevin Ansfield
d9e846ae8d Merge pull request #6373 from kevinkucharczyk/standardise-camelcase
Standardise client property names to camelCase
2016-02-03 16:41:23 +00:00
Fabian Becker
da5f6b1f1f Add trailing slashes on relative URL unless [.?#]
closes #6428
2016-02-03 17:11:44 +01:00
Kevin Ansfield
d6eff5180e Use phantomJS 2.1.1 in travis
no issue
- download phantomjs 2.1.1 in Travis' `before_install` step and update the `PATH` export to so the downloaded version is used
- remove the now no-longer needed `ember-cli-es5-shim` dependency
- update documentation references to match new phantomjs version
2016-02-03 10:40:04 +00:00
Kevin Ansfield
10b8ea48bd Fix stretched team image on setup/three
closes #6380
- wraps `<img>` element with a `<div>` to workaround buggy browser behaviour (https://github.com/philipwalton/flexbugs/issues/14)
- adds explicit `width: 100%` to `img` element to fix Firefox not scaling down to mobile sizes
2016-02-02 15:08:28 +00:00
Hannah Wolfe
5b4c8cc20e Merge pull request #6426 from kevinansfield/fix-forgot-password-regression
Acceptance tests for password reset flow on signin screen
2016-02-02 13:58:59 +00:00
Kevin Ansfield
2daff7423a Acceptance tests for password reset flow on signin screen
refs #6039
- adds `/authentication/passwordreset` endpoint to mirage config
- tests the "Forgot?" link behaviour on the signin form

NB: This will fail until #6425 is merged as this tests the correct behaviour rather than the currently broken behaviour ;-)
2016-02-02 12:22:41 +00:00
Fabian Becker
f7538ce511 Correctly use POST request to reset password
closes #6423
2016-02-02 12:58:39 +01:00
James Seymour-Lock
633f224ab5 UI/CSS Improvements
Remove shadow on last tag item hover, was an inconsistent style addition thats not used elsewhere such as the content list
- Remove box-shadow on last of type settings tag hover state
- http://g.recordit.co/CEglFT7Hlr.gif

Remove * selector and specify user-select on individual classes for performance.
- remove * selector
- update classes that benefit from user-select none

Having different visuals based around if a radio/checkbox uses a label or not is weird and style changes should use a class modifier.
- Merged the two together as I was unable to find an example checkbox/radio in use that did not use the label tag

Improved UI for radio/checkboxes
- Added cursor pointer to radio/checkboxes
- Added hover state to radio/checkboxes

Add cursor to select boxes for usability
- cursor: pointer; added to select boxes

Add hover state to post edit icon
- add dark grey hover state to post edit icon

Add visual hover to nav user menu dropdown
- Move dropdown icon to visually indicate hover
2016-01-28 08:35:43 -05:00
Kevin P. Kucharczyk
bddc73031e Fix missing tags list link on mobile
closes #6397
- don't pass isMobile to gh-tag-settings-form
- add gh-tag-settings-form test for mobile settings.tags link
2016-01-26 18:42:13 +01:00
Kevin P. Kucharczyk
20adbcde87 Fix posts.post route not redirecting to 404
closes #6385
- redirect to 404 when post is not found
- replace replaceRoute calls with replaceWith calls in routes (replaceRoute is only available on controllers)
- add post mirage factory
- add acceptance test for post 404 redirection
2016-01-26 15:25:53 +01:00
Kevin Ansfield
22234243df deps: ember-simple-auth@1.0.1
closes #6381
- fixes event forwarding in adaptive session store
2016-01-25 15:52:07 +00:00
Hannah Wolfe
cf8abcb6be Merge pull request #6299 from acburdine/config-refactor
Refactor Config Service
2016-01-25 13:22:20 +00:00
Kevin Ansfield
0277d6aa8d Merge pull request #6372 from jamesslock/copyright-update
Always show current year in copyright text on "About" page
2016-01-25 13:07:43 +00:00
Hannah Wolfe
972e0852d8 Merge pull request #6379 from kevinansfield/fix-jquery-ajax-401
Fix 401 error when uploading images
2016-01-25 12:39:30 +00:00
Kevin Ansfield
d14efb77f6 Merge pull request #6365 from acburdine/remove-on
remove more usage of Ember.on
2016-01-25 11:42:32 +00:00
James Seymour-Lock
43a7649d44 Always show current year in copyright text on "About" page
no issue
- add `copyrightYear` CP to about page controller
- displays the current year in the copyright notice
2016-01-25 11:33:10 +00:00
Kevin Ansfield
a4027d49cf Fix 401 error when uploading images
closes #6377
- restores ajax prefilter initializer that was removed in #6243
- adds regression test for standard `$.ajax` requests sending Authorization header

This can be removed once we no longer have jquery plugins that make internal ajax calls that don't go through ember-ajax.
2016-01-25 11:11:29 +00:00
Kevin P. Kucharczyk
c4371a36f2 Standardise client property names to camelCase
closes #6018
- added keyForAttribute method in application serializer
- override keyForAttribute in settings serializer to not apply camelCase/underscore conversion
- rename under_scored properties to camelCased
2016-01-23 19:12:22 +01:00