OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
38,898 Commits 179 Branches 1,654 Tags 486 MiB
63261d7d88
Commit Graph

1728 Commits

Author SHA1 Message Date
Fabien O'Carroll
63261d7d88 Updated vite config to allow sibling test files 2024-07-24 13:38:08 +07:00
Kevin Ansfield
4465e09f2f Fixed missing space after account name when disconnecting Stripe 
no issue

- line wrap immediately after the variable meant whitespace was being ignored
 2024-07-23 15:05:21 +01:00
renovate[bot]
f493ce9abe Update tiptap monorepo to v2.5.5 2024-07-22 12:00:54 +00:00
renovate[bot]
cbd994d033 Update dependency jsdom to v24.1.1 2024-07-22 09:10:23 +02:00
Michael Barrett
4a59e30050
Published new versions of apps to support BS locale (#20629) 
refs
[ONC-150](https://linear.app/tryghost/issue/ONC-150/support-escalation-re-trouble-with-new-languages)

Published new versions of apps to support BS locale
- comments-ui@0.17.3
- signup-form@0.1.5
- portal@2.37.10
 2024-07-19 09:26:59 +01:00
Steve Larson
6840c3a6b3
🐛 Fixed admin crashing when deleting a tier benefit that was last moved (#20628) 
ref https://linear.app/tryghost/issue/ENG-1433/
- in the tiers details modal, if a tier was deleted after being moved it
would crash admin

The SortableList component calls renderItem for the drag overlay on the
dragged item. However, if that item was deleted, the draggingId never
got reset causing the drag overlay to try to call renderItem on a
nonexistent item.

As a note, we don't actually use this overlay... it could be best to
strip it out to prevent causing issues.
 2024-07-18 17:18:32 +00:00
Princi Vershwal
7c1a732a30
🐛 Fixed publishing issue when site has no active newsletters (#20627) 
Ref [ENG-1253](https://linear.app/tryghost/issue/ENG-1253/)

Not allowing users to archive their last active newsletter
 2024-07-18 14:03:15 +00:00
Princi Vershwal
f05ba155b8
Revert fixed publishing issue when site has no active newsletters 2024-07-18 13:55:49 +00:00
Princi Vershwal
836b6e7be9
Fixed publishing issue when site has no active newsletters 
Ref ENG-1253

Not allowing users to archive their last active newsletter
 2024-07-18 19:14:18 +05:30
renovate[bot]
573dc9f3ee Update tiptap monorepo to v2.5.4 2024-07-17 16:16:16 +00:00
renovate[bot]
8c5e2a7128 Update tiptap monorepo to v2.5.3 2024-07-17 11:43:08 +00:00
renovate[bot]
15c1c9a76b Update tiptap monorepo to v2.5.2 2024-07-17 08:45:34 +00:00
renovate[bot]
1c12b5e92b Update tiptap monorepo to v2.5.1 2024-07-15 15:53:36 +00:00
renovate[bot]
6108df5292 Update tiptap monorepo to v2.5.0 2024-07-15 00:13:35 +00:00
Daniël van der Winden
57dc5f8ded
Updated Archive Newsletter modal (#20594) 
Fixes
https://linear.app/tryghost/issue/DES-470/spacing-on-newsletter-archive-warning-modal-is-missing-between

The modal now follows the same markup as the _Archive Tier_ modal, and
therefore shows whitespace between both paragraphs.
 2024-07-11 13:32:22 +00:00
Daniël van der Winden
74e4ee340a
Fixes searchbar breakpoint issue (#20593) 
Fixes
https://linear.app/tryghost/issue/DES-323/settings-has-a-bad-breakpoint-with-search-bar

On smaller resolutions, the `X` of the searchbar was overlapping with
the `X` of Settings. Setting the right media queries resolved that.
 2024-07-11 15:15:40 +02:00
Princi Vershwal
2cace2987d
Added test for hooks - useSortableIndexedList, usePagination (admin-x-design-system) 
Ref ENG-1351 ENG-1373
 2024-07-11 14:02:55 +05:30
Sag
f8966e26c8
Cleaned up "Recommendations" GA feature flag (#20580) 
no issue

- "Recommendations" feature was released in Ghost
[v5.71.0](https://github.com/TryGhost/Ghost/releases/tag/v5.71.0)
(commit: 1b82efe5d2)
- [Project
details](https://www.notion.so/ghost/Recommentions-5be89ec0d02a4c9b9310a964f9b22901?pvs=4)
 2024-07-10 12:24:27 +00:00
Daniël van der Winden
8feb37cf59
Changed button labels in Navigation modal (#20579) 
Fixes
https://linear.app/tryghost/issue/DES-474/update-navigation-modal-to-use-close-and-save-buttons

We've changed buttons throughout the product to Close/Save, rather than
Cancel/OK. This applies the same pattern to the Navigation modal in the
Admin.
 2024-07-10 11:12:46 +00:00
Sag
a8533c9dc9
Cleaned up "Embeddable signup form" GA feature flag (#20577) 
no issue

- "Embeddable signup form" feature was released in Ghost
[v5.51.0](https://github.com/TryGhost/Ghost/releases/tag/v5.51.0)
(commit: 5e7edb9)
- [Project
details](https://www.notion.so/ghost/Embeddable-signup-forms-1632735f1f894d01be491aeffb48bd45?pvs=4)
 2024-07-10 10:46:04 +00:00
Sag
3aca1411fc
Updated Portal readme with updated develop and release instructions (#20576) 
no issue
 2024-07-10 10:05:41 +00:00
Daniël van der Winden
13bad88baf
Fixed comments UI regression (#20574) 
Fixes
https://linear.app/tryghost/issue/DES-433/mobile-regression-in-comments-ui

Comments modal was previously using isMobile helper, which only works on
pageload. Code is now adjusted to use Tailwind media queries to
show/hide example profiles at the right resolutions.
 2024-07-10 11:22:14 +02:00
Djordje Vlaisavljevic
c6e001280c Improved alignment and spacing of ViewContainer component 
ref https://linear.app/tryghost/issue/MOM-261/improve-alignment-and-spacing-of-viewcontainer-component

- It now looks a lot better when it's set to be page-level and has tabs and actions
 2024-07-09 20:48:40 +01:00
Fabien O'Carroll
f87a7dcd18 Added guard against null icon for actor 
Sometimes the actors icon can be null, and we need to handle that
 2024-07-09 16:58:58 +07:00
Daniël van der Winden
4084a3d00f
Fixes complimentary subscription display issues (#20563) 
Fixes
https://linear.app/tryghost/issue/DES-324/complimentary-plan-issues

We were showing renewal copy for subscriptions that are forever
complimentary. We also had a trailing en-dash in the Member detail
screen when their subscription was complimentary and had no end date.

Those things are solved now. We don't show dates or renewal copy when we
don't need to.
 2024-07-09 11:53:02 +02:00
Sag
8a3ad6df95
Updated README of Comments UI with release instructions (#20560) 
no issue
 2024-07-08 16:15:23 +00:00
Daniël van der Winden
0aef3d3bee
Error copy updates for Newsletter settings (#20559) 
Fixes
https://linear.app/tryghost/issue/DES-550/mechanical-error-message-in-newsletter-detail-modal

Errors in the newsletter detail modal sounded mechanical and were
inconsistent with other error messages. That is now fixed, and they
sound more human.
 2024-07-08 15:33:26 +00:00
Daniël van der Winden
dfb0f93c06
Updated support email error messages (#20558) 
Fixes
https://linear.app/tryghost/issue/DES-537/inconsistent-error-messages-for-invalid-email

We were showing inconsistent error messages when changing the support
email address in Portal settings. They are now consistently shown
inline, rather than in a toast.
 2024-07-08 14:16:38 +00:00
Djordje Vlaisavljevic
a6c6114e6f
Added alternative layout for displaying ActivityPub articles (#20556) 
ref https://linear.app/tryghost/issue/MOM-244/add-alternative-inboxfeed-design, https://linear.app/tryghost/issue/MOM-256/fix-typescript-not-being-able-to-resolve-the-type

- Added a toggle for switching to an alternative layout for displaying
articles in the inbox
- Fixed actor icons not showing up in the inbox
- Fixed Typescript not being able to resolve the type for images
- Added Jest to make tests run

---------

Co-authored-by: Princi Vershwal <vershwal.princi@gmail.com>
 2024-07-08 15:11:01 +01:00
Kevin Ansfield
191a301242
Cleaned up hasPortalImprovements GA feature flag (#20548) 
no issue

- the feature has been GA for a long time now so the conditionals are no longer required
 2024-07-04 16:21:48 +00:00
Kevin Ansfield
3b87c9be53
Cleaned up websockets experiment (#20547) 
no issue

- we're no longer making use of the websockets experiment so it's just bloat
- this is the whole feature in a single commit in case we need to revive it at some point
 2024-07-04 16:08:06 +00:00
Princi Vershwal
3c19d952b1
Added fix for Infinite loop when changing value of new navigation item's field value 
fixed: https://linear.app/tryghost/issue/ENG-1351/🐛-infinite-loop-when-changing-value-of-new-navigation-items-field
 2024-07-04 12:07:33 +00:00
Fabien 'egg' O'Carroll
3e4b8d825d
Fixed Follow for ActivityPub (#20544) 
We need to make requests to the frontend URL, not the Admin API - but
the Admin X Framework doesn't currently support that, so instead we'll
use a simple `fetch` for now.

---------

Co-authored-by: Princi Vershwal <vershwal.princi@gmail.com>
 2024-07-04 10:58:18 +00:00
renovate[bot]
9922c98a6e Update dependency @uiw/react-codemirror to v4.23.0 2024-07-04 07:31:40 +00:00
Kevin Ansfield
e6df014f84 Cleaned up newsletterExcerpt flag 
no issue

- feature is GA so the flag and related conditionals are no longer required
 2024-07-03 18:22:39 +01:00
Aileen Booker
194205769b Added test assertion to verify limit modal redirects to /pro route 
ref ENG-1035

We didn't have a test assertion for when a user is prompted with a limit upgrade modal, which verifies that a click on the `Upgrade` button will redirect correctly to the Billing App (`\pro` route).
 2024-07-03 12:40:42 -04:00
renovate[bot]
7fde7665e2 Update dependency @uiw/react-codemirror to v4.22.2 2024-07-02 16:16:05 +00:00
Sanne de Vries
a046ee324e
Fix scroll on settings page for editor users (#20516) 
REF DES-352
 2024-07-02 14:37:56 +00:00
Sodbileg Gansukh
04fdd2e29e
Display more useful error messages upon theme activation (#20509) 
ref DES-75
 2024-07-02 08:45:33 +00:00
Kevin Ansfield
2fd9116499
🐛 Fixed unwanted extra blank paragraphs when copy/pasting from Google Docs (#20505) 
closes https://linear.app/tryghost/issue/ENG-1255

- updated Koenig packages including:
  - addition of `/preview` for public preview card
  - fix for HTML import from Google Docs
  - fix for embed thumbnails being cut off in email
  - fix for wide image card width on medium screens
- multiple fixes for unhandled (but non user-visible) errors causing noise in console and error logging
 2024-07-01 21:14:07 +01:00
Peter Zimon
fca8941740
Updated integration modals buttons (#20502) 
DES-27

Updated buttons in integrations from [Cancel] and [Save & close] to
[Close] and [Save] to be consistent with the rest of the Settings UI.
 2024-07-01 17:29:53 +02:00
Daniël van der Winden
09f2ccfca4
Updated copy for default recipients hint (#20496) 
Fixes
https://linear.app/tryghost/issue/DES-179/inappropriate-copy-in-default-recipient-settings

The hint for _default recipients_ referenced the wrong setting. It now
reflects the right one.
 2024-07-01 14:14:38 +02:00
Peter Zimon
6378d7d66f
Unify "Save" and "Close" buttons in Settings (#20430) 
DES-27

There are two patterns used in settings modals for action buttons:

1. [Cancel] and [Save & close] (sometimes it's [Cancel] and [OK],
inconsistently) — example: Staff details, Tier details, Navigation,
Recommendation
2. [Close] and [Save] — example: Design settings, Portal, Newsletter
details etc.

This is confusing and leaves people confused and uncertain about what's
going to happen in one or the other case.
 2024-07-01 13:35:38 +02:00
Daniel Lockyer
fa430666bf 🐛 Fixed staff user modal not showing correct example URL 
fix https://linear.app/tryghost/issue/ENG-928/regression-author-url-slug-preview-broken

- simple change to append the slug to the end of the example hint
- also added test
 2024-07-01 10:03:22 +02:00
renovate[bot]
f561f362f4 Update dependency postcss to v8.4.39 2024-07-01 07:28:24 +02:00
Sag
5dfee47fca
🐛 Fixed default recipients setting not showing label filters (#20480) 
fixes https://linear.app/tryghost/issue/SLO-171

- problem: when the Default Recipient setting is set to "Specific
people" and is filtered by a label, we were not able to render the label
correctly
- cause: during the rendering, we look for labels by `id`, but they're
stored by `slug` in the database setting
`editor_default_email_recipients_filter`
- solution: allow to look by the relevant key, by introducing a
programmatic `key` to search for

Before the fix:
https://github.com/TryGhost/Ghost/assets/6225080/aed5fc31-6409-4986-aafe-557073c7f355


After the fix:
https://github.com/TryGhost/Ghost/assets/6225080/f35b2607-5f22-42be-b1bb-92f35ccc9ab7
 2024-06-27 17:47:26 +02:00
Daniel Lockyer
ad77cec008 Removed unused type field 
- this is no longer used and causes a React warning because we end up
  passing it to a textarea
 2024-06-27 10:34:04 +02:00
Fabien 'egg' O'Carroll
0cf3d4d3d5
Updated ActivityPub API root path (#20471) 
ref https://linear.app/tryghost/issue/MOM-201

We will be proxying to `/.ghost/activitypub` rather than just
`/activitypub`
 2024-06-27 11:27:25 +07:00
Djordje Vlaisavljevic
eed162ed2a Added static design for ActivityPub explore 
ref https://linear.app/tryghost/issue/MOM-246/add-empty-state-design
 2024-06-24 18:07:09 +01:00
Djordje Vlaisavljevic
79bc84c545 Added empty state 
ref https://linear.app/tryghost/issue/MOM-246/add-empty-state-design
 2024-06-24 18:07:09 +01:00