4 Commits

Author	SHA1	Message	Date
Fabien O'Carroll	35f150bcf4	Moved errors to domain/errors ... no-issue More cleanup to pull files into their appropriate responsibility	2021-10-08 12:31:11 +02:00
Fabien O'Carroll	78be4b55c9	Moved ValueObject to domain/models/shared ... no-issue This is only ever used in this directory so it makes sense to be colocated.	2021-10-08 12:23:40 +02:00
Fabien O'Carroll	2c04afe810	Updated types of Offers to "fixed" and "percent" ... no-issue This is inline with the language used elsewhere to describe these types.	2021-10-07 17:35:34 +02:00
Fabien O'Carroll	504fb1bfa1	Used Value Objects to validate outside of Offer factory ... no-issue This adds the concept of "Value Objects" to an Offers properties, allowing us to move validation out and ensure that an Offer will only ever have valid properties, without having to duplicate checks - or leave them to the persistent layer. This means we can fail early, as well as write unit tests for all of our validation.	2021-10-07 16:46:08 +02:00