Ghost

Author SHA1 Message Date

Author	SHA1	Message	Date
Rishabh Garg	b46258bbc6	Allowed storing attribution data on member events (#15487 ) refs `90034577b8` - this change was missed in above commit and would have blocked capturing attribution data for sites without the flag	2022-09-28 15:42:04 +05:30
Simon Backx	74ecde73db	Moved attribution event handler to events service (#15379 ) fixes https://github.com/TryGhost/Team/issues/1821 This change moves all the event storage logic to one new place: the event storage class in the MembersEventsService, which is initialised in a new members events service wrapper. Apart from this, this includes some improvements: - Removed DomainEvents from the constructor arguments to the subscribe method (to make it more clear where to subscribe to and decrease dependencies) - LastSeenAtUpdater doesn't subscribe in the constructor any longer (removes unclear side effect) - Moved LastSeenAtUpdater initialisation to new members events service wrapper - Added missing tests to LastSeenAtUpdater to assure that the MembersEventsService package has 100% coverage.	2022-09-07 16:41:59 +02:00

Rishabh Garg

b46258bbc6

Allowed storing attribution data on member events (#15487 )

refs 90034577b8

- this change was missed in above commit and would have blocked capturing attribution data for sites without the flag

2022-09-28 15:42:04 +05:30

Simon Backx

74ecde73db

Moved attribution event handler to events service (#15379 )

fixes https://github.com/TryGhost/Team/issues/1821

This change moves all the event storage logic to one new place: the event storage class in the MembersEventsService, which is initialised in a new members events service wrapper.

Apart from this, this includes some improvements:
- Removed DomainEvents from the constructor arguments to the subscribe method (to make it more clear where to subscribe to and decrease dependencies)
- LastSeenAtUpdater doesn't subscribe in the constructor any longer (removes unclear side effect)
- Moved LastSeenAtUpdater initialisation to new members events service wrapper
- Added missing tests to LastSeenAtUpdater to assure that the MembersEventsService package has 100% coverage.

2022-09-07 16:41:59 +02:00

2 Commits