Commit Graph

4249 Commits

Author SHA1 Message Date
Kevin Ansfield
064e3373f2 Fixed ability to type in markdown cards
no issue
- `visibility: hidden` resulted in the textarea not receiving events which breaks CodeMirror
2019-01-22 11:34:24 +00:00
Kevin Ansfield
bc8d21e224 Fixed listing, removed unused broccoli-clean-css dependency 2019-01-22 09:30:28 +00:00
Vikas Potluri
6c93b1bea8 🎨 clean up hover state borders in night shift (#1077)
no issue
2019-01-22 09:26:38 +00:00
Kevin Ansfield
90633caf06 🐛 Fixed admin search results sometimes showing "No results" for valid queries
closes https://github.com/TryGhost/Ghost/issues/10131
- switch to ember-concurrency tasks to take advantage of built-in concurrency handling and derived state
- bump search content expiry time to 30s
2019-01-21 18:25:58 +00:00
Kevin Ansfield
893a010a4f Lazy-load SimpleMDE dependency in MD card (reduces main bundle by 260KB)
no issue
- use broccoli-funnel to avoid polluting the `dist/` dir with unused build artefacts
- load codemirror and simplemde CSS up-front to avoid duplicate styles and specificity problems
- pull simplemde dependency out into a separate JS file and lazy-load in `{{gh-simplemde}}` component to reduce main bundle size. Before/after:
  - `vendor.min.js 3.58 MB (795.88 KB gzipped)`
  - `vendor.min.js 3.32 MB (710.66 KB gzipped)`
2019-01-21 16:06:25 +00:00
Kevin Ansfield
cda82cf593 Bumped Codemirror, fixed hidden cursor in empty Code Injection fields 2019-01-21 13:57:31 +00:00
Zimo
9da32fa368 Updating to Spirit 0.0.50
refs. https://github.com/TryGhost/Ghost/issues/10027
- fix bold style in HTML blocks for Koenig
2019-01-21 13:51:08 +01:00
Kevin Ansfield
8d7be6bdb2 Removed "defaults to" text from Slack integration's username description 2019-01-21 12:35:19 +00:00
Greg Hart
b235f68052 Added ability to configure Slack integration's username (#1084)
closes https://github.com/TryGhost/Ghost/issues/9735
- add "Username" form to Slack integration
2019-01-21 12:26:21 +00:00
Moritz Schramm
8fcd75de32 🎨 Added post title to document title for easier location with multiple editor tabs (#1072)
closes https://github.com/tryghost/ghost/issues/10088
* added `updateDocumentTitle` action to base route and replace usage of `.send('collectTitleTokens, [])`
* added `.titleToken()` method to editor route to add post title to document title
* called `.send('updateDocumentTitle')` after saving post title in editor controller to keep document title in sync
* updated editor controller test for latest ember-mocha and ember-test-helpers
2019-01-21 11:44:30 +00:00
Kevin Ansfield
39c850f4fe 🐛 Fixed sticky "Unsaved changes" modal when leaving editor
no issue
- the unsaved changes confirmation modal could re-appear after leaving the editor and re-opening the same post
- remove the `.finally` which assumed the confirm action returns a promise so that the modal is properly closed
2019-01-21 09:18:51 +00:00
Hannah Wolfe
f10f7dce22 Updated docs links to best equivalents (#1097)
- Our documentation has been overhauled, this updates the all the old links sprinkled through Ghost-Admin
2019-01-16 16:03:33 +00:00
Fabien O'Carroll
23c8788482 Version bump to 2.11.1 2019-01-16 09:58:53 +01:00
Hannah Wolfe
e3a8972ac3 Syncing CONTRIB and PR templates with main repo
- lots of links were old and out of date
- updated contributing guide to match the one in Ghost
- updated PR guide to be similar to the one in Ghost, but with the Ghost-Admin test info
2019-01-15 20:51:49 +00:00
Fabien O'Carroll
cb787605f7 Version bump to 2.11.0 2019-01-15 14:10:52 +01:00
Fabien O'Carroll
7a1f111f65 Version bump to 2.10.2 2019-01-15 13:42:12 +01:00
Fabien O'Carroll
22a41f5663 💡Removed Public API checkbox by default (#1096)
refs #10364

When the publicAPI flag is undefined, it means it has never been set in
Ghost Admin before - so we can safely remove the option from labs.
2019-01-15 11:23:49 +01:00
Kevin Ansfield
d7375aab1a Fixed missing invite role name on team screen
no issue
- removed the rename of `role_id` to `role` in the invite serialiser to let Ember Data do it's thing with the `invite.role` relationship
- added a guard to the team screen background reloading to ensure that role data is present in the store before loading invites so that Ember Data doesn't trigger unnecessary requests to find missing relationship data
2019-01-14 17:01:30 +00:00
Kevin Ansfield
921d826da5 Fixed @ember/jquery deprecation warning during builds
no issue
- add `@ember/jquery` package to remove deprecation warning for jQuery not being bundled with future Ember versions
2019-01-14 15:38:53 +00:00
Kevin Ansfield
10ccea41ee Fixed thicker top border of active users list
no issue
- fixed bug introduced in https://github.com/TryGhost/Ghost-Admin/pull/1095 by the addition of an `<occluded-content>` element which meant the `:first-child` class was no longer being applied
2019-01-14 15:37:14 +00:00
Kevin Ansfield
434e8ba2f7 🐛 Fixed infinite scroll on the team screen (#1095)
closes https://github.com/TryGhost/Ghost/issues/10307
- removed infinite scroll from the team screen
- adjusted team screen behaviour to pull from the local cache and update in the background to speed up navigation to the screen
- use `{{vertical-collection}}` to render the users list for faster initial render with many users
2019-01-14 14:50:30 +00:00
Kevin Ansfield
5e3de1c333 🎨 Removed auto hide/show navigation toggle (#1094)
no issue
- the autonav behaviour has outlasted it's usefulness - it was mostly useful for editing but the editor screen is now always fullscreen and the number of low-resolution screens has dropped significantly
- dropped the components and all supporting code associated with autonav behaviour
2019-01-10 15:00:07 +00:00
Kevin Ansfield
18b6596cd1 Bump dependencies (#1093)
no issue
- bump ember-cli-htmlbars-inline-precompile
- bump ember-cli-inject-livereload
- bump ember-concurrency
- bump ember-cli-string-helpers
- bump ember-sinon
- 🔥 remove unused ember-wormhole dependency
- bump ember-test-selectors
- bump ember-useragent
- bump ember-cli-babel
- bump eslint-plugin-ghost
- bump ember-load
- bump ember-load-initializers
- bump ember-power-select
- bump grunt-shell
- bump walk-sync

Partial dependency bump. Keeping groups smaller so that any issues are easier to pin down if needed. This PR covers remaining out-of-date dependencies that require little to no additional changes or investigation.
2019-01-10 14:15:37 +00:00
Fabien O'Carroll
14b3ebbb38 Version bump to 2.10.1 2019-01-09 12:27:01 +01:00
Kevin Ansfield
695943b32c Bump dependencies (#1092)
refs https://github.com/TryGhost/Ghost/issues/10310
- bump liquid-fire (cleans up multiple deprecations)
- bump ember-sinon
- bump ember-optional-features
- bump ember-assign-helper
- bump ember-cli-dependency-checker
- bump ember-cli-mirage
- bump ember-cli-pretender
- bump ember-cli-es6-transform

Partial dependency bump. Keeping groups smaller so that any issues are easier to pin down if needed.
2019-01-08 14:39:37 +00:00
Nazar Gargol
b55c6f1c54 Version bump to 2.10.0 2019-01-08 12:37:47 +00:00
Kevin Ansfield
aba884080f Bumped dependencies (Fixed production build) (#1091)
no issue
- bump green (patch) deps
- bump ember-fetch
- bump ember-simple-auth
- bump broccoli-asset-rev
- bump ember-ajax
- bump yarn.lock sub-dependencies

Only a partial dependency upgrade but fixes production build error that was introduced in https://github.com/TryGhost/Ghost-Admin/pull/1044 so merging as-is.
2019-01-08 12:36:16 +00:00
Kevin Ansfield
73daa80b7f Migrate to latest ember, ember-mocha and modern ember testing (#1044)
no issue
- upgrade to latest `ember-source` and related dependencies including `ember-cli`
- upgrade to latest `ember-mocha` and modern ember testing setup
    - https://github.com/emberjs/rfcs/blob/master/text/0268-acceptance-testing-refactor.md
    - switch from using global acceptance test helpers and `native-dom-helpers` to using the new `ember-test-helpers` methods
    - use [`chai-dom`](https://github.com/nathanboktae/chai-dom) assertions where in some places (still a lot of places in the tests that could use these)
- pin `ember-in-viewport` to 3.0.x to work around incompatibilities between different versions used in `ember-light-table`, `ember-infinity`, and `ember-sticky-element`
    - incompatibilities manifested as "Invalid value used as weak map key" errors thrown when using `ember-light-table` (subscribers screen)
- pin `ember-power-datepicker` to unreleased version that contains a move from global acceptance test helpers to modern test helpers
2019-01-02 09:58:55 +00:00
John O'Nolan
56fa37de9e 2019 2019-01-01 14:20:55 +00:00
Nazar Gargol
b9d76106c2 Version bump to 2.9.1 2018-12-20 11:28:23 +01:00
Kevin Ansfield
6d11fd7ac6 Fixed koenigDragDropHandler._resetDrag throwing errors
no issue
- guard around `_elementsWithHoverRemoved` is necessary because it won't always be set
2018-12-17 17:21:22 +00:00
Kevin Ansfield
4096d4ff79 Version bump to 2.9.0 2018-12-17 14:25:24 +00:00
Kevin Ansfield
661b35ba51 Added drag-and-drop card re-ordering in the editor (#1085)
no issue
- add vertical drop position indicator handling to `koenig-drag-drop-handler` service
- fixed issues with nested drag-and-drop containers
- register card drag/drop handler in `koenig-editor`
    - add drag icon creation
2018-12-17 14:02:40 +00:00
Katharina Irrgang
c2d9ea8e1c Removed invitedBy from signup routes (#1087)
refs https://github.com/TryGhost/Ghost/issues/10286

- not used
- looking for more information? visit https://github.com/TryGhost/Ghost/pull/10291
2018-12-17 10:57:26 +00:00
Kevin Ansfield
895d55f4a4 Changed 'blog' to 'site' in setup flow 2018-12-14 17:05:45 +00:00
Kevin Ansfield
46662e590f Fixed error thrown by editor caption input when pressing Escape 2018-12-13 15:22:47 +00:00
Kevin Ansfield
165b2efac9 Added auto-scroll when dragging gallery images (#1083)
no issue

Adds auto-scroll if the mouse is placed near the top or bottom of the window whilst dragging an image to re-order it within a gallery. Useful when the position you want to drag to is not currently on screen.

- append drop indicator element to `.koenig-editor` element to account for scrolling (also fixes indicator positioning bug with current implementation if you use mouse-wheel or keyboard to scroll the page whilst dragging)
- generalise `getParent` util to accept a 
  - switch to using selectors rather than dataset for finding parent draggable/droppable/container
- add a `ScrollHandler` class that is used by the `koenigDragDropHandler` service to trigger scrolling whilst dragging
2018-12-13 12:17:43 +00:00
kirrg001
5874a4d041 Version bump to 2.8.0 2018-12-11 14:25:52 +01:00
Kevin Ansfield
00ee6ebedd Fixed drag-n-drop reorder of gallery images not responding to drops
no issue
- https://github.com/TryGhost/Ghost-Admin/pull/1081 introduced a bug where the `insertIndex` was being cleared every time we showed the drop position indicator because we hide the indicator as a reset every time we show the indicator. This meant every drop was missing the required insertIndex.
- added a flag to the `_hideDropIndicator` function so that a reset when showing the indicator doesn't clear the required information
2018-12-11 13:20:05 +00:00
Kevin Ansfield
f743697450 Fixed overlay overflow on left-most images in gallery card
no issue
- margin was applied to the wrong edge
2018-12-11 13:01:22 +00:00
Kevin Ansfield
9ed6ea0f1e Fixed gallery image changing order randomly when dropped on itself (#1081)
no issue
- clear the cached `insertIndex` when hiding the drop position indicator
- update the gallery card's `_isDropAllowed` function to return `false` if the `droppabeIndex` (`insertIndex`) doesn't exist
2018-12-11 12:13:51 +00:00
Kevin Ansfield
a565abf5bb Fixed drop indicator not showing if placed directly between images (#1082)
no issue
- when dragging an image, if you dragged out of the gallery then back in directly over the space between images then no indicator was shown
- switch to using padding around images rather than margin so that the mouse can be detected over the gap. Added classes to the image overlays to account for the change in sizing
2018-12-11 12:13:15 +00:00
Kevin Ansfield
5647459a2b Added drag-n-drop re-ordering of images within gallery cards (#1073)
no issue
- first pass at implementation of drag-and-drop re-ordering of images within a gallery
- adds a `koenig-drag-drop-handler` service that allows consumers (editor and cards) to hook into drag and drop behaviour without interfering with each other and allows for future possibilities such as dragging images between galleries or into/out of galleries
2018-12-11 10:05:59 +00:00
Kevin Ansfield
1946c7f3fa 🐛 Fixed ability to submit invite form with a missing role (#1080)
refs https://github.com/TryGhost/Ghost/issues/10071
- moved roles fetch request into an ember-concurrency task
- use the task's derived state to disable the submit button whilst fetching
- added role presence check to the invite user validator and updated template to display the error
2018-12-10 14:26:05 +00:00
Kevin Ansfield
48854e4812 Bumped editor undo states to 100 2018-12-06 10:08:49 +00:00
John O'Nolan
6fbe4f42d6 More specific docs link
No issue

Nothing wrong with the docs link but in this context makes more sense to deep link to the info specifically about Ghost Handlebars themes
2018-12-06 15:44:21 +07:00
Kevin Ansfield
2639ff62e6 Optimised gallery image upload previews (#1079)
no issue
- use `URL.createObjectURL(file)` to get a blob url rather than using `FileReader.readAsDataURL` which generates a very large data attribute
- speeds up the display of previews and associated browser hangs when an upload finishes, especially noticeable with large images and fast connections where multiple uploads finish around the same time
2018-12-05 20:16:03 +00:00
Fabien O'Carroll
b3b5290a3c Version bump to 2.7.1 2018-12-05 14:28:11 +07:00
John O'Nolan
314ac7c5ac Fix broken docs link
Refs https://github.com/TryGhost/Ghost-Admin/pull/1078
2018-12-05 14:01:25 +07:00
Fabien O'Carroll
d6abc64b9a Version bump to 2.7.0 2018-12-04 21:10:16 +07:00