From f147167a291a635f041c208da81cbc3aff5bb1b2 Mon Sep 17 00:00:00 2001 From: Chris Raible Date: Thu, 1 Aug 2024 13:38:59 -0700 Subject: [PATCH] Added SQLite and MySQL check to migration review checklist (#20708) no issue - knex can behave differently with SQLite and MySQL, which can cause migrations to behave differently in each database. This PR adds a check to the migration review checklist to remind us to test the migration in both databases before merging. --- .github/workflows/migration-review.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/migration-review.yml b/.github/workflows/migration-review.yml index 18d0adbcf1..885fa98f7e 100644 --- a/.github/workflows/migration-review.yml +++ b/.github/workflows/migration-review.yml @@ -38,6 +38,7 @@ jobs: - [ ] Uses the correct utils - [ ] Contains a minimal changeset - [ ] Does not mix DDL/DML operations + - [ ] Tested in MySQL and SQLite ### Schema changes