OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🐛 Fixed deleting members with email disabled (#19222)

Browse Source 
refs https://ghost.slack.com/archives/CTH5NDJMS/p1701688836406919

Deleting members with email disabled, results in deleting all members
due to a broken NQL filter.

The filter `(email_disabled:1)` results in selecting all members because
of the surrounding brackets, which cause a `yg` filter to be generated
by NQL which is not supported by code that handles the Mongo filters.

This is a quick fix to reduce damage, this will need a proper fix in NQL
/ lower level.
This commit is contained in:
Simon Backx 2023-12-04 15:07:30 +01:00 committed by GitHub
parent 90656aa047
commit e65ae2041c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ghost/admin/app/controllers/members.js
View File

@ -222,10 +222,10 @@ export default class MembersController extends Controller {
if (filterParam) { if (filterParam) {
// If the provided filter param is a single filter related to newsletter subscription status // If the provided filter param is a single filter related to newsletter subscription status
// remove the surrounding brackets to prevent https://github.com/TryGhost/NQL/issues/16 // remove the surrounding brackets to prevent https://github.com/TryGhost/NQL/issues/16
const NEWSLETTER_SUBSCRIPTION_STATUS_RE = /^\(subscribed:(?:true|false)[+,]email_disabled:[01]\)$/; const BRACKETS_SURROUNDED_RE = /^\(.*\)$/;
const SPECIFIC_NEWSLETTER_SUBSCRIPTION_STATUS_RE = /^\(newsletters\.slug:[^()]+[+,]email_disabled:[01]\)$/; const MULTIPLE_GROUPS_RE = /\).*\(/;
if (NEWSLETTER_SUBSCRIPTION_STATUS_RE.test(filterParam) || SPECIFIC_NEWSLETTER_SUBSCRIPTION_STATUS_RE.test(filterParam)) { if (BRACKETS_SURROUNDED_RE.test(filterParam) && !MULTIPLE_GROUPS_RE.test(filterParam)) {
filterParam = filterParam.slice(1, -1); filterParam = filterParam.slice(1, -1);
} }
} }