OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed validation error handling before previewing a post (#20375)

Browse Source 
fixes https://linear.app/tryghost/issue/SLO-143

- in the editor, if there is a validation error on a post (e.g. the excerpt is longer than 300 chars), a validation error is rendered as a red banner error. However, when clicking on Preview, this error was bypassed
- additionally, we were throwing an undefined error when a validation error happened. This was unnecessary and caused hundreds of unhandled errors per week
This commit is contained in:
Sag 2024-06-12 18:29:46 +02:00 committed by GitHub
parent 7d6c91b87b
commit d00b6994c6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ghost/admin/app/components/editor/publish-management.js
View File

@ -56,7 +56,7 @@ export default class PublishManagement extends Component {
} }
} }
if (isValid && !this.publishFlowModal || this.publishFlowModal?.isClosing) { if (isValid && (!this.publishFlowModal || this.publishFlowModal?.isClosing)) {
this.publishOptions.resetPastScheduledAt(); this.publishOptions.resetPastScheduledAt();
this.publishFlowModal = this.modals.open(PublishFlowModal, { this.publishFlowModal = this.modals.open(PublishFlowModal, {
@ -83,7 +83,7 @@ export default class PublishManagement extends Component {
const isValid = await this._validatePost(); const isValid = await this._validatePost();
if (isValid && !this.updateFlowModal || this.updateFlowModal.isClosing) { if (isValid && (!this.updateFlowModal || this.updateFlowModal.isClosing)) {
this.updateFlowModal = this.modals.open(UpdateFlowModal, { this.updateFlowModal = this.modals.open(UpdateFlowModal, {
publishOptions: this.publishOptions, publishOptions: this.publishOptions,
saveTask: this.publishTask saveTask: this.publishTask
@ -99,10 +99,12 @@ export default class PublishManagement extends Component {
} }
@action @action
openPreview(event, {skipAnimation} = {}) { async openPreview(event, {skipAnimation} = {}) {
event?.preventDefault(); event?.preventDefault();
if (!this.previewModal || this.previewModal.isClosing) { const isValid = await this._validatePost();
if (isValid && (!this.previewModal || this.previewModal.isClosing)) {
// open publish flow modal underneath to offer quick switching // open publish flow modal underneath to offer quick switching
// without restarting the flow or causing flicker // without restarting the flow or causing flicker

3
ghost/admin/app/controllers/lexical-editor.js
View File

@ -642,8 +642,7 @@ export default class LexicalEditorController extends Controller {
if (!options.silent) { if (!options.silent) {
let errorOrMessages = error || this.get('post.errors.messages'); let errorOrMessages = error || this.get('post.errors.messages');
this._showErrorAlert(prevStatus, this.get('post.status'), errorOrMessages); this._showErrorAlert(prevStatus, this.get('post.status'), errorOrMessages);
// simulate a validation error for upstream tasks return;
throw undefined;
} }
return this.post; return this.post;