OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🐛 Fixed fetching labels and offers in the editor (#20815)

Browse Source 
ref https://linear.app/tryghost/issue/ONC-263/
- labels dropdown in sign up card was not successfully fetching labels
- offers dropdown suffered the same fate

When introducing the second editor instance, it appears we ran into some
race conditions with the Ember tasks used to fetch the resources. The
init instance was beating the other to the punch, and so the state was
never successfully updated, as it is only fetched once on mounting the
card.
This commit is contained in:
Steve Larson 2024-08-22 08:55:33 -05:00 committed by GitHub
parent f984fbd47e
commit cd7c27d3ad
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ghost/admin/app/components/koenig-lexical-editor.js
View File

@ -248,7 +248,7 @@ export default class KoenigLexicalEditor extends Component {
// don't rethrow, Lexical will attempt to gracefully recover // don't rethrow, Lexical will attempt to gracefully recover
} }
@task({restartable: true}) @task({restartable: false})
*fetchOffersTask() { *fetchOffersTask() {
if (this.offers) { if (this.offers) {
return this.offers; return this.offers;
@ -257,7 +257,7 @@ export default class KoenigLexicalEditor extends Component {
return this.offers; return this.offers;
} }
@task({restartable: true}) @task({restartable: false})
*fetchLabelsTask() { *fetchLabelsTask() {
if (this.labels) { if (this.labels) {
return this.labels; return this.labels;