diff --git a/apps/comments-ui/src/components/content/Content.tsx b/apps/comments-ui/src/components/content/Content.tsx index ce665a1a55..caf9810b63 100644 --- a/apps/comments-ui/src/components/content/Content.tsx +++ b/apps/comments-ui/src/components/content/Content.tsx @@ -37,7 +37,6 @@ const Content = () => { return ( <> -
{commentsElements}
@@ -47,6 +46,7 @@ const Content = () => { : null } + ); }; diff --git a/apps/comments-ui/src/utils/api.ts b/apps/comments-ui/src/utils/api.ts index a30903aa1c..1d839be01c 100644 --- a/apps/comments-ui/src/utils/api.ts +++ b/apps/comments-ui/src/utils/api.ts @@ -129,7 +129,7 @@ function setupGhostApi({siteUrl = window.location.origin, apiUrl, apiKey}: {site const params = new URLSearchParams(); - params.set('limit', '5'); + params.set('limit', '20'); if (filter) { params.set('filter', filter); } diff --git a/apps/comments-ui/test/e2e/pagination.test.ts b/apps/comments-ui/test/e2e/pagination.test.ts index 5542c3fca3..8ef7237e52 100644 --- a/apps/comments-ui/test/e2e/pagination.test.ts +++ b/apps/comments-ui/test/e2e/pagination.test.ts @@ -1,28 +1,11 @@ -import {MockedApi, initialize} from '../utils/e2e'; +import {MockedApi, addMultipleComments, initialize} from '../utils/e2e'; import {expect, test} from '@playwright/test'; test.describe('Pagination', async () => { - test('Shows pagination button on top if more than 5 comments', async ({page}) => { + test('Shows pagination button at bottom if more than 20 comments', async ({page}) => { const mockedApi = new MockedApi({}); - mockedApi.addComment({ - html: '

This is comment 1

' - }); - mockedApi.addComment({ - html: '

This is comment 2

' - }); - mockedApi.addComment({ - html: '

This is comment 3

' - }); - mockedApi.addComment({ - html: '

This is comment 4

' - }); - mockedApi.addComment({ - html: '

This is comment 5

' - }); - mockedApi.addComment({ - html: '

This is comment 6

' - }); + addMultipleComments(mockedApi, 21); const {frame} = await initialize({ mockedApi, @@ -36,24 +19,27 @@ test.describe('Pagination', async () => { await expect(frame.getByTestId('pagination-component')).toContainText('Show 1 previous comment'); // Test total comments with test-id comment-component is 5 - await expect(frame.getByTestId('comment-component')).toHaveCount(5); + await expect(frame.getByTestId('comment-component')).toHaveCount(20); - // Check only the first 5 comments are visible - await expect(frame.getByText('This is comment 1')).not.toBeVisible(); - await expect(frame.getByText('This is comment 2')).toBeVisible(); - await expect(frame.getByText('This is comment 3')).toBeVisible(); - await expect(frame.getByText('This is comment 4')).toBeVisible(); - await expect(frame.getByText('This is comment 5')).toBeVisible(); - await expect(frame.getByText('This is comment 6')).toBeVisible(); + // Check only the first latest 20 comments are visible + await expect(frame.getByText('This is comment 1.')).not.toBeVisible(); + await expect(frame.getByText('This is comment 2.')).toBeVisible(); + await expect(frame.getByText('This is comment 3.')).toBeVisible(); + await expect(frame.getByText('This is comment 4.')).toBeVisible(); + await expect(frame.getByText('This is comment 5.')).toBeVisible(); + await expect(frame.getByText('This is comment 6.')).toBeVisible(); + await expect(frame.getByText('This is comment 20.')).toBeVisible(); + + // // Click the pagination button await frame.getByTestId('pagination-component').click(); - // Check only 6 visible (not more than that) - await expect(frame.getByTestId('comment-component')).toHaveCount(6); + // Check only 21 visible (not more than that) + await expect(frame.getByTestId('comment-component')).toHaveCount(21); // Check comments 6 is visible - await expect(frame.getByText('This is comment 1')).toBeVisible(); + await expect(frame.getByText('This is comment 1.')).toBeVisible(); // Check the pagination button is not visible await expect(frame.getByTestId('pagination-component')).not.toBeVisible(); diff --git a/apps/comments-ui/test/utils/e2e.ts b/apps/comments-ui/test/utils/e2e.ts index 356c05fcf4..240b0ce2ca 100644 --- a/apps/comments-ui/test/utils/e2e.ts +++ b/apps/comments-ui/test/utils/e2e.ts @@ -202,3 +202,11 @@ export function getModifierKey() { return 'Control'; } } + +export function addMultipleComments(api, numComments) { + for (let i = 1; i <= numComments; i++) { + api.addComment({ + html: `

This is comment ${i}.

` + }); + } +}