+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ Good news!
+
+ One of the sites you're recommending is now recommending you back :
+
+
+
+
+
Other Ghost Site
+
+
+
+ Other Ghost Site
+
+
+
+
+
+ You can also copy & paste this URL into your browser:
+ http://127.0.0.1:2369/ghost/#/settings-x/recommendations
+
+
+
+
+
+
+ This message was sent from 127.0.0.1 to jbloggs@example.com
+
+
+
+
+ Don’t want to receive these emails? Manage your preferences here .
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+"
+`;
+
+exports[`Incoming Recommendation Emails Sends a different email if we receive a recommendation back 2: [text 1] 1`] = `
+"
+You have been recommended by Other Ghost Site.
+
+---
+
+Sent to jbloggs@example.com from 127.0.0.1.
+If you would no longer like to receive these notifications you can adjust your settings at http://127.0.0.1:2369/ghost/#/settings-x/users/show/joe-bloggs.
+ "
+`;
+
+exports[`Incoming Recommendation Emails Sends a different email if we receive a recommendation back 3: [metadata 1] 1`] = `
+Object {
+ "subject": "Other Ghost Site recommended you",
+ "to": "jbloggs@example.com",
+}
+`;
+
+exports[`Incoming Recommendation Emails Sends an email if we receive a recommendation 1: [html 1] 1`] = `
+"
+
+
+
+
+
+"
+`;
+
+exports[`Incoming Recommendation Emails Sends an email if we receive a recommendation 2: [html 2] 1`] = `
+"
+
+
+
+
+
+"
+`;
+
+exports[`Incoming Recommendation Emails Sends an email if we receive a recommendation 2: [text 1] 1`] = `
+"
+You have been recommended by Other Ghost Site.
+
+---
+
+Sent to jbloggs@example.com from 127.0.0.1.
+If you would no longer like to receive these notifications you can adjust your settings at http://127.0.0.1:2369/ghost/#/settings-x/users/show/joe-bloggs.
+ "
+`;
+
+exports[`Incoming Recommendation Emails Sends an email if we receive a recommendation 3: [metadata 1] 1`] = `
+Object {
+ "subject": "Other Ghost Site recommended you",
+ "to": "jbloggs@example.com",
+}
+`;
+
+exports[`Incoming Recommendation Emails Sends an email if we receive a recommendation 3: [text 1] 1`] = `
+"
+You have been recommended by Other Ghost Site.
+
+---
+
+Sent to jbloggs@example.com from 127.0.0.1.
+If you would no longer like to receive these notifications you can adjust your settings at http://127.0.0.1:2369/ghost/#/settings-x/users/show/joe-bloggs.
+ "
+`;
+
+exports[`Incoming Recommendation Emails Sends an email if we receive a recommendation 4: [metadata 1] 1`] = `
+Object {
+ "subject": "Other Ghost Site recommended you",
+ "to": "jbloggs@example.com",
+}
+`;
diff --git a/ghost/core/test/e2e-server/services/recommendation-emails.test.js b/ghost/core/test/e2e-server/services/recommendation-emails.test.js
new file mode 100644
index 0000000000..baabe37dff
--- /dev/null
+++ b/ghost/core/test/e2e-server/services/recommendation-emails.test.js
@@ -0,0 +1,180 @@
+const {agentProvider, fixtureManager, mockManager, dbUtils} = require('../../utils/e2e-framework');
+const assert = require('assert/strict');
+const mentionsService = require('../../../core/server/services/mentions');
+const recommendationsService = require('../../../core/server/services/recommendations');
+
+let agent;
+const DomainEvents = require('@tryghost/domain-events');
+const {Mention} = require('@tryghost/webmentions');
+const {Recommendation} = require('@tryghost/recommendations');
+
+describe('Incoming Recommendation Emails', function () {
+ let emailMockReceiver;
+
+ before(async function () {
+ agent = await agentProvider.getAdminAPIAgent();
+ await fixtureManager.init('users');
+ await agent.loginAsAdmin();
+ });
+
+ beforeEach(async function () {
+ emailMockReceiver = mockManager.mockMail();
+ });
+
+ afterEach(async function () {
+ mockManager.restore();
+ });
+
+ it('Sends an email if we receive a recommendation', async function () {
+ const webmention = await Mention.create({
+ source: 'https://www.otherghostsite.com/.well-known/recommendations.json',
+ target: 'https://www.mysite.com/',
+ timestamp: new Date(),
+ payload: null,
+ resourceId: null,
+ resourceType: null,
+ sourceTitle: 'Other Ghost Site',
+ sourceSiteTitle: 'Other Ghost Site',
+ sourceAuthor: null,
+ sourceExcerpt: null,
+ sourceFavicon: null,
+ sourceFeaturedImage: null
+ });
+
+ // Mark it as verified
+ webmention.verify('{"url": "https://www.mysite.com/"}', 'application/json');
+ assert.ok(webmention.verified);
+
+ // Save to repository
+ await mentionsService.repository.save(webmention);
+
+ await DomainEvents.allSettled();
+
+ emailMockReceiver
+ .assertSentEmailCount(2)
+ .matchHTMLSnapshot([{}], 0)
+ .matchHTMLSnapshot([{}], 1)
+ .matchPlaintextSnapshot([{}])
+ .matchMetadataSnapshot();
+
+ const email = emailMockReceiver.getSentEmail(0);
+
+ // Check if the site title is visible in the email
+ assert(email.html.includes('Other Ghost Site'));
+ assert(email.html.includes('Recommend back'));
+ assert(email.html.includes('https://www.otherghostsite.com'));
+ });
+
+ it('Sends a different email if we receive a recommendation back', async function () {
+ if (dbUtils.isSQLite()) {
+ this.skip();
+ }
+
+ // Create a recommendation to otherghostsite.com
+ const recommendation = Recommendation.create({
+ title: `Recommendation`,
+ reason: `Reason`,
+ url: new URL(`https://www.otherghostsite.com/`),
+ favicon: null,
+ featuredImage: null,
+ excerpt: 'Test excerpt',
+ oneClickSubscribe: true,
+ createdAt: new Date(5000)
+ });
+
+ await recommendationsService.repository.save(recommendation);
+
+ const webmention = await Mention.create({
+ source: 'https://www.otherghostsite.com/.well-known/recommendations.json',
+ target: 'https://www.mysite.com/',
+ timestamp: new Date(),
+ payload: null,
+ resourceId: null,
+ resourceType: null,
+ sourceTitle: 'Other Ghost Site',
+ sourceSiteTitle: 'Other Ghost Site',
+ sourceAuthor: null,
+ sourceExcerpt: null,
+ sourceFavicon: null,
+ sourceFeaturedImage: null
+ });
+
+ // Mark it as verified
+ webmention.verify('{"url": "https://www.mysite.com/"}', 'application/json');
+ assert.ok(webmention.verified);
+
+ // Save to repository
+ await mentionsService.repository.save(webmention);
+
+ await DomainEvents.allSettled();
+
+ emailMockReceiver
+ .assertSentEmailCount(2)
+ .matchHTMLSnapshot([{}])
+ .matchPlaintextSnapshot([{}])
+ .matchMetadataSnapshot();
+
+ const email = emailMockReceiver.getSentEmail(0);
+
+ // Check if the site title is visible in the email
+ assert(email.html.includes('Other Ghost Site'));
+ assert(email.html.includes('View recommendations'));
+ assert(email.html.includes('https://www.otherghostsite.com'));
+ });
+
+ it('Does not send an email if we receive a normal mention', async function () {
+ const webmention = await Mention.create({
+ source: 'https://www.otherghostsite.com/recommendations.json',
+ target: 'https://www.mysite.com/',
+ timestamp: new Date(),
+ payload: null,
+ resourceId: null,
+ resourceType: null,
+ sourceTitle: 'Other Ghost Site',
+ sourceSiteTitle: 'Other Ghost Site',
+ sourceAuthor: null,
+ sourceExcerpt: null,
+ sourceFavicon: null,
+ sourceFeaturedImage: null
+ });
+
+ // Mark it as verified
+ webmention.verify('{"url": "https://www.mysite.com/"}', 'application/json');
+ assert.ok(webmention.verified);
+
+ // Save to repository
+ await mentionsService.repository.save(webmention);
+
+ await DomainEvents.allSettled();
+
+ mockManager.assert.sentEmailCount(0);
+ });
+
+ it('Does not send an email for an unverified webmention', async function () {
+ const webmention = await Mention.create({
+ source: 'https://www.otherghostsite.com/.well-known/recommendations.json',
+ target: 'https://www.mysite.com/',
+ timestamp: new Date(),
+ payload: null,
+ resourceId: null,
+ resourceType: null,
+ sourceTitle: 'Other Ghost Site',
+ sourceSiteTitle: 'Other Ghost Site',
+ sourceAuthor: null,
+ sourceExcerpt: null,
+ sourceFavicon: null,
+ sourceFeaturedImage: null
+ });
+
+ // Mark it as verified
+ webmention.verify('{"url": "https://www.myste.com/"}', 'application/json');
+ assert.ok(!webmention.verified);
+
+ // Save to repository
+ await mentionsService.repository.save(webmention);
+
+ await DomainEvents.allSettled();
+
+ mockManager.assert.sentEmailCount(0);
+ });
+});
diff --git a/ghost/oembed-service/lib/OEmbedService.js b/ghost/oembed-service/lib/OEmbedService.js
index 5255e8eb28..064069ae18 100644
--- a/ghost/oembed-service/lib/OEmbedService.js
+++ b/ghost/oembed-service/lib/OEmbedService.js
@@ -232,7 +232,12 @@ class OEmbedService {
let scraperResponse;
try {
- scraperResponse = await metascraper({html, url});
+ scraperResponse = await metascraper({
+ html,
+ url,
+ // In development, allow non-standard tlds
+ validateUrl: this.config.get('env') !== 'development'
+ });
} catch (err) {
// Log to avoid being blind to errors happenning in metascraper
logging.error(err);
diff --git a/ghost/recommendations/src/IncomingRecommendationEmailRenderer.ts b/ghost/recommendations/src/IncomingRecommendationEmailRenderer.ts
new file mode 100644
index 0000000000..bece0fa35c
--- /dev/null
+++ b/ghost/recommendations/src/IncomingRecommendationEmailRenderer.ts
@@ -0,0 +1,36 @@
+import {IncomingRecommendation, EmailRecipient} from './IncomingRecommendationService';
+
+type StaffService = {
+ api: {
+ emails: {
+ renderHTML(template: string, data: unknown): Promise