OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Trim generated post slug length in Revue importer (#16065)

Browse Source 
refs: 5f90baf6fe

- Ghost has a character limit on post slugs of 191 characters,
- Sometimes, the slug that is generated from the title in Revue content is longer than this, causing the import to fail. 
- This PR trims that generated post slug to 190 characters.
This commit is contained in:
Paul Davis 2023-01-03 20:15:32 +00:00 committed by GitHub
parent 1c9ad00d6d
commit 8db947cd24
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ghost/importer-revue/lib/importer-revue.js
View File

@ -44,11 +44,12 @@ const fetchPostsFromData = (revueData) => {
} }
const postDate = JSONToHTML.getPostDate(postMeta); const postDate = JSONToHTML.getPostDate(postMeta);
const postSlug = slugify(postMeta.subject).slice(0, 190);
posts.push({ posts.push({
comment_id: revuePostID, comment_id: revuePostID,
title: postMeta.subject, title: postMeta.subject,
slug: slugify(postMeta.subject), slug: postSlug,
status: JSONToHTML.getPostStatus(postMeta), status: JSONToHTML.getPostStatus(postMeta),
visibility: 'public', visibility: 'public',
created_at: postDate, created_at: postDate,

18
ghost/importer-revue/test/importer-revue.test.js
View File

@ -113,6 +113,24 @@ describe('Revue Importer', function () {
} }
]); ]);
}); });
it('can trim generated post slug length', function () {
const result = RevueImporter.importPosts({items: '[]', issues: 'id,description,sent_at,subject,preheader\n123456,"<p>Hello World!</p>",2022-12-01 01:01:30 UTC,Lorem Ipsum Dolor Sit Amet Consectetur Adipiscing Elit Mauris Convallis Et Metus Eu Blandit Lorem Ipsum Dolor Sit Amet Consectetur Adipiscing Elit Ut Porta Dapibus Massa Condimentum Malesuada Ipsum Scelerisque Nec Vestibulum Sed Placerat Cras,'});
assert.deepEqual(result, [
{
comment_id: 123456,
title: 'Lorem Ipsum Dolor Sit Amet Consectetur Adipiscing Elit Mauris Convallis Et Metus Eu Blandit Lorem Ipsum Dolor Sit Amet Consectetur Adipiscing Elit Ut Porta Dapibus Massa Condimentum Malesuada Ipsum Scelerisque Nec Vestibulum Sed Placerat Cras',
slug: 'lorem-ipsum-dolor-sit-amet-consectetur-adipiscing-elit-mauris-convallis-et-metus-eu-blandit-lorem-ipsum-dolor-sit-amet-consectetur-adipiscing-elit-ut-porta-dapibus-massa-condimentum-malesuad',
status: 'published',
visibility: 'public',
created_at: '2022-12-01T01:01:30.000Z',
published_at: '2022-12-01T01:01:30.000Z',
updated_at: '2022-12-01T01:01:30.000Z',
html: '<p>Hello World!</p>'
}
]);
});
}); });
describe('importSubscribers', function () { describe('importSubscribers', function () {