OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added time field to slow get helper logging (#20427)

Browse Source 
refs
[CFR-36](https://linear.app/tryghost/issue/CFR-36/pull-out-response-time-from-ghost-logs-message-field-for-get-helper)

Added time field to slow get helper logging to make it easier to query
and filter on this value in elastic without having to parse the message
field
This commit is contained in:
Michael Barrett 2024-06-24 14:28:42 +01:00 committed by GitHub
parent e0057fd30f
commit 897481b3b4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ghost/core/core/frontend/helpers/get.js
View File

@ -299,7 +299,7 @@ module.exports = async function get(resource, options) {
try {
const spanName = `{{#get "${resource}"${apiOptionsString}}} ${data.member ? 'member' : 'public'}`;
const result = await Sentry.startSpan({
op: 'frontend.helpers.get',
op: 'frontend.helpers.get',
name: spanName,
tags: {
resource,
@ -313,11 +313,11 @@ module.exports = async function get(resource, options) {
if (response[resource] && response[resource].length) {
response[resource].forEach(prepareContextResource);
}
// used for logging details of slow requests
returnedRowsCount = response[resource] && response[resource].length;
span?.setTag('returnedRows', returnedRowsCount);
// block params allows the theme developer to name the data using something like
// `{{#get "posts" as |result pageInfo|}}`
const blockParams = [response[resource]];
@ -325,7 +325,7 @@ module.exports = async function get(resource, options) {
response.pagination = response.meta.pagination;
blockParams.push(response.meta.pagination);
}
// Call the main template function
const rendered = options.fn(response, {
data: data,
@ -357,7 +357,9 @@ module.exports = async function get(resource, options) {
apiOptions,
returnedRows: returnedRowsCount
}
}));
}), {
time: totalMs
});
}
}
}