From 5e7edb9da56dbf463187a03020d16fc25967bca8 Mon Sep 17 00:00:00 2001 From: Simon Backx Date: Fri, 9 Jun 2023 11:21:18 +0200 Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20Added=20embeddable=20signup=20form?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit refs https://github.com/TryGhost/Team/issues/3274 Co-authored-by: Sanne de Vries Co-authored-by: Ronald Langeveld Co-authored-by: Jono Mingard Co-authored-by: Sag --- ghost/admin/app/templates/settings/labs.hbs | 14 -------------- ghost/core/core/shared/labs.js | 6 +++--- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/ghost/admin/app/templates/settings/labs.hbs b/ghost/admin/app/templates/settings/labs.hbs index 746f20bc1d..a91b68a310 100644 --- a/ghost/admin/app/templates/settings/labs.hbs +++ b/ghost/admin/app/templates/settings/labs.hbs @@ -283,20 +283,6 @@ -
-
-
-

Signup Form

-

- Adds an option to generate embed code for the signup form in the email newsletter settings. -

-
-
- -
-
-
-
diff --git a/ghost/core/core/shared/labs.js b/ghost/core/core/shared/labs.js index 8e7d820c41..3250ed933b 100644 --- a/ghost/core/core/shared/labs.js +++ b/ghost/core/core/shared/labs.js @@ -18,7 +18,8 @@ const GA_FEATURES = [ 'audienceFeedback', 'themeErrorsNotification', 'outboundLinkTagging', - 'announcementBar' + 'announcementBar', + 'signupForm' ]; // NOTE: this allowlist is meant to be used to filter out any unexpected @@ -38,8 +39,7 @@ const ALPHA_FEATURES = [ 'emailCustomization', 'signupCard', 'collections', - 'adminXSettings', - 'signupForm' + 'adminXSettings' ]; module.exports.GA_KEYS = [...GA_FEATURES];