OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🐛 Fixed 500 errors when viewing posts in development mode

Browse Source 
closes https://linear.app/tryghost/issue/ONC-115

- OpenTelemetry was throwing errors when viewing posts
- disabled the instrumentation in development mode so it requires explicit config to enable
This commit is contained in:
Kevin Ansfield 2024-06-21 21:50:44 +01:00
parent a837cf0247
commit 5b2eaec982
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ghost/core/core/shared/instrumentation.js
View File

@ -1,9 +1,10 @@
async function initOpenTelemetry({config}) {
// Always enable in development environment
// In production, only enable if explicitly enabled via config `opentelemetry:enabled`
const isDevelopment = process.env.NODE_ENV === 'development';
// TODO: Instrumentation currently breaks viewing posts - disabled until we can fix
// const isDevelopment = process.env.NODE_ENV === 'development';
const isConfigured = config.get('opentelemetry:enabled');
const enabled = isDevelopment || isConfigured;
const enabled = isConfigured; // || isDevelopment;
if (!enabled) {
return;
}