Removed unused portal-settings modal code from settings screen

no issue

- portal settings modal is now initiated from the membership screen so the code for showing/closing it in the settings controller is not needed

ghost/admin/app/controllers/settings.js

@@ -7,35 +7,22 @@ export default Controller.extend({
     settings: service(),
     session: service(),
 
-    queryParams: ['showPortalSettings', 'showBrandingModal'],
+    queryParams: ['showBrandingModal'],
 
-    showPortalSettings: false,
     showBrandingModal: false,
     showLeaveSettingsModal: false,
 
-    tagName: '',
-
     actions: {
         openStripeSettings() {
             this.set('membersStripeOpen', true);
         },
 
-        closePortalSettings() {
-            const changedAttributes = this.settings.changedAttributes();
-            if (changedAttributes && Object.keys(changedAttributes).length > 0) {
-                this.set('showLeaveSettingsModal', true);
-            } else {
-                this.set('showPortalSettings', false);
-            }
-        },
-
         closeLeaveSettingsModal() {
             this.set('showLeaveSettingsModal', false);
         },
 
         async leavePortalSettings() {
             this.settings.rollbackAttributes();
-            this.set('showPortalSettings', false);
             this.set('showLeaveSettingsModal', false);
         },
 

ghost/admin/app/templates/settings.hbs

@@ -78,14 +78,6 @@
     </section>
 </section>
 
-{{#if this.showPortalSettings}}
-    <GhFullscreenModal @modal="portal-settings"
-        @model={{hash
-            openStripeSettings=(action "openStripeSettings")
-        }}
-        @close={{action "closePortalSettings"}}
-        @modifier="full-overlay portal-settings" />
-{{/if}}
 {{#if this.showBrandingModal}}
     <GhFullscreenModal @modal="branding"
         @close={{action "closeBrandingModal"}}