Improved commit message docs in contributing guide
- `refs/closes` can be confusing to those who are not familiar with GitHub when we actually mean "use refs or fixes (or closes)" - we generally don't want to use emojis for alpha features because adding it to the release notes is unnecessary until the feature is GA
This commit is contained in:
parent
143ae857c9
commit
31235dcd04
5
.github/CONTRIBUTING.md
vendored
5
.github/CONTRIBUTING.md
vendored
@ -33,11 +33,10 @@ We have a handful of simple standards for commit messages which help us to gener
|
|||||||
|
|
||||||
- **1st line:** Max 80 character summary written in past tense
|
- **1st line:** Max 80 character summary written in past tense
|
||||||
- **2nd line:** [Always blank]
|
- **2nd line:** [Always blank]
|
||||||
- **3rd line:** `refs/closes #000` or `no issue`
|
- **3rd line:** `refs <issue link>`, `fixes <issue link>` or `no issue`
|
||||||
- **4th line:** Why this change was made - the code includes the what, the commit message should describe the context of why - why this, why now, why not something else?
|
- **4th line:** Why this change was made - the code includes the what, the commit message should describe the context of why - why this, why now, why not something else?
|
||||||
|
|
||||||
If your change is **user-facing** please prepend the first line of your commit with **an emoji key**.
|
If your change is **user-facing** please prepend the first line of your commit with **an emoji key**. If the commit is for an alpha feature, no emoji is needed. We are following [gitmoji](https://gitmoji.carloscuesta.me/).
|
||||||
We are following [gitmoji](https://gitmoji.carloscuesta.me/).
|
|
||||||
|
|
||||||
**Main emojis we are using:**
|
**Main emojis we are using:**
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user