OpenSourceArk/Ghost
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Mocked network access for {{amp_content}} img unit test (#10792)

Browse Source 
no issue

- unit test was fetching images over the network which could cause random test failures on poor connections
This commit is contained in:
Kevin Ansfield 2019-06-19 07:56:30 +01:00 committed by Fabien O'Carroll
parent abda6e6338
commit 3069f5f5a9
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
core/test/unit/apps/amp/amp_content_spec.js
View File

@ -1,5 +1,6 @@
var should = require('should'),
rewire = require('rewire'),
nock = require('nock'),
urlUtils = require('../../../../test/utils/urlUtils'),
ampContentHelper = rewire('../../../../server/apps/amp/lib/helpers/amp_content');
@ -117,12 +118,18 @@ describe('{{amp_content}} helper', function () {
});
it('can transform img tags to amp-img', function (done) {
const GIF1x1 = Buffer.from('R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==', 'base64');
nock('https://blog.ghost.org')
.get('/content/images/2019/06/test.jpg')
.reply(200, GIF1x1);
var testData = {
html: '<img src="/content/images/2016/08/scheduled2-1.jpg" alt="The Ghost Logo" />',
html: '<img src="/content/images/2019/06/test.jpg" alt="The Ghost Logo" />',
updated_at: 'Wed Jul 27 2016 18:17:22 GMT+0200 (CEST)',
id: 1
},
expectedResult = '<amp-img src="https://blog.ghost.org/content/images/2016/08/scheduled2-1.jpg" alt="The Ghost Logo" width="1000" height="281" layout="responsive"></amp-img>',
expectedResult = '<amp-img src="https://blog.ghost.org/content/images/2019/06/test.jpg" alt="The Ghost Logo" width="1" height="1" layout="fixed"></amp-img>',
ampResult = ampContentHelper.call(testData);
ampResult.then(function (rendered) {