Fixed typos (#18648)
Co-authored-by: Daniel Lockyer <daniellockyer@fastmail.com>
This commit is contained in:
parent
97d0cddb50
commit
2e5fdffe32
@ -23,7 +23,7 @@ Run `yarn dev` (in package folder) to start the development server to test/devel
|
|||||||
|
|
||||||
### Using the UMD build during development
|
### Using the UMD build during development
|
||||||
|
|
||||||
Vite by default only supports HRM with an ESM output. But when loading a script on a site as a ESM module (`<script type="module" src="...">`), you don't have access to `document.currentScript` inside the script, which is required to determine the location to inject the iframe. In development mode we use a workaround for this to make the ESM HMR work. But this workaroudn is not suitable for production.
|
Vite by default only supports HRM with an ESM output. But when loading a script on a site as a ESM module (`<script type="module" src="...">`), you don't have access to `document.currentScript` inside the script, which is required to determine the location to inject the iframe. In development mode we use a workaround for this to make the ESM HMR work. But this workaround is not suitable for production.
|
||||||
|
|
||||||
To test the real production behaviour without this hack, you can use http://localhost:6173/preview.html. This HTML page will use `http://localhost:6174/signup-form.min.js` directly.
|
To test the real production behaviour without this hack, you can use http://localhost:6173/preview.html. This HTML page will use `http://localhost:6174/signup-form.min.js` directly.
|
||||||
|
|
||||||
|
@ -25,6 +25,6 @@ All of these separate files are subsequently imported and compiled in `app.css`.
|
|||||||
* Always a space after a property's colon (.e.g, display: block; and not display:block;).
|
* Always a space after a property's colon (.e.g, display: block; and not display:block;).
|
||||||
* End all lines with a semi-colon.
|
* End all lines with a semi-colon.
|
||||||
* For multiple, comma-separated selectors, place each selector on its own line.
|
* For multiple, comma-separated selectors, place each selector on its own line.
|
||||||
* Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per [Slightly Obtrusive JavaSript](http://ozmm.org/posts/slightly_obtrusive_javascript.html)
|
* Use js- prefixed classes for JavaScript hooks into the DOM, and never use these in CSS as per [Slightly Obtrusive JavaScript](http://ozmm.org/posts/slightly_obtrusive_javascript.html)
|
||||||
* Avoid over-nesting CSS. Never nest more than 3 levels deep.
|
* Avoid over-nesting CSS. Never nest more than 3 levels deep.
|
||||||
* Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)
|
* Use comments to explain "why" not "what" (Good: This requires a z-index in order to appear above mobile navigation. Bad: This is a thing which is always on top!)
|
||||||
|
@ -220,7 +220,7 @@ export default class ParseMemberEventHelper extends Helper {
|
|||||||
* object: 'My blog post'
|
* object: 'My blog post'
|
||||||
* When both words need to get appended, we'll add 'on'
|
* When both words need to get appended, we'll add 'on'
|
||||||
* -> do this by returning 'on' in getJoin()
|
* -> do this by returning 'on' in getJoin()
|
||||||
* This string is not added when action and object are in a separete table column, or when the getObject/getURL is empty
|
* This string is not added when action and object are in a separate table column, or when the getObject/getURL is empty
|
||||||
*/
|
*/
|
||||||
getJoin() {
|
getJoin() {
|
||||||
return '–';
|
return '–';
|
||||||
|
@ -9,7 +9,7 @@ import {helper} from '@ember/component/helper';
|
|||||||
*
|
*
|
||||||
* This example will return https://myurl.com?utm_source=admin
|
* This example will return https://myurl.com?utm_source=admin
|
||||||
*
|
*
|
||||||
* You can set every query/search parameter you want. It will override existing paramters if they are already set.
|
* You can set every query/search parameter you want. It will override existing parameters if they are already set.
|
||||||
*/
|
*/
|
||||||
export function setQueryParams([url], parameters) {
|
export function setQueryParams([url], parameters) {
|
||||||
if (url) {
|
if (url) {
|
||||||
|
@ -57,8 +57,8 @@ import {tracked} from '@glimmer/tracking';
|
|||||||
/**
|
/**
|
||||||
* @typedef PaidMembersByCadence
|
* @typedef PaidMembersByCadence
|
||||||
* @type {Object}
|
* @type {Object}
|
||||||
* @property {number} year Paid memebrs on annual plan
|
* @property {number} year Paid members on annual plan
|
||||||
* @property {number} month Paid memebrs on monthly plan
|
* @property {number} month Paid members on monthly plan
|
||||||
*/
|
*/
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -130,7 +130,7 @@
|
|||||||
color: color-mod(var(--midgrey));
|
color: color-mod(var(--midgrey));
|
||||||
}
|
}
|
||||||
|
|
||||||
/* TODO: remove the gh-image-uploader classes once it's using gh-progrss-bar */
|
/* TODO: remove the gh-image-uploader classes once it's using gh-progress-bar */
|
||||||
.gh-image-uploader .progress-container,
|
.gh-image-uploader .progress-container,
|
||||||
.gh-progress-container {
|
.gh-progress-container {
|
||||||
flex-grow: 1;
|
flex-grow: 1;
|
||||||
|
@ -168,7 +168,7 @@ export function getCurrencyOptions() {
|
|||||||
* based on Stripe's requirements. Values here are double the Stripe limits, to take conversions to the settlement currency into account.
|
* based on Stripe's requirements. Values here are double the Stripe limits, to take conversions to the settlement currency into account.
|
||||||
* @see https://stripe.com/docs/currencies#minimum-and-maximum-charge-amounts
|
* @see https://stripe.com/docs/currencies#minimum-and-maximum-charge-amounts
|
||||||
* @param {String} currency — Currency in the 3-letter ISO format (e.g. "USD", "EUR")
|
* @param {String} currency — Currency in the 3-letter ISO format (e.g. "USD", "EUR")
|
||||||
* @retuns {Number} — Minimum amount
|
* @returns {Number} — Minimum amount
|
||||||
*/
|
*/
|
||||||
export function minimumAmountForCurrency(currency) {
|
export function minimumAmountForCurrency(currency) {
|
||||||
const isoCurrency = currency?.toUpperCase();
|
const isoCurrency = currency?.toUpperCase();
|
||||||
|
@ -235,7 +235,7 @@ describe('Acceptance: Editor', function () {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it('shows author token input and allows changing of authors in PSM', async function () {
|
it('shows author token input and allows changing of authors in PSM', async function () {
|
||||||
let adminRole = this.server.create('role', {name: 'Adminstrator'});
|
let adminRole = this.server.create('role', {name: 'Administrator'});
|
||||||
let authorRole = this.server.create('role', {name: 'Author'});
|
let authorRole = this.server.create('role', {name: 'Author'});
|
||||||
let user1 = this.server.create('user', {name: 'Primary', roles: [adminRole]});
|
let user1 = this.server.create('user', {name: 'Primary', roles: [adminRole]});
|
||||||
this.server.create('user', {name: 'Waldo', roles: [authorRole]});
|
this.server.create('user', {name: 'Waldo', roles: [authorRole]});
|
||||||
|
@ -174,7 +174,7 @@
|
|||||||
// expect(navSetting.value).to.equal('[{"label":"About","url":"/about"},{"label":"New","url":"/new/"}]');
|
// expect(navSetting.value).to.equal('[{"label":"About","url":"/about"},{"label":"New","url":"/new/"}]');
|
||||||
// });
|
// });
|
||||||
|
|
||||||
// it('can also add and remove items from seconday nav', async function () {
|
// it('can also add and remove items from secondray nav', async function () {
|
||||||
// await visit('/settings/navigation');
|
// await visit('/settings/navigation');
|
||||||
// await click('#secondary-navigation .gh-blognav-add');
|
// await click('#secondary-navigation .gh-blognav-add');
|
||||||
|
|
||||||
|
@ -198,7 +198,7 @@ describe('Acceptance: Signup', function () {
|
|||||||
expect(find('.gh-alert-content').textContent).to.have.string('Invalid token');
|
expect(find('.gh-alert-content').textContent).to.have.string('Invalid token');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('redirects with alert on non-existant or expired token', async function () {
|
it('redirects with alert on non-existent or expired token', async function () {
|
||||||
this.server.get('/authentication/invitation', function () {
|
this.server.get('/authentication/invitation', function () {
|
||||||
return {
|
return {
|
||||||
invitation: [{valid: false}]
|
invitation: [{valid: false}]
|
||||||
|
@ -37,7 +37,7 @@ describe('Integration: Component: gh-unsplash', function () {
|
|||||||
|
|
||||||
describe('closing', function () {
|
describe('closing', function () {
|
||||||
it('triggers close action');
|
it('triggers close action');
|
||||||
it('can be triggerd by escape key');
|
it('can be triggered by escape key');
|
||||||
it('cannot be triggered by escape key when zoomed');
|
it('cannot be triggered by escape key when zoomed');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
@ -1,7 +1,7 @@
|
|||||||
# Members Csv
|
# Members Csv
|
||||||
|
|
||||||
## Usage
|
## Usage
|
||||||
There are 2 parts to this package: CSV to JSON serialization and JSON to CSV serialization. The module exposes 2 methods to fullfil these: `parse` and `unparse` respectively.
|
There are 2 parts to this package: CSV to JSON serialization and JSON to CSV serialization. The module exposes 2 methods to fulfil these: `parse` and `unparse` respectively.
|
||||||
|
|
||||||
To `parse` CSV file and convert it to JSON use `parse` method, e.g.:
|
To `parse` CSV file and convert it to JSON use `parse` method, e.g.:
|
||||||
```js
|
```js
|
||||||
|
Loading…
Reference in New Issue
Block a user