Merge pull request #4544 from PaulAdamDavis/notification-over-nav

Allow notifications to sit over the nav bar

core/client/assets/sass/layouts/default.scss

@@ -38,7 +38,6 @@
     bottom: 0;
     left: 0;
     overflow: hidden;
-    z-index: 500; // Above the .global-nav when collapsed
     transition: transform $settings-menu-transition cubic-bezier($settings-menu-bezier);
 
     @media (max-width: 900px) {
@@ -97,6 +96,16 @@
     }
 }
 
+// A <span> that wraps the main {{outlet}} which created a new z-index stack, separate to the nav
+.viewport-content {
+    position: absolute;
+    top: 0;
+    right: 0;
+    bottom: 0;
+    left: 0;
+    z-index: 500; // Above the .global-nav when collapsed
+}
+
 
 //
 // The header bar

core/client/templates/application.hbs

@@ -7,7 +7,9 @@
 <main id="gh-main" class="viewport" role="main" {{bind-attr data-notification-count=topNotificationCount}}>
     {{gh-notifications location="top" notify="topNotificationChange"}}
     {{gh-notifications location="bottom"}}
-    {{outlet}}
+    <span class="viewport-content">
+        {{outlet}}
+    </span>
 </main>
 
 {{outlet modal}}