Revert Portal changes (#19594)

no issue

- This revert recent changes made to Portal, that may be causing the
Free tier to not render properly on Ghost sites
This commit is contained in:
Sag 2024-01-27 01:46:59 +01:00 committed by GitHub
parent 7a1bd52652
commit 1e988cccff
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 19 additions and 8 deletions

View File

@ -47,6 +47,10 @@ const features = [{
title: 'Tips & donations', title: 'Tips & donations',
description: 'Enables publishers to collect one-time payments', description: 'Enables publishers to collect one-time payments',
flag: 'tipsAndDonations' flag: 'tipsAndDonations'
},{
title: 'Filter by email disabled',
description: 'Allows filtering members by email disabled',
flag: 'filterEmailDisabled'
},{ },{
title: 'AdminX Demo', title: 'AdminX Demo',
description: 'Adds a navigation link to the AdminX demo app', description: 'Adds a navigation link to the AdminX demo app',
@ -55,6 +59,10 @@ const features = [{
title: 'New email addresses', title: 'New email addresses',
description: 'For self hosters, forces the usage of the mail.from config as from address for all outgoing emails', description: 'For self hosters, forces the usage of the mail.from config as from address for all outgoing emails',
flag: 'newEmailAddresses' flag: 'newEmailAddresses'
},{
title: 'Portal improvements',
description: 'Adds a bunch of improvements to portal and portal settings',
flag: 'portalImprovements'
}]; }];
const AlphaFeatures: React.FC = () => { const AlphaFeatures: React.FC = () => {

View File

@ -431,8 +431,7 @@ export function getSiteProducts({site, pageQuery}) {
} }
if (hasFreeProductPrice({site})) { if (hasFreeProductPrice({site})) {
products.unshift({ products.unshift({
id: 'free', id: 'free'
type: 'free'
}); });
} }
return products; return products;
@ -451,8 +450,11 @@ export function getFreeProductBenefits({site}) {
} }
export function getFreeTierTitle({site}) { export function getFreeTierTitle({site}) {
const freeProduct = getFreeProduct({site}); if (hasOnlyFreeProduct({site})) {
return freeProduct?.name || 'Free'; return 'Free membership';
} else {
return 'Free';
}
} }
export function getFreeTierDescription({site}) { export function getFreeTierDescription({site}) {

View File

@ -22,8 +22,7 @@ const GA_FEATURES = [
'signupForm', 'signupForm',
'recommendations', 'recommendations',
'listUnsubscribeHeader', 'listUnsubscribeHeader',
'filterEmailDisabled', 'filterEmailDisabled'
'portalImprovements'
]; ];
// NOTE: this allowlist is meant to be used to filter out any unexpected // NOTE: this allowlist is meant to be used to filter out any unexpected
@ -46,8 +45,10 @@ const ALPHA_FEATURES = [
'importMemberTier', 'importMemberTier',
'lexicalIndicators', 'lexicalIndicators',
// 'adminXOffers', // 'adminXOffers',
'filterEmailDisabled',
'adminXDemo', 'adminXDemo',
'newEmailAddresses' 'newEmailAddresses',
'portalImprovements'
]; ];
module.exports.GA_KEYS = [...GA_FEATURES]; module.exports.GA_KEYS = [...GA_FEATURES];

View File

@ -1155,7 +1155,7 @@ exports[`Settings API Edit Can edit a setting 2: [headers] 1`] = `
Object { Object {
"access-control-allow-origin": "http://127.0.0.1:2369", "access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0", "cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "4535", "content-length": "4507",
"content-type": "application/json; charset=utf-8", "content-type": "application/json; charset=utf-8",
"content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/, "content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/, "etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,